[GitHub] [bookkeeper] trevor211 opened a new pull request, #3864: fix wrong implementation for `percentile` in bookkeeper-benchmark

trevor211 opened a new pull request, #3864: URL: https://github.com/apache/bookkeeper/pull/3864 According to `https://stackoverflow.com/questions/12808934/what-is-p99-latency`, the implementation for `percentile` in bookkeeper-benchmark is wrong. Descriptions of the changes in this

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3846: Streamline batch add request

hangc0276 commented on code in PR #3846: URL: https://github.com/apache/bookkeeper/pull/3846#discussion_r1134923932 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteBatchEntryProcessor.java: ## @@ -0,0 +1,143 @@ +/* + * + * Licensed to the Apache Software

[GitHub] [bookkeeper] horizonzy commented on a diff in pull request #3846: Streamline batch add request

horizonzy commented on code in PR #3846: URL: https://github.com/apache/bookkeeper/pull/3846#discussion_r1134833855 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteBatchEntryProcessor.java: ## @@ -0,0 +1,143 @@ +/* + * + * Licensed to the Apache Software

[GitHub] [bookkeeper] Nicklee007 commented on pull request #3860: Modify incorrect rocksDB config level_compaction_dynamic_level_bytes to CFOptions

Nicklee007 commented on PR #3860: URL: https://github.com/apache/bookkeeper/pull/3860#issuecomment-1467294240 > Would you please add a test to check whether the parameter has been set correctly? @hangc0276 add some unit test, PTAL. -- This is an automated message from the Apache

[GitHub] [bookkeeper] yaalsn opened a new pull request, #3863: Disable code coverage and Codecov report

yaalsn opened a new pull request, #3863: URL: https://github.com/apache/bookkeeper/pull/3863 ### Motivation There're two reasons that we want to disable the code coverage. 1. The current report result is not accurate. 2. We can't get the PR's unit test's code coverage

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3862: Update website to 4.15.4

codecov-commenter commented on PR #3862: URL: https://github.com/apache/bookkeeper/pull/3862#issuecomment-1467272885 ##

[bookkeeper] annotated tag release-4.15.4 updated (44f87efb81 -> 70a09b8a91)

This is an automated email from the ASF dual-hosted git repository. yong pushed a change to annotated tag release-4.15.4 in repository https://gitbox.apache.org/repos/asf/bookkeeper.git *** WARNING: tag release-4.15.4 was modified! *** from 44f87efb81 (commit) to 70a09b8a91 (tag)

[GitHub] [bookkeeper] zymap opened a new pull request, #3862: Update website to 4.15.4

zymap opened a new pull request, #3862: URL: https://github.com/apache/bookkeeper/pull/3862 --- ### Motivation Update website to 4.15.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

svn commit: r60573 - /dev/bookkeeper/bookkeeper-4.15.4-rc0/ /release/bookkeeper/bookkeeper-4.15.4/

Author: yong Date: Tue Mar 14 02:19:35 2023 New Revision: 60573 Log: Release 4.15.4 Added: release/bookkeeper/bookkeeper-4.15.4/ - copied from r60572, dev/bookkeeper/bookkeeper-4.15.4-rc0/ Removed: dev/bookkeeper/bookkeeper-4.15.4-rc0/

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3679: Add ledgerDir to GarbageCollectionStatus

hangc0276 commented on code in PR #3679: URL: https://github.com/apache/bookkeeper/pull/3679#discussion_r1134735869 ## bookkeeper-server/src/test/java/org/apache/bookkeeper/server/http/TestHttpService.java: ## @@ -832,6 +833,7 @@ public void testGCDetailsService() throws

[GitHub] [bookkeeper] hangc0276 commented on pull request #3794: Pick the higher leak detection level between netty and bookkeeper.

hangc0276 commented on PR #3794: URL: https://github.com/apache/bookkeeper/pull/3794#issuecomment-1467122364 @horizonzy Please rebase the master, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3794: Pick the higher leak detection level between netty and bookkeeper.

hangc0276 commented on code in PR #3794: URL: https://github.com/apache/bookkeeper/pull/3794#discussion_r1134720134 ## bookkeeper-common-allocator/src/main/java/org/apache/bookkeeper/common/allocator/LeakDetectionPolicy.java: ## @@ -43,5 +43,15 @@ public enum

[GitHub] [bookkeeper] hangc0276 commented on pull request #3508: fix(sec): upgrade commons-codec to 1.13

hangc0276 commented on PR #3508: URL: https://github.com/apache/bookkeeper/pull/3508#issuecomment-1467110936 @NanKeXXX Thanks for your contribution. Would you please rebase the master and fix the failed CI? -- This is an automated message from the Apache Git Service. To respond to the

[bookkeeper] branch master updated (caea6c9451 -> ebf3108d54)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git from caea6c9451 [Flaky] Fix flaky test in testRaceGuavaEvictAndReleaseBeforeRetain (#3857) add ebf3108d54 Fix

[GitHub] [bookkeeper] merlimat merged pull request #3859: Fix NPE in BenchThroughputLatency

merlimat merged PR #3859: URL: https://github.com/apache/bookkeeper/pull/3859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[bookkeeper] branch master updated (1a8d84251b -> caea6c9451)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git from 1a8d84251b Bump checkstyle-plugin from 3.1.2 to 3.2.1 (#3850) add caea6c9451 [Flaky] Fix flaky test in

[GitHub] [bookkeeper] merlimat merged pull request #3857: [Flaky] Fix flaky test in testRaceGuavaEvictAndReleaseBeforeRetain

merlimat merged PR #3857: URL: https://github.com/apache/bookkeeper/pull/3857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] horizonzy commented on pull request #3848: Improve group and flush add-responses after journal sync

horizonzy commented on PR #3848: URL: https://github.com/apache/bookkeeper/pull/3848#issuecomment-1466405778 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3861: Bump @sideway/formula from 3.0.0 to 3.0.1 in /site3/website

codecov-commenter commented on PR #3861: URL: https://github.com/apache/bookkeeper/pull/3861#issuecomment-1466186936 ##

[GitHub] [bookkeeper] dependabot[bot] opened a new pull request, #3861: Bump @sideway/formula from 3.0.0 to 3.0.1 in /site3/website

dependabot[bot] opened a new pull request, #3861: URL: https://github.com/apache/bookkeeper/pull/3861 Bumps [@sideway/formula](https://github.com/sideway/formula) from 3.0.0 to 3.0.1. Commits

[bookkeeper] branch dependabot/npm_and_yarn/site3/website/sideway/formula-3.0.1 created (now 339e0f4846)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/site3/website/sideway/formula-3.0.1 in repository https://gitbox.apache.org/repos/asf/bookkeeper.git at 339e0f4846 Bump @sideway/formula from 3.0.0 to 3.0.1 in

[bookkeeper] branch master updated: Bump checkstyle-plugin from 3.1.2 to 3.2.1 (#3850)

This is an automated email from the ASF dual-hosted git repository. nicoloboschi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new 1a8d84251b Bump checkstyle-plugin

[GitHub] [bookkeeper] nicoloboschi merged pull request #3850: Bump checkstyle-plugin from 3.1.2 to 3.2.1

nicoloboschi merged PR #3850: URL: https://github.com/apache/bookkeeper/pull/3850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] Nicklee007 commented on pull request #3860: Modify incorrect rocksDB config level_compaction_dynamic_level_bytes to CFOptions

Nicklee007 commented on PR #3860: URL: https://github.com/apache/bookkeeper/pull/3860#issuecomment-1466075974 > entry_location_rocksdb.conf also has the problem. @horizonzy Modify the test_entry_location_rocksdb.conf & entry_location_rocksdb.conf. -- This is an automated message

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3846: Streamline batch add request

hangc0276 commented on code in PR #3846: URL: https://github.com/apache/bookkeeper/pull/3846#discussion_r1133741341 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieRequestProcessor.java: ## @@ -229,6 +230,16 @@ protected void onAddRequestFinish() {

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3860: Modify incorrect rocksDB config level_compaction_dynamic_level_bytes to CFOptions

codecov-commenter commented on PR #3860: URL: https://github.com/apache/bookkeeper/pull/3860#issuecomment-1465737664 ##

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3631: Add small files check in garbage collection

codecov-commenter commented on PR #3631: URL: https://github.com/apache/bookkeeper/pull/3631#issuecomment-1465730783 ##

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3631: Add small files check in garbage collection

hangc0276 commented on code in PR #3631: URL: https://github.com/apache/bookkeeper/pull/3631#discussion_r1133574229 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java: ## @@ -548,14 +548,24 @@ private boolean

[GitHub] [bookkeeper] Nicklee007 opened a new pull request, #3860: Modify incorrect rocksDB config level_compaction_dynamic_level_bytes to CFOptions

Nicklee007 opened a new pull request, #3860: URL: https://github.com/apache/bookkeeper/pull/3860 ### Motivation After PR #3056 , Bookkeeper set `level_compaction_dynamic_level_bytes=true` as `TableOptions` in `entry_location_rocksdb.conf.default` , which will cause

[GitHub] [bookkeeper] StevenLuMT merged pull request #3762: [improve] Fix indexDirs upgrade failed

StevenLuMT merged PR #3762: URL: https://github.com/apache/bookkeeper/pull/3762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: