Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-09 Thread via GitHub
eolivelli merged PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-08 Thread via GitHub
shoothzj commented on PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#issuecomment-2101856802 @dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT @wenbingshen @zhaijack PTAL -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-07 Thread via GitHub
shoothzj commented on PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#issuecomment-2098206949 @dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT @wenbingshen @zhaijack PTAL -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-06 Thread via GitHub
shoothzj commented on PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#issuecomment-2097197427 @dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT @wenbingshen @zhaijack PTAL -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-06 Thread via GitHub
shoothzj commented on code in PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590666985 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java: ## @@ -192,7 +192,6 @@ private JournalChannel(File journalDirectory, long

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-06 Thread via GitHub
eolivelli commented on code in PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590655146 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java: ## @@ -192,7 +192,6 @@ private JournalChannel(File journalDirectory, long

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-06 Thread via GitHub
shoothzj commented on code in PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590554009 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java: ## @@ -192,7 +192,6 @@ private JournalChannel(File journalDirectory, long

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-06 Thread via GitHub
shoothzj commented on code in PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590553534 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java: ## @@ -299,6 +298,8 @@ int read(ByteBuffer dst) public void close()

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-05 Thread via GitHub
shoothzj commented on code in PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590554009 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java: ## @@ -192,7 +192,6 @@ private JournalChannel(File journalDirectory, long

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-05 Thread via GitHub
shoothzj commented on code in PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590553534 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java: ## @@ -299,6 +298,8 @@ int read(ByteBuffer dst) public void close()

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-05 Thread via GitHub
eolivelli commented on code in PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590536703 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java: ## @@ -299,6 +298,8 @@ int read(ByteBuffer dst) public void close()

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-05 Thread via GitHub
eolivelli commented on code in PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#discussion_r1590536094 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/JournalChannel.java: ## @@ -192,7 +192,6 @@ private JournalChannel(File journalDirectory, long

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-05 Thread via GitHub
shoothzj commented on PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#issuecomment-2094744842 @dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT @wenbingshen @zhaijack PTAL -- This is an automated message from the Apache Git Service. To respond to the message,