jamesstarr commented on pull request #2639:
URL: https://github.com/apache/calcite/pull/2639#issuecomment-990675884
Have you consider adding a default implementation directly to handler
interface and deprecating the method?
--
This is an automated message from the Apache Git Service.
jamesstarr commented on a change in pull request #2638:
URL: https://github.com/apache/calcite/pull/2638#discussion_r766384348
##
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMetadataQueryBase.java
##
@@ -75,11 +78,20 @@
new ThreadLocal<>();
vlsi commented on a change in pull request #2627:
URL: https://github.com/apache/calcite/pull/2627#discussion_r766332226
##
File path: core/src/main/java/org/apache/calcite/rel/RelDistributions.java
##
@@ -103,7 +103,7 @@ private RelDistributionImpl(Type type, ImmutableIntList
guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-990599647
@zabetak Setting table display to block has the side effect of not filling
the full width of a table with less content.
Like this
chunweilei commented on pull request #2627:
URL: https://github.com/apache/calcite/pull/2627#issuecomment-990554935
BTW, you can find more details about contribution in the doc[1].
[1] https://calcite.apache.org/develop/#contributing
--
This is an automated message from the Apache
chunweilei commented on a change in pull request #2627:
URL: https://github.com/apache/calcite/pull/2627#discussion_r766299335
##
File path: core/src/main/java/org/apache/calcite/rel/RelDistributions.java
##
@@ -103,7 +103,7 @@ private RelDistributionImpl(Type type,
jacques-n opened a new pull request #2639:
URL: https://github.com/apache/calcite/pull/2639
- Add default getDef() methods.
- Mark all function metadata handler interfaces as FunctionalInterface where
possible.
- Update MetdataDef and RelMetdataHandlerGeneratorUtil to ignore getDef()
jacques-n commented on pull request #2638:
URL: https://github.com/apache/calcite/pull/2638#issuecomment-990290181
FYI @jamesstarr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jacques-n opened a new pull request #2638:
URL: https://github.com/apache/calcite/pull/2638
- Introduce a new interface: MetadataHandlerProvider.
- Move RelMetadataQuery to rely on MetadataHandlerProvider instead of Janino
directly
- Update JaninoRelMetaDataProvider to implement
zabetak commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-990008705
How "crowded" a table is does not depend only on the content but also on the
size of the screen/window/browser.
I did verify that changes seem to have the intended
guiyanakuang edited a comment on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-989976407
> @guiyanakuang The changes about code wrapping and scrollability are a good
idea but they are more useful if the apply everywhere. After playing a bit and
resizing
guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-989976407
> @guiyanakuang The changes about code wrapping and scrollability are a good
idea but they are more useful if the apply everywhere. After playing a bit and
resizing the
zabetak commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-989891958
@guiyanakuang The changes about code wrapping and scrollability are a good
idea but they are more useful if the apply everywhere. After playing a bit and
resizing the window I
This is an automated email from the ASF dual-hosted git repository.
xiong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit 86dce8ac04ccd7f29f6b60c5b33ef6d14d8dbc58
Author: nobigo
AuthorDate: Thu Dec 9 09:25:21 2021 +0800
Log plan after
This is an automated email from the ASF dual-hosted git repository.
xiong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit 264636e803f6b971112d826e268e309e3ed1e513
Author: Stamatis Zampetakis
AuthorDate: Wed Dec 8 17:29:10 2021 +0100
This is an automated email from the ASF dual-hosted git repository.
xiong pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git.
omit 15789da [CALCITE-4927] Remove deprecated
RelBuilder#groupKey(ImmutableBitSet, ImmutableList) clashing with new
guiyanakuang commented on pull request #2632:
URL: https://github.com/apache/calcite/pull/2632#issuecomment-989822777
@zabetak, thanks for approving to this pr, I am reading the source code of
calcite and look forward to the subsequent community collaboration.
--
This is an automated
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/calcite.git.
from c18a00b reformat debug log about the plan which after physical tweaks
add 15789da [CALCITE-4927] Remove
zabetak closed pull request #2635:
URL: https://github.com/apache/calcite/pull/2635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Author: zabetak
Date: Thu Dec 9 10:35:10 2021
New Revision: 51268
Log:
Add signing key for Rui Wang to KEYS
Modified:
release/calcite/KEYS
Modified: release/calcite/KEYS
==
--- release/calcite/KEYS (original)
+++
rubenada commented on pull request #2635:
URL: https://github.com/apache/calcite/pull/2635#issuecomment-989666709
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
21 matches
Mail list logo
