vaijosh commented on PR #217:
URL: https://github.com/apache/calcite-avatica/pull/217#issuecomment-1521134592
>
Hi @joshelser
Did you get a chance to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chunweilei commented on code in PR #3169:
URL: https://github.com/apache/calcite/pull/3169#discussion_r1175978371
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1426,6 +1448,61 @@ protected enum MatchModality {
chunweilei commented on code in PR #3168:
URL: https://github.com/apache/calcite/pull/3168#discussion_r1175966928
##
core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java:
##
@@ -955,6 +961,52 @@ public static boolean canCastFrom(
return
chunweilei commented on PR #3168:
URL: https://github.com/apache/calcite/pull/3168#issuecomment-1521093194
Could you please correct the format of commit message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chunweilei commented on code in PR #3143:
URL: https://github.com/apache/calcite/pull/3143#discussion_r1175963078
##
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##
@@ -1793,16 +1761,53 @@ private > RexNode
simplifyAnd2ForUnknownAsFalse(
return
zinking commented on PR #3163:
URL: https://github.com/apache/calcite/pull/3163#issuecomment-1521049025
> @zinking
>
> Sorry, I don't understand your question. Can you give more details?
in your description, you mentioned before the new approach that old approach
wont work. I
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit 8db5403d2e2278d25d98aa5c2f0a299574234b7c
Author: Leonid Chistov
AuthorDate: Fri Apr 14 12:48:14 2023 +0300
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
discard 9360b889db [CALICTE-5646] JoinDeriveIsNotNullFilterRule incorrectly
handles COALESCE in join condition
new
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 9360b889db [CALICTE-5646]
zabetak merged PR #3149:
URL: https://github.com/apache/calcite/pull/3149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3175:
URL: https://github.com/apache/calcite/pull/3175#issuecomment-1520749597
Kudos, SonarCloud Quality Gate passed! [ {
final RexCallImplementor value =
tanclary commented on code in PR #3125:
URL: https://github.com/apache/calcite/pull/3125#discussion_r1175495036
##
babel/src/test/resources/sql/big-query.iq:
##
@@ -398,14 +398,12 @@ SELECT
# In the following example, EXTRACT returns values corresponding to
# different date
cgivre commented on PR #3174:
URL: https://github.com/apache/calcite/pull/3174#issuecomment-1520437685
> For future reference I believe you can run the gradle target
"autostyleApply" to hopefully avoid having to manually fix some of the linting
errors. Hope this helps!
Thanks
tanclary commented on code in PR #3125:
URL: https://github.com/apache/calcite/pull/3125#discussion_r1175495658
##
core/src/main/java/org/apache/calcite/rel/type/TimeFrameSet.java:
##
@@ -287,6 +287,41 @@ public long diffTimestamp(long timestamp, long timestamp2,
TimeFrame
tanclary commented on code in PR #3125:
URL: https://github.com/apache/calcite/pull/3125#discussion_r1175492762
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -5127,8 +5127,6 @@ SqlIntervalQualifier TimeUnit() : {
|{ return new SqlIntervalQualifier(TimeUnit.MINUTE,
tanclary commented on PR #3174:
URL: https://github.com/apache/calcite/pull/3174#issuecomment-1520431397
For future reference I believe you can run the gradle target
"autostyleApply" to hopefully avoid having to manually fix some of the linting
errors. Hope this helps!
--
This is an
sonarcloud[bot] commented on PR #3149:
URL: https://github.com/apache/calcite/pull/3149#issuecomment-1520408872
Kudos, SonarCloud Quality Gate passed! [ {
cgivre commented on code in PR #3174:
URL: https://github.com/apache/calcite/pull/3174#discussion_r1175280102
##
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/UnsafeX509ExtendedTrustManager.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software
libenchao commented on code in PR #3174:
URL: https://github.com/apache/calcite/pull/3174#discussion_r1175136488
##
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/UnsafeX509ExtendedTrustManager.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache
LeonidChistov commented on PR #3163:
URL: https://github.com/apache/calcite/pull/3163#issuecomment-1520072840
@zinking
Sorry, I don't understand your question. Can you give more details?
--
This is an automated message from the Apache Git Service.
To respond to the message,
sonarcloud[bot] commented on PR #3148:
URL: https://github.com/apache/calcite/pull/3148#issuecomment-1520042892
Kudos, SonarCloud Quality Gate passed! [ {
zinking commented on code in PR #3174:
URL: https://github.com/apache/calcite/pull/3174#discussion_r1175172824
##
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java:
##
@@ -131,10 +135,20 @@ public ElasticsearchSchemaFactory() {
rubenada commented on PR #3148:
URL: https://github.com/apache/calcite/pull/3148#issuecomment-1519991746
LGTM
@zoudan could you please squash commits into a single one? (please make sure
that the commit message mentions "BigQuery and PostgreSQL libraries")
--
This is an automated
zinking commented on PR #3163:
URL: https://github.com/apache/calcite/pull/3163#issuecomment-1519956260
nicely written up!
```
This approach does not work well when field names collide in left and right
sides of semi-join (like DEPTNO in our case).
```
did you mean the old
liuyongvs commented on PR #3161:
URL: https://github.com/apache/calcite/pull/3161#issuecomment-1519911766
hi @libenchao do you have time to review now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
liuyongvs commented on code in PR #3161:
URL: https://github.com/apache/calcite/pull/3161#discussion_r1175122427
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5167,6 +5167,18 @@ private static void checkIf(SqlOperatorFixture f) {
liuyongvs commented on code in PR #3161:
URL: https://github.com/apache/calcite/pull/3161#discussion_r1175122427
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5167,6 +5167,18 @@ private static void checkIf(SqlOperatorFixture f) {
zinking commented on code in PR #3125:
URL: https://github.com/apache/calcite/pull/3125#discussion_r1175111296
##
core/src/main/java/org/apache/calcite/rel/type/TimeFrameSet.java:
##
@@ -287,6 +287,41 @@ public long diffTimestamp(long timestamp, long timestamp2,
TimeFrame
zinking commented on code in PR #3125:
URL: https://github.com/apache/calcite/pull/3125#discussion_r1175110165
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -5127,8 +5127,6 @@ SqlIntervalQualifier TimeUnit() : {
|{ return new SqlIntervalQualifier(TimeUnit.MINUTE,
zinking commented on code in PR #3125:
URL: https://github.com/apache/calcite/pull/3125#discussion_r1175110165
##
core/src/main/codegen/templates/Parser.jj:
##
@@ -5127,8 +5127,6 @@ SqlIntervalQualifier TimeUnit() : {
|{ return new SqlIntervalQualifier(TimeUnit.MINUTE,
zinking commented on code in PR #3125:
URL: https://github.com/apache/calcite/pull/3125#discussion_r1175109369
##
babel/src/test/resources/sql/big-query.iq:
##
@@ -398,14 +398,12 @@ SELECT
# In the following example, EXTRACT returns values corresponding to
# different date
dssysolyatin commented on code in PR #3167:
URL: https://github.com/apache/calcite/pull/3167#discussion_r1175013204
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -678,7 +683,13 @@ Builder populate2() {
final RexCallImplementor value
rubenada commented on code in PR #3172:
URL: https://github.com/apache/calcite/pull/3172#discussion_r1174933805
##
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinJoinTransposeRule.java:
##
@@ -102,16 +101,18 @@ public SemiJoinJoinTransposeRule(RelBuilderFactory
asolimando commented on code in PR #3143:
URL: https://github.com/apache/calcite/pull/3143#discussion_r1174920463
##
core/src/main/java/org/apache/calcite/rex/RexSimplify.java:
##
@@ -1793,16 +1761,53 @@ private > RexNode
simplifyAnd2ForUnknownAsFalse(
return
sonarcloud[bot] commented on PR #3148:
URL: https://github.com/apache/calcite/pull/3148#issuecomment-1519564902
Kudos, SonarCloud Quality Gate passed! [