[calcite] branch main updated: [CALCITE-5677] SUBSTR signature incorrect for BigQuery

2023-05-08 Thread dmsysolyatin
This is an automated email from the ASF dual-hosted git repository. dmsysolyatin pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 9007d3afad [CALCITE-5677] SUBSTR signature

[GitHub] [calcite] dssysolyatin merged pull request #3178: [CALCITE-5677] SUBSTR signature incorrect for BigQuery

2023-05-08 Thread via GitHub
dssysolyatin merged PR #3178: URL: https://github.com/apache/calcite/pull/3178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3193: URL: https://github.com/apache/calcite/pull/3193#issuecomment-1539390112 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] HanumathRao opened a new pull request, #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-08 Thread via GitHub
HanumathRao opened a new pull request, #3193: URL: https://github.com/apache/calcite/pull/3193 …on during decorrelation. Currently two level correlated subqueries with more than one correlated variables are throwing exception, the fix is to track the correlated variables and then

[GitHub] [calcite] chunweilei commented on a diff in pull request #3192: [CALCITE-5602] Implement CSC and SEC function

2023-05-08 Thread via GitHub
chunweilei commented on code in PR #3192: URL: https://github.com/apache/calcite/pull/3192#discussion_r1188066873 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1219,6 +1219,20 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding

[GitHub] [calcite] JiajunBernoulli commented on pull request #3161: [CALCITE-5657] Add ARRAY_DISTINCT function (enabled in Spark library).

2023-05-08 Thread via GitHub
JiajunBernoulli commented on PR #3161: URL: https://github.com/apache/calcite/pull/3161#issuecomment-1539276885 Can you rebase `main` and `push -f` to rerun CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] julianhyde commented on a diff in pull request #3168: CALCITE-5662/ Allow CAST(BOOLEAN as INTEGER)

2023-05-08 Thread via GitHub
julianhyde commented on code in PR #3168: URL: https://github.com/apache/calcite/pull/3168#discussion_r1188031401 ## core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java: ## @@ -10501,7 +10508,8 @@ private void checkCustomColumnResolving(String table) { final

[GitHub] [calcite] julianhyde commented on a diff in pull request #3168: CALCITE-5662/ Allow CAST(BOOLEAN as INTEGER)

2023-05-08 Thread via GitHub
julianhyde commented on code in PR #3168: URL: https://github.com/apache/calcite/pull/3168#discussion_r1188030256 ## core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java: ## @@ -253,7 +257,17 @@ private void compareTypesIgnoringNullability( } } + @Test

[GitHub] [calcite] julianhyde commented on a diff in pull request #3168: CALCITE-5662/ Allow CAST(BOOLEAN as INTEGER)

2023-05-08 Thread via GitHub
julianhyde commented on code in PR #3168: URL: https://github.com/apache/calcite/pull/3168#discussion_r1188027589 ## core/src/main/java/org/apache/calcite/rel/type/RelDataTypeFactory.java: ## @@ -208,6 +209,8 @@ RelDataType createTypeWithCharsetAndCollation( */ @Nullable

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3106: [CALCITE-4554] Support TIMESTAMP WITH LOCAL TIME ZONE for Snapshot and MatchRecognize

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3106: URL: https://github.com/apache/calcite/pull/3106#issuecomment-1539239809 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] snuyanzin commented on pull request #3106: [CALCITE-4554] Support TIMESTAMP WITH LOCAL TIME ZONE for Snapshot and MatchRecognize

2023-05-08 Thread via GitHub
snuyanzin commented on PR #3106: URL: https://github.com/apache/calcite/pull/3106#issuecomment-1539231458 Thanks for having a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3106: [CALCITE-4554] Support TIMESTAMP WITH LOCAL TIME ZONE for Snapshot and MatchRecognize

2023-05-08 Thread via GitHub
snuyanzin commented on code in PR #3106: URL: https://github.com/apache/calcite/pull/3106#discussion_r1188008916 ## core/src/main/java/org/apache/calcite/rel/core/Snapshot.java: ## @@ -131,7 +131,8 @@ public RexNode getPeriod() { @Override public boolean isValid(Litmus

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3106: [CALCITE-4554] Support TIMESTAMP WITH LOCAL TIME ZONE for Snapshot and MatchRecognize

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3106: URL: https://github.com/apache/calcite/pull/3106#issuecomment-1539230842 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3106: [CALCITE-4554] Support TIMESTAMP WITH LOCAL TIME ZONE for Snapshot and MatchRecognize

2023-05-08 Thread via GitHub
snuyanzin commented on code in PR #3106: URL: https://github.com/apache/calcite/pull/3106#discussion_r1188005696 ## core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java: ## @@ -1246,6 +1246,14 @@ public static void checkActualAndReferenceFiles() {

[GitHub] [calcite] snuyanzin commented on a diff in pull request #3106: [CALCITE-4554] Support TIMESTAMP WITH LOCAL TIME ZONE for Snapshot and MatchRecognize

2023-05-08 Thread via GitHub
snuyanzin commented on code in PR #3106: URL: https://github.com/apache/calcite/pull/3106#discussion_r1188005585 ## core/src/test/java/org/apache/calcite/test/RelBuilderTest.java: ## @@ -495,6 +495,30 @@ static RelBuilder createBuilder(UnaryOperator transform) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

2023-05-08 Thread via GitHub
tanclary commented on code in PR #3167: URL: https://github.com/apache/calcite/pull/3167#discussion_r1187922489 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -3090,6 +3102,13 @@ private static class ItemImplementor extends

[GitHub] [calcite] asfgit closed pull request #3131: [CALCITE-5611] Show sql for failed tests for SqlOperatorTest

2023-05-08 Thread via GitHub
asfgit closed pull request #3131: [CALCITE-5611] Show sql for failed tests for SqlOperatorTest URL: https://github.com/apache/calcite/pull/3131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[calcite] branch main updated: [CALCITE-5611] In SqlOperatorTest, show SQL for failed tests

2023-05-08 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new e92a5fcaba [CALCITE-5611] In SqlOperatorTest, show

[GitHub] [calcite] julianhyde commented on a diff in pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

2023-05-08 Thread via GitHub
julianhyde commented on code in PR #3167: URL: https://github.com/apache/calcite/pull/3167#discussion_r1187829498 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3626,11 +3626,15 @@ public static String replace(String s, String search, String

[GitHub] [calcite] julianhyde commented on a diff in pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

2023-05-08 Thread via GitHub
julianhyde commented on code in PR #3167: URL: https://github.com/apache/calcite/pull/3167#discussion_r1187828340 ## core/src/main/java/org/apache/calcite/runtime/CalciteResource.java: ## @@ -885,6 +885,9 @@ ExInst illegalArgumentForTableFunctionCall(String a0,

[GitHub] [calcite] julianhyde commented on a diff in pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

2023-05-08 Thread via GitHub
julianhyde commented on code in PR #3167: URL: https://github.com/apache/calcite/pull/3167#discussion_r1187827849 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -3090,6 +3102,13 @@ private static class ItemImplementor extends

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3167: URL: https://github.com/apache/calcite/pull/3167#issuecomment-1538853867 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[calcite] branch main updated: [CALCITE-5610] Add COTH, CSCH, SECH functions

2023-05-08 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 62a9ee9423 [CALCITE-5610] Add COTH, CSCH, SECH

[GitHub] [calcite] julianhyde closed pull request #3130: [CALCITE-5610] Implement COTH, CSCH, SECH Functions

2023-05-08 Thread via GitHub
julianhyde closed pull request #3130: [CALCITE-5610] Implement COTH, CSCH, SECH Functions URL: https://github.com/apache/calcite/pull/3130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] tanclary commented on pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

2023-05-08 Thread via GitHub
tanclary commented on PR #3167: URL: https://github.com/apache/calcite/pull/3167#issuecomment-1538831318 > @tanclary Please fix conflicts and if there aren't objections, I will merge it tomorrow. @dssysolyatin , Just rebased and fixed conflicts, should be good now. Thanks! -- This

[GitHub] [calcite] tanclary commented on pull request #3178: [CALCITE-5677] SUBSTR signature incorrect for BigQuery

2023-05-08 Thread via GitHub
tanclary commented on PR #3178: URL: https://github.com/apache/calcite/pull/3178#issuecomment-1538829235 Thanks, @dssysolyatin ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] dssysolyatin commented on pull request #3167: [CALCITE-5660] Add array subscript operators OFFSET, ORDINAL, SAFE_OFFSET, SAFE_ORDINAL (enabled for BigQuery)

2023-05-08 Thread via GitHub
dssysolyatin commented on PR #3167: URL: https://github.com/apache/calcite/pull/3167#issuecomment-1538813549 @tanclary Please fix conflicts and if there aren't objections, I will merge it tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] dssysolyatin commented on pull request #3178: [CALCITE-5677] SUBSTR signature incorrect for BigQuery

2023-05-08 Thread via GitHub
dssysolyatin commented on PR #3178: URL: https://github.com/apache/calcite/pull/3178#issuecomment-1538809167 LGMT. If there is no objections, I will merge it tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3130: [CALCITE-5610] Implement COTH, CSCH, SECH Functions

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3130: URL: https://github.com/apache/calcite/pull/3130#issuecomment-1538688020 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3178: [CALCITE-5677] SUBSTR signature incorrect for BigQuery

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3178: URL: https://github.com/apache/calcite/pull/3178#issuecomment-1538593867 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3130: [CALCITE-5610] Implement COTH, CSCH, SECH Functions

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3130: URL: https://github.com/apache/calcite/pull/3130#issuecomment-1538575163 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3130: [CALCITE-5610] Implement COTH, CSCH, SECH Functions

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3130: URL: https://github.com/apache/calcite/pull/3130#issuecomment-1538561585 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3192: [CALCITE-5602] Implement CSC and SEC function

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3192: URL: https://github.com/apache/calcite/pull/3192#issuecomment-1538545498 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3130: [CALCITE-5610] Implement COTH, CSCH, SECH Functions

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3130: URL: https://github.com/apache/calcite/pull/3130#issuecomment-1538533095 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3189: [CALCITE-5674] Cast expr to target type should respect nullable when …

2023-05-08 Thread via GitHub
liuyongvs commented on code in PR #3189: URL: https://github.com/apache/calcite/pull/3189#discussion_r1187345055 ## core/src/main/java/org/apache/calcite/sql/fun/SqlCastFunction.java: ## @@ -122,8 +128,50 @@ static SqlReturnTypeInference returnTypeInference(boolean safe) {

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3189: [CALCITE-5674] Cast expr to target type should respect nullable when …

2023-05-08 Thread via GitHub
liuyongvs commented on code in PR #3189: URL: https://github.com/apache/calcite/pull/3189#discussion_r1187344362 ## core/src/main/java/org/apache/calcite/sql/fun/SqlCastFunction.java: ## @@ -122,8 +128,50 @@ static SqlReturnTypeInference returnTypeInference(boolean safe) {

[GitHub] [calcite] libenchao commented on a diff in pull request #3106: [CALCITE-4554] Support TIMESTAMP WITH LOCAL TIME ZONE for Snapshot and MatchRecognize

2023-05-08 Thread via GitHub
libenchao commented on code in PR #3106: URL: https://github.com/apache/calcite/pull/3106#discussion_r1187324497 ## core/src/main/java/org/apache/calcite/rel/core/Snapshot.java: ## @@ -131,7 +131,8 @@ public RexNode getPeriod() { @Override public boolean isValid(Litmus

[GitHub] [calcite] libenchao commented on a diff in pull request #3189: [CALCITE-5674] Cast expr to target type should respect nullable when …

2023-05-08 Thread via GitHub
libenchao commented on code in PR #3189: URL: https://github.com/apache/calcite/pull/3189#discussion_r1187308259 ## core/src/main/java/org/apache/calcite/sql/fun/SqlCastFunction.java: ## @@ -122,8 +128,50 @@ static SqlReturnTypeInference returnTypeInference(boolean safe) {

[GitHub] [calcite] libenchao commented on pull request #3106: [CALCITE-4554] Support TIMESTAMP WITH LOCAL TIME ZONE for Snapshot and MatchRecognize

2023-05-08 Thread via GitHub
libenchao commented on PR #3106: URL: https://github.com/apache/calcite/pull/3106#issuecomment-1538162723 @snuyanzin Thanks for the work, and "This change will allow to remove SqlValidatorImpl from Flink code" sounds exciting, I'll give it a review in a few days. -- This is an automated

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3191: [CALCITE-5693] AssertionError with UNION using CTE

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3191: URL: https://github.com/apache/calcite/pull/3191#issuecomment-1538023288 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3191: [CALCITE-5693] AssertionError with UNION using CTE

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3191: URL: https://github.com/apache/calcite/pull/3191#issuecomment-1537969862 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3192: [CALCITE-5602] Implement CSC and SEC function

2023-05-08 Thread via GitHub
sonarcloud[bot] commented on PR #3192: URL: https://github.com/apache/calcite/pull/3192#issuecomment-1537956620 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zoudan opened a new pull request, #3192: [CALCITE-5602] Implement CSC and SEC function

2023-05-08 Thread via GitHub
zoudan opened a new pull request, #3192: URL: https://github.com/apache/calcite/pull/3192 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] kramerul opened a new pull request, #3191: [CALCITE-5693] AssertionError with UNION using CTE

2023-05-08 Thread via GitHub
kramerul opened a new pull request, #3191: URL: https://github.com/apache/calcite/pull/3191 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] liuyongvs commented on pull request #3161: [CALCITE-5657] Add ARRAY_DISTINCT function (enabled in Spark library).

2023-05-08 Thread via GitHub
liuyongvs commented on PR #3161: URL: https://github.com/apache/calcite/pull/3161#issuecomment-1537828435 hi @JiajunBernoulli Task :sonar [java.net.SocketTimeoutException: Connect timed out, java.net.SocketTimeoutException: Connect timed out] what should i do? and what is