sonarcloud[bot] commented on PR #3193:
URL: https://github.com/apache/calcite/pull/3193#issuecomment-1567778641
Kudos, SonarCloud Quality Gate passed! [ {
sonarcloud[bot] commented on PR #3231:
URL: https://github.com/apache/calcite/pull/3231#issuecomment-1567681388
Kudos, SonarCloud Quality Gate passed! [ {
liuyongvs commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1209647600
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -487,6 +487,18 @@ public static SqlCall stripSeparator(SqlCall call) {
-1);
};
liuyongvs commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1209646097
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5336,6 +5336,36 @@ private static void checkIf(SqlOperatorFixture f) {
MasseGuillaume commented on code in PR #3218:
URL: https://github.com/apache/calcite/pull/3218#discussion_r1209637115
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5397,6 +5397,20 @@ private static void checkIf(SqlOperatorFixture f) {
liuyongvs commented on PR #3218:
URL: https://github.com/apache/calcite/pull/3218#issuecomment-1567660894
hi @JiajunBernoulli do you have time to look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
liuyongvs commented on code in PR #3218:
URL: https://github.com/apache/calcite/pull/3218#discussion_r1209634422
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5397,6 +5397,20 @@ private static void checkIf(SqlOperatorFixture f) {
MasseGuillaume commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1209629756
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5336,6 +5336,36 @@ private static void checkIf(SqlOperatorFixture f) {
MasseGuillaume commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1209629756
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5336,6 +5336,36 @@ private static void checkIf(SqlOperatorFixture f) {
MasseGuillaume commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1209623357
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -487,6 +487,18 @@ public static SqlCall stripSeparator(SqlCall call) {
-1);
MasseGuillaume commented on code in PR #3218:
URL: https://github.com/apache/calcite/pull/3218#discussion_r1209622163
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5397,6 +5397,20 @@ private static void checkIf(SqlOperatorFixture f) {
MasseGuillaume opened a new pull request, #3231:
URL: https://github.com/apache/calcite/pull/3231
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
jhyde pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
from 379f41d3be [CALCITE-5717] RelBuilder.project of literals on a
single-row Aggregate should create a Values
new
sonarcloud[bot] commented on PR #3054:
URL: https://github.com/apache/calcite/pull/3054#issuecomment-1567445690
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
guestli closed pull request #3110: [CALCITE-5568] Add unit tests to the
DecorrelateQuery, where there is LogicalValues
URL: https://github.com/apache/calcite/pull/3110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
sonarcloud[bot] commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1567055866
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1567048510
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
gf2121 commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1567044220
> First of all, as a general comment, the commit message should describe the
problem, and not being with "Fix ...". I propose to use as commit message
(together with the ticket number)
sonarcloud[bot] commented on PR #3229:
URL: https://github.com/apache/calcite/pull/3229#issuecomment-1567042859
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
libenchao commented on code in PR #3193:
URL: https://github.com/apache/calcite/pull/3193#discussion_r1209219091
##
core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java:
##
@@ -866,6 +866,10 @@ private static void matchFilter(SubQueryRemoveRule rule,
rubenada commented on code in PR #3228:
URL: https://github.com/apache/calcite/pull/3228#discussion_r1209198034
##
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java:
##
@@ -2732,6 +2732,7 @@ public static Enumerable orderBy(
// search the key up
rubenada commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1566968451
Thanks for the PR @gf2121 .
First of all, as a general comment, the commit message should describe the
problem, and not being with "Fix ...". I propose to use as commit message
sonarcloud[bot] commented on PR #3228:
URL: https://github.com/apache/calcite/pull/3228#issuecomment-1566949882
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
DonnyZone commented on code in PR #3203:
URL: https://github.com/apache/calcite/pull/3203#discussion_r1209127755
##
linq4j/src/main/java/org/apache/calcite/linq4j/tree/OptimizeShuttle.java:
##
@@ -164,6 +169,9 @@ && eq(cmp.expression1, expression2)) {
Expression
sonarcloud[bot] commented on PR #3203:
URL: https://github.com/apache/calcite/pull/3203#issuecomment-1566773447
Kudos, SonarCloud Quality Gate passed! [ {
sonarcloud[bot] commented on PR #3203:
URL: https://github.com/apache/calcite/pull/3203#issuecomment-1566639257
Kudos, SonarCloud Quality Gate passed! [