[GitHub] [calcite] liuyongvs commented on a diff in pull request #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

2023-06-12 Thread via GitHub
liuyongvs commented on code in PR #3262: URL: https://github.com/apache/calcite/pull/3262#discussion_r1227567195 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1005,6 +1012,23 @@ private static RelDataType arrayReturnType(SqlOperatorBinding

[GitHub] [calcite] liuyongvs opened a new pull request, #3262: [CALCITE-5772] Add MAP_CONCAT, MAP_FROM_ENTRIES function (enabled in …

2023-06-12 Thread via GitHub
liuyongvs opened a new pull request, #3262: URL: https://github.com/apache/calcite/pull/3262 [map_concat](https://spark.apache.org/docs/latest/api/sql/index.html#map_concat) map_concat(map, ...) - Returns the union of all the given maps Examples: ``` > SELECT

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-12 Thread via GitHub
sonarcloud[bot] commented on PR #3237: URL: https://github.com/apache/calcite/pull/3237#issuecomment-1588423640 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zoudan commented on pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-12 Thread via GitHub
zoudan commented on PR #3237: URL: https://github.com/apache/calcite/pull/3237#issuecomment-1588407339 > @liuyongvs @JiajunBernoulli thanks for your comments in the PR, do you have further remarks? Shall we consider squash commits and merge? I have squashed the commits. -- This is

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3054: (do not check in)

2023-06-12 Thread via GitHub
sonarcloud[bot] commented on PR #3054: URL: https://github.com/apache/calcite/pull/3054#issuecomment-1588348485 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3054: (do not check in)

2023-06-12 Thread via GitHub
sonarcloud[bot] commented on PR #3054: URL: https://github.com/apache/calcite/pull/3054#issuecomment-1588285840 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-06-12 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1227350034 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6823,50 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] zstan commented on pull request #3211: [CALCITE-5708] Change SUBSTRING result if either of parameters is NULL

2023-06-12 Thread via GitHub
zstan commented on PR #3211: URL: https://github.com/apache/calcite/pull/3211#issuecomment-1587136406 @herunkang2018 kindly remind help with review if possible, thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] YasuoStudyJava commented on a diff in pull request #3247: [CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

2023-06-12 Thread via GitHub
YasuoStudyJava commented on code in PR #3247: URL: https://github.com/apache/calcite/pull/3247#discussion_r1226182776 ## core/src/main/java/org/apache/calcite/rex/RexSimplify.java: ## @@ -2660,6 +2695,24 @@ private Comparison(RexNode ref, SqlKind kind, RexLiteral literal) {

[GitHub] [calcite] liuyongvs commented on pull request #3238: [CALCITE-5744] Add MAP_FROM_ARRAYS, STR_TO_MAP function (enabled in Spark library)

2023-06-12 Thread via GitHub
liuyongvs commented on PR #3238: URL: https://github.com/apache/calcite/pull/3238#issuecomment-1587094804 hi @tanclary @MasseGuillaume do you have time to look again? thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] rubenada commented on pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-12 Thread via GitHub
rubenada commented on PR #3237: URL: https://github.com/apache/calcite/pull/3237#issuecomment-1586934659 @liuyongvs @liuyongvs thanks for your comments in the PR, do you have further remarks? Shall we consider squash commits and merge? -- This is an automated message from the Apache Git

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-12 Thread via GitHub
liuyongvs commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1226294799 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,34 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-12 Thread via GitHub
sonarcloud[bot] commented on PR #3237: URL: https://github.com/apache/calcite/pull/3237#issuecomment-1586837256 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zoudan commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-12 Thread via GitHub
zoudan commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1226236342 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,34 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] zoudan commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-12 Thread via GitHub
zoudan commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1226236342 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,34 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-12 Thread via GitHub
liuyongvs commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1226231780 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,34 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] rubenada commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

2023-06-12 Thread via GitHub
rubenada commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1226207689 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,34 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3261: [CALCITE-5729] Support string as the input type for 'OCTET_LENGTH' and add 'BYTE_LENGTH' as an alias for 'OCTET_LENGTH' (enabled in

2023-06-12 Thread via GitHub
sonarcloud[bot] commented on PR #3261: URL: https://github.com/apache/calcite/pull/3261#issuecomment-1586725333 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] YasuoStudyJava commented on a diff in pull request #3247: [CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

2023-06-12 Thread via GitHub
YasuoStudyJava commented on code in PR #3247: URL: https://github.com/apache/calcite/pull/3247#discussion_r1226182776 ## core/src/main/java/org/apache/calcite/rex/RexSimplify.java: ## @@ -2660,6 +2695,24 @@ private Comparison(RexNode ref, SqlKind kind, RexLiteral literal) {

[GitHub] [calcite] zoudan commented on a diff in pull request #3247: [CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

2023-06-12 Thread via GitHub
zoudan commented on code in PR #3247: URL: https://github.com/apache/calcite/pull/3247#discussion_r1226169010 ## core/src/main/java/org/apache/calcite/rex/RexSimplify.java: ## @@ -672,9 +675,28 @@ private void simplifyAndTerms(List terms, RexUnknownAs unknownAs) {

[GitHub] [calcite] zoudan opened a new pull request, #3261: [CALCITE-5729] Support string as the input type for 'OCTET_LENGTH' and add 'BYTE_LENGTH' as an alias for 'OCTET_LENGTH' (enabled in BigQuery

2023-06-12 Thread via GitHub
zoudan opened a new pull request, #3261: URL: https://github.com/apache/calcite/pull/3261 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,