YiwenWu commented on PR #3656:
URL: https://github.com/apache/calcite/pull/3656#issuecomment-1936821427
> fix the problem of lateral field not exists。
@JiajunBernoulli Happy New Year，
I think this PR only deals with the problem of fields not existing. the
optimization of lateral
mihaibudiu commented on code in PR #3680:
URL: https://github.com/apache/calcite/pull/3680#discussion_r1484933501
##
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##
@@ -57,8 +59,17 @@ public enum FormatElementEnum implements FormatElement {
},
mihaibudiu commented on code in PR #3680:
URL: https://github.com/apache/calcite/pull/3680#discussion_r1484933365
##
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##
@@ -281,9 +301,9 @@ static Work get() {
/** Uses Locale.US instead of
YiwenWu commented on code in PR #3680:
URL: https://github.com/apache/calcite/pull/3680#discussion_r1484932837
##
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##
@@ -57,8 +59,17 @@ public enum FormatElementEnum implements FormatElement {
},
JiajunBernoulli commented on PR #3676:
URL: https://github.com/apache/calcite/pull/3676#issuecomment-1936795096
FYI: https://calcite.apache.org/develop/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
JiajunBernoulli commented on PR #3670:
URL: https://github.com/apache/calcite/pull/3670#issuecomment-1936792880
> @JiajunBernoulli, do you have any other comments for this PR?
>
> I plan to merge it sometime this weekend if there are no concerns.
No, please squash them before
JiajunBernoulli commented on code in PR #3675:
URL: https://github.com/apache/calcite/pull/3675#discussion_r1484922292
##
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java:
##
@@ -1799,11 +1801,16 @@ private boolean innerHasNext() {
i = -1;
sonarcloud[bot] commented on PR #3680:
URL: https://github.com/apache/calcite/pull/3680#issuecomment-1936748761
## [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on PR #3635:
URL: https://github.com/apache/calcite/pull/3635#issuecomment-1936433284
## [
with
rubenada commented on PR #3640:
URL: https://github.com/apache/calcite/pull/3640#issuecomment-1935544748
Thanks for your patience and the thorough explanation @HanumathRao , I
really appreciate it.
I understand a bit more the situation now... and I beg to differ.
IMHO fix 2 is
22 matches
Mail list logo
