Re: [PR] [CALCITE-6265] Allow providing different numeric type as placeholder [calcite]

asolimando commented on code in PR #3687: URL: https://github.com/apache/calcite/pull/3687#discussion_r1508550643 ## linq4j/src/main/java/org/apache/calcite/linq4j/tree/CastExpression.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] chore: fix doc for strong predicates [calcite]

sonarcloud[bot] commented on PR #3709: URL: https://github.com/apache/calcite/pull/3709#issuecomment-1972609384 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-5976] Use explicit CAST if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

chucheng92 commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1972607712 @caicancai please use correct/proper commit name when you fix code-reivews to add a new commit. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

sonarcloud[bot] commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1972595364 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] chore: fix doc for strong predicates [calcite]

caicancai commented on PR #3709: URL: https://github.com/apache/calcite/pull/3709#issuecomment-1972565119 > > Calcite has certain standard requirements for commit message. You can modify your commit message to pass cli. If you think it is necessary, you can mention it to jira > >

Re: [PR] chore: fix doc for strong predicates [calcite]

chenzl25 commented on PR #3709: URL: https://github.com/apache/calcite/pull/3709#issuecomment-1972556073 > Calcite has certain standard requirements for commit message. You can modify your commit message to pass cli. If you think it is necessary, you can mention it to jira Thanks!

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

sonarcloud[bot] commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1972526319 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

sonarcloud[bot] commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1972525578 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] chore: fix doc for strong predicates [calcite]

caicancai commented on PR #3709: URL: https://github.com/apache/calcite/pull/3709#issuecomment-1972512280 Calcite has certain standard requirements for commit message. You can modify your commit message to pass cli. If you think it is necessary, you can mention it to jira -- This is an

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

caicancai commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1508483368 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1375,6 +1376,14 @@ private static void adjustTypeForMultisetConstructor( }

[PR] chore: fix doc for strong predicates [calcite]

chenzl25 opened a new pull request, #3709: URL: https://github.com/apache/calcite/pull/3709 According to the definition, `c1 = 1 OR c2 IS NULL` cannot be strong in `[c1]`, because `c2 IS NULL` could be true. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library [calcite]

sonarcloud[bot] commented on PR #3355: URL: https://github.com/apache/calcite/pull/3355#issuecomment-1972431446 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library [calcite]

chucheng92 commented on code in PR #3355: URL: https://github.com/apache/calcite/pull/3355#discussion_r1508430436 ## core/src/main/java/org/apache/calcite/sql/type/ArrayElementOperandTypeChecker.java: ## @@ -31,11 +32,41 @@ * Parameter type-checking strategy where types must

Re: [PR] [CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library [calcite]

chucheng92 commented on code in PR #3355: URL: https://github.com/apache/calcite/pull/3355#discussion_r1508436246 ## core/src/main/java/org/apache/calcite/sql/type/NullOperandTypeChecker.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library [calcite]

chucheng92 commented on code in PR #3355: URL: https://github.com/apache/calcite/pull/3355#discussion_r1508430436 ## core/src/main/java/org/apache/calcite/sql/type/ArrayElementOperandTypeChecker.java: ## @@ -31,11 +32,41 @@ * Parameter type-checking strategy where types must

Re: [PR] [CALCITE-4677] Fix different physical conventions conversion on new physical node producing [calcite]

chenzl25 closed pull request #2452: [CALCITE-4677] Fix different physical conventions conversion on new physical node producing URL: https://github.com/apache/calcite/pull/2452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

sonarcloud[bot] commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1972346304 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6248] Illegal dates are accepted by casts [calcite]

mihaibudiu commented on PR #3708: URL: https://github.com/apache/calcite/pull/3708#issuecomment-1972180981 It looks like this CI failure is to be expected, since it fails with Avatica main. That should pass once Avatica main contains the corresponding fix. -- This is an automated message

Re: [PR] [CALCITE-6248] Illegal dates are accepted by casts [calcite]

sonarcloud[bot] commented on PR #3708: URL: https://github.com/apache/calcite/pull/3708#issuecomment-1972170232 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6248] Illegal dates are accepted by casts [calcite]

mihaibudiu commented on PR #3708: URL: https://github.com/apache/calcite/pull/3708#issuecomment-1972147353 This is the PR which is being reverted in this one: https://github.com/apache/calcite/pull/3685 -- This is an automated message from the Apache Git Service. To respond to the

[PR] [CALCITE-6248] Illegal dates are accepted by casts [calcite]

mihaibudiu opened a new pull request, #3708: URL: https://github.com/apache/calcite/pull/3708 This is the second attempt to provide a partial fix for [CALCITE-6248]. The fix is partial, because the bug is in Avatica, but Avatica CI fails if this fix is not applied. I have already

Re: [PR] [CALCITE-6265] Allow providing different numeric type as placeholder [calcite]

mihaibudiu commented on code in PR #3687: URL: https://github.com/apache/calcite/pull/3687#discussion_r1508275806 ## linq4j/src/main/java/org/apache/calcite/linq4j/tree/CastExpression.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [CALCITE-5893] Wrong NULL operand behavior of ARRAY_CONTAINS/ARRAY_EXCEPT/ARRAY_INTERSECT In Spark Library [calcite]

mihaibudiu commented on code in PR #3355: URL: https://github.com/apache/calcite/pull/3355#discussion_r1508269391 ## core/src/main/java/org/apache/calcite/sql/type/ArrayElementOperandTypeChecker.java: ## @@ -31,11 +32,41 @@ * Parameter type-checking strategy where types must

Re: [PR] [CALCITE-6265] Allow providing different numeric type as placeholder [calcite]

asolimando commented on code in PR #3687: URL: https://github.com/apache/calcite/pull/3687#discussion_r1507338676 ## core/src/test/java/org/apache/calcite/test/JdbcTest.java: ## @@ -8332,10 +8331,30 @@ private void checkGetTimestamp(Connection con) throws SQLException { }

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

chucheng92 commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507403331 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1266,10 +1271,17 @@ private static RelDataType

Re: [PR] [CALCITE-6265] Allow providing different numeric type as placeholder [calcite]

sonarcloud[bot] commented on PR #3687: URL: https://github.com/apache/calcite/pull/3687#issuecomment-1970862893 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

chucheng92 commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507356528 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6297,6 +6297,54 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

chucheng92 commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507357141 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6538,6 +6586,54 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

chucheng92 commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507353662 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1375,6 +1376,14 @@ private static void adjustTypeForMultisetConstructor(

Re: [PR] [CALCITE-6265] Allow providing different numeric type as placeholder [calcite]

tindzk commented on code in PR #3687: URL: https://github.com/apache/calcite/pull/3687#discussion_r1507339039 ## linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java: ## @@ -622,9 +622,49 @@ public static UnaryExpression convert_(Expression expression, Type

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

sonarcloud[bot] commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1970786153 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6265] Allow providing different numeric type as placeholder [calcite]

tindzk commented on code in PR #3687: URL: https://github.com/apache/calcite/pull/3687#discussion_r1507331189 ## linq4j/src/main/java/org/apache/calcite/linq4j/tree/Expressions.java: ## @@ -2829,6 +2869,18 @@ public static ThrowStatement throw_(Expression expression) {

Re: [PR] [CALCITE-6265] Allow providing different numeric type as placeholder [calcite]

tindzk commented on code in PR #3687: URL: https://github.com/apache/calcite/pull/3687#discussion_r1507319896 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java: ## @@ -1374,11 +1375,24 @@ private Result toInnerStorageType(Result result, Type

Re: [PR] [CALCITE-6280] The Jetty's version number leak occurred while using he avatica http server [calcite-avatica]

stoty closed pull request #239: [CALCITE-6280] The Jetty's version number leak occurred while using he avatica http server URL: https://github.com/apache/calcite-avatica/pull/239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

sonarcloud[bot] commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1970761814 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

caicancai commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507248799 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6538,6 +6586,54 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

caicancai commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507043922 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1381,6 +1424,58 @@ private static void adjustTypeForMultisetConstructor( }

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

caicancai commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1506166899 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1326,6 +1327,34 @@ public static void adjustTypeForArrayConstructor( } }

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

caicancai commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507247094 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1187,6 +1187,9 @@ private static RelDataType

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

caicancai commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507223643 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1326,6 +1327,48 @@ public static void adjustTypeForArrayConstructor( } }

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

chucheng92 commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507112865 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1326,6 +1327,48 @@ public static void adjustTypeForArrayConstructor( } }

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

chucheng92 commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507112865 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1326,6 +1327,48 @@ public static void adjustTypeForArrayConstructor( } }

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

chucheng92 commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507208559 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6538,6 +6586,54 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-5976] Use explicit casting if inserted element type in ArrayPrepend/ArrayAppend/ArrayInsert does not equal derived component type [calcite]

chucheng92 commented on code in PR #3705: URL: https://github.com/apache/calcite/pull/3705#discussion_r1507208559 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6538,6 +6586,54 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias