Re: [PR] [CALCITE-6395] Significant precision loss when representing REAL literals [calcite]

2024-05-01 Thread via GitHub
sonarcloud[bot] commented on PR #3782: URL: https://github.com/apache/calcite/pull/3782#issuecomment-2089300020 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-01 Thread via GitHub
sonarcloud[bot] commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2088799632 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-01 Thread via GitHub
mihaibudiu commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2088787954 This looks very good, when they unfreeze the main branch we can merge this. Regarding the script, it's good for this particular use case, but I am not sure whether it will

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-01 Thread via GitHub
normanj-bitquill commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2088777985 @mihaibudiu > This is pretty close, the existing file `core/src/test/resources/sql/sub-query.iq` already uses the postgres format. What I would do is to make a small python

Re: [PR] [CALCITE-6302] Release Calcite 1.37.0 [calcite]

2024-05-01 Thread via GitHub
rubenada commented on code in PR #3768: URL: https://github.com/apache/calcite/pull/3768#discussion_r1586008768 ## site/_docs/history.md: ## @@ -29,25 +29,114 @@ Downloads are available on the [downloads page]({{ site.baseurl }}/downloads/). + +##