Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-12 Thread via GitHub
arkanovicz commented on code in PR #3773: URL: https://github.com/apache/calcite/pull/3773#discussion_r1597705152 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1651,13 +1652,22 @@ private static RelDataType

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Spark library) [calcite]

2024-05-12 Thread via GitHub
caicancai commented on code in PR #3785: URL: https://github.com/apache/calcite/pull/3785#discussion_r1597624347 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -10036,6 +10036,34 @@ void assertSubFunReturns(boolean binary, String s, int start,

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Spark library) [calcite]

2024-05-12 Thread via GitHub
sonarcloud[bot] commented on PR #3785: URL: https://github.com/apache/calcite/pull/3785#issuecomment-2106181478 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Spark library) [calcite]

2024-05-12 Thread via GitHub
caicancai commented on code in PR #3785: URL: https://github.com/apache/calcite/pull/3785#discussion_r1597579339 ## site/_docs/reference.md: ## @@ -2812,6 +2812,7 @@ In the following: | b m p s | MD5(string) | Calculates an MD5 128-bit checksum of

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Spark library) [calcite]

2024-05-12 Thread via GitHub
caicancai commented on code in PR #3785: URL: https://github.com/apache/calcite/pull/3785#discussion_r1597579306 ## core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java: ## @@ -418,6 +419,32 @@ private static RexNode convertNvl(SqlRexContext cx, SqlCall

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Spark library) [calcite]

2024-05-12 Thread via GitHub
caicancai commented on code in PR #3785: URL: https://github.com/apache/calcite/pull/3785#discussion_r1597579143 ## core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java: ## @@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) { opBinding ->

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Spark library) [calcite]

2024-05-12 Thread via GitHub
caicancai commented on code in PR #3785: URL: https://github.com/apache/calcite/pull/3785#discussion_r1597579090 ## core/src/main/java/org/apache/calcite/sql/SqlKind.java: ## @@ -421,9 +421,12 @@ public enum SqlKind { /** {@code DECODE} function (Oracle). */ DECODE, -