[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-08-24 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r475829864 ## File path: core/src/test/java/org/apache/calcite/rel/RelCollationTest.java ## @@ -84,18 +84,36 @@ is(true)); } - /** Unit test for

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-08-24 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r475767057 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-08-24 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r475767057 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-08-24 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r475767057 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-08-24 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r475759626 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-08-20 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r473316727 ## File path: core/src/main/java/org/apache/calcite/rel/RelCollations.java ## @@ -199,25 +199,45 @@ public static boolean contains(List collations,

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-08-19 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r473338842 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -134,31 +138,82 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-08-19 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r473316727 ## File path: core/src/main/java/org/apache/calcite/rel/RelCollations.java ## @@ -199,25 +199,45 @@ public static boolean contains(List collations,

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-08-19 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r473193678 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -134,31 +138,82 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-08-19 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r473192513 ## File path: core/src/test/resources/org/apache/calcite/test/TopDownOptTest.xml ## @@ -491,6 +491,81 @@ EnumerableMergeJoin(condition=[AND(=($1, $9),

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-14 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439928527 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -134,31 +137,83 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-14 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439928463 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439791727 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439791727 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439791959 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -134,31 +137,83 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439791866 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -134,31 +137,83 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439791727 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439791684 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -134,31 +137,83 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439791483 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -134,31 +137,83 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439784770 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -134,31 +137,83 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439784121 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439784121 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439784121 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439784248 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439784121 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439784146 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439784121 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439783577 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -134,31 +137,83 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-10 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r438537972 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -101,28 +103,55 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-10 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r438534299 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -101,28 +103,55 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-10 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r437890122 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -101,28 +103,55 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-10 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r437889032 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -101,28 +103,55 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-10 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r437886885 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -131,8 +160,35 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-09 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r437126855 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -101,28 +103,55 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

2020-06-07 Thread GitBox
amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r436386235 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -194,6 +250,81 @@ public static boolean