[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1292941176 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5845,6 +5845,84 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1292941176 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5845,6 +5845,84 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1292941176 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5845,6 +5845,84 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1292941489 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5845,6 +5845,84 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1292941176 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5845,6 +5845,84 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291653062 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291653062 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291653062 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291604326 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291604759 ## site/_docs/reference.md: ## @@ -2658,6 +2658,7 @@ BigQuery's type system uses confusingly different names for types and functions: | s | ARRAY_CONTAINS(array,

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1291604326 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,93 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1285699097 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1285651475 ## site/_docs/reference.md: ## @@ -2658,6 +2658,7 @@ BigQuery's type system uses confusingly different names for types and functions: | s | ARRAY_CONTAINS(array,

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283285678 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283227158 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283285678 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283285678 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283285678 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283227158 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283236667 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283201032 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283227158 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283227158 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283201032 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283190892 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283185632 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on code in PR #3320: URL: https://github.com/apache/calcite/pull/3320#discussion_r1283139677 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4107,6 +4113,97 @@ public static List arrayExcept(List list1, List list2) { return