[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-09-01 Thread via GitHub
herunkang2018 commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1313685502 ## site/_docs/reference.md: ## @@ -2685,6 +2685,7 @@ BigQuery's type system uses confusingly different names for types and functions: | b | CEIL(value)

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-09-01 Thread via GitHub
herunkang2018 commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1313685502 ## site/_docs/reference.md: ## @@ -2685,6 +2685,7 @@ BigQuery's type system uses confusingly different names for types and functions: | b | CEIL(value)

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-08-26 Thread via GitHub
herunkang2018 commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1306586106 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -929,6 +929,29 @@ public static String charFromUtf8(int n) { return

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-08-25 Thread via GitHub
herunkang2018 commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1305571505 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -929,6 +929,29 @@ public static String charFromUtf8(int n) { return