[GitHub] [calcite] mihaibudiu commented on a diff in pull request #3430: [CALCITE-6008] ARRAY_AGG should returns ARRAY NULL when there's no input rows

2023-09-21 Thread via GitHub
mihaibudiu commented on code in PR #3430: URL: https://github.com/apache/calcite/pull/3430#discussion_r183870 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -9314,11 +9314,12 @@ private static void checkGroupConcatFuncFails(SqlOperatorFixture

[GitHub] [calcite] mihaibudiu commented on a diff in pull request #3430: [CALCITE-6008] ARRAY_AGG should returns ARRAY NULL when there's no input rows

2023-09-21 Thread via GitHub
mihaibudiu commented on code in PR #3430: URL: https://github.com/apache/calcite/pull/3430#discussion_r181033 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -9314,11 +9314,12 @@ private static void checkGroupConcatFuncFails(SqlOperatorFixture

[GitHub] [calcite] mihaibudiu commented on a diff in pull request #3430: [CALCITE-6008] ARRAY_AGG should returns ARRAY NULL when there's no input rows

2023-09-16 Thread via GitHub
mihaibudiu commented on code in PR #3430: URL: https://github.com/apache/calcite/pull/3430#discussion_r1327999598 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -9314,11 +9314,12 @@ private static void checkGroupConcatFuncFails(SqlOperatorFixture

[GitHub] [calcite] mihaibudiu commented on a diff in pull request #3430: [CALCITE-6008] ARRAY_AGG should returns ARRAY NULL when there's no input rows

2023-09-16 Thread via GitHub
mihaibudiu commented on code in PR #3430: URL: https://github.com/apache/calcite/pull/3430#discussion_r1327987695 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -9314,11 +9314,12 @@ private static void checkGroupConcatFuncFails(SqlOperatorFixture