[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1308036102 ## core/src/test/java/org/apache/calcite/test/SqlFunctionsTest.java: ## @@ -260,7 +261,75 @@ static List list() { } catch (RuntimeException e) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1310568623 ## core/src/test/java/org/apache/calcite/test/SqlFunctionsTest.java: ## @@ -254,18 +254,88 @@ static List list() { final boolean b = f.regexpContains("abc def

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1308035240 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -554,6 +555,7 @@ Builder populate() { defineMethod(SPLIT, "split",

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1310567170 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -569,6 +570,8 @@ Builder populate() { defineReflective(PARSE_URL,

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1305965977 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4568,6 +4568,25 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300713409 ## site/_docs/reference.md: ## @@ -2783,7 +2783,9 @@ BigQuery's type system uses confusingly different names for types and functions: | h s | PARSE_URL(urlString,

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300703569 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4568,6 +4568,25 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300609143 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4568,6 +4568,25 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300608689 ## site/_docs/reference.md: ## @@ -2783,7 +2783,9 @@ BigQuery's type system uses confusingly different names for types and functions: | h s | PARSE_URL(urlString,

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300608395 ## site/_docs/reference.md: ## @@ -2783,7 +2783,9 @@ BigQuery's type system uses confusingly different names for types and functions: | h s | PARSE_URL(urlString,

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300602342 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -355,19 +355,88 @@ public static String sha512(ByteString string) { } /** SQL

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300601095 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -355,19 +355,88 @@ public static String sha512(ByteString string) { } /** SQL

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1297810530 ## babel/src/test/resources/sql/big-query.iq: ## @@ -3657,4 +3915,5 @@ FROM items; !ok + Review Comment: Those are valid, it should remove blank space at the

[GitHub] [calcite] tanclary commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

tanclary commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1297757955 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -355,11 +355,85 @@ public static boolean regexpContains(String value, String regex) {