asolimando commented on PR #3757:
URL: https://github.com/apache/calcite/pull/3757#issuecomment-2115825722
> > Few more minor changes and for me we are good to go.
> > Please don't force-push until the review process is on-going as it makes
incremental reviewing more difficult.
>
sonarcloud[bot] commented on PR #3757:
URL: https://github.com/apache/calcite/pull/3757#issuecomment-2113237120
## [ {
jduo commented on PR #3757:
URL: https://github.com/apache/calcite/pull/3757#issuecomment-2113060675
> Few more minor changes and for me we are good to go.
>
> Please don't force-push until the review process is on-going as it makes
incremental reviewing more difficult.
In
asolimando commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1601900134
##
core/src/test/java/org/apache/calcite/test/RelBuilderTest.java:
##
@@ -1450,6 +1452,225 @@ private RexNode caseCall(RelBuilder b, RexNode ref,
RexNode... nodes)
sonarcloud[bot] commented on PR #3757:
URL: https://github.com/apache/calcite/pull/3757#issuecomment-2103446823
## [,
can you take a look?
>
> I
jduo commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1583563688
##
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##
@@ -2502,9 +2502,10 @@ private RelBuilder
pruneAggregateInputFieldsAndDeduplicateAggCalls(
jduo commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1583542999
##
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##
@@ -2502,9 +2502,10 @@ private RelBuilder
pruneAggregateInputFieldsAndDeduplicateAggCalls(
jduo commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1583519841
##
core/src/main/java/org/apache/calcite/plan/RelCompositeTrait.java:
##
@@ -116,4 +116,5 @@ public T trait(int i) {
public int size() {
return traits.length;
asolimando commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1581903678
##
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##
@@ -2502,9 +2502,10 @@ private RelBuilder
pruneAggregateInputFieldsAndDeduplicateAggCalls(
asolimando commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1581902891
##
core/src/main/java/org/apache/calcite/plan/RelCompositeTrait.java:
##
@@ -116,4 +116,5 @@ public T trait(int i) {
public int size() {
return
sonarcloud[bot] commented on PR #3757:
URL: https://github.com/apache/calcite/pull/3757#issuecomment-2078225502
## [