caicancai commented on code in PR #3631:
URL: https://github.com/apache/calcite/pull/3631#discussion_r1486012354
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8747,6 +8747,55 @@ private void testCurrentDateFunc(Pair pair) {
}
}
+ /**
sonarcloud[bot] commented on PR #3631:
URL: https://github.com/apache/calcite/pull/3631#issuecomment-1899554121
## [. */
TIME_SUB,
tanclary commented on code in PR #3631:
URL: https://github.com/apache/calcite/pull/3631#discussion_r1457868807
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -4461,6 +4461,51 @@ public static int time(long timestampMillis, String
timeZone) {
tanclary commented on code in PR #3631:
URL: https://github.com/apache/calcite/pull/3631#discussion_r1457830260
##
site/_docs/reference.md:
##
@@ -2746,7 +2746,7 @@ In the following:
| h s | FORMAT_NUMBER(value, decimalVal) | Formats the number
*value* like
tanclary commented on code in PR #3631:
URL: https://github.com/apache/calcite/pull/3631#discussion_r1457828057
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -2480,6 +2484,32 @@ private static class RegexpReplaceImplementor extends
tanclary commented on code in PR #3631:
URL: https://github.com/apache/calcite/pull/3631#discussion_r1457825819
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -4461,6 +4461,51 @@ public static int time(long timestampMillis, String
timeZone) {
tanclary commented on code in PR #3631:
URL: https://github.com/apache/calcite/pull/3631#discussion_r1457824410
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -4461,6 +4461,51 @@ public static int time(long timestampMillis, String
timeZone) {
julianhyde commented on code in PR #3631:
URL: https://github.com/apache/calcite/pull/3631#discussion_r1456238725
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1610,6 +1610,36 @@ private static RelDataType
mihaibudiu commented on PR #3631:
URL: https://github.com/apache/calcite/pull/3631#issuecomment-1896331624
Seems that the "Error Prone" check is unhappy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
JiajunBernoulli commented on PR #3631:
URL: https://github.com/apache/calcite/pull/3631#issuecomment-1894805047
Does CI stability failed?
https://github.com/apache/calcite/actions/runs/7549299627/attempts/1?pr=3631
--
This is an automated message from the Apache Git Service.
To respond
13 matches
Mail list logo
