tanclary merged PR #3761:
URL: https://github.com/apache/calcite/pull/3761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mihaibudiu commented on PR #3761:
URL: https://github.com/apache/calcite/pull/3761#issuecomment-2064785139
This PR seems to implement a few flags which don't even work in BigQuery,
but other than that seems fine.
--
This is an automated message from the Apache Git Service.
To respond to
Anthrino commented on PR #3761:
URL: https://github.com/apache/calcite/pull/3761#issuecomment-2064728779
@mihaibudiu @tanclary addressed your comments, would appreciate another
review on this, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1571090898
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -32,8 +32,15 @@ EXPR$0
2017-05-01 01:23:45
!ok
+# Input that contains shuffled date without time
+select
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1571090026
##
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##
@@ -306,12 +446,22 @@ static Work get() {
*
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1571079145
##
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##
@@ -217,6 +291,34 @@ public enum FormatElementEnum implements FormatElement {
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1571074953
##
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##
@@ -217,6 +291,34 @@ public enum FormatElementEnum implements FormatElement {
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1571070432
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -979,7 +939,7 @@ EXPR$0
select cast(date'2019-01-07' as varchar
FORMAT 'WW');
EXPR$0
-01
+02
Review
tanclary commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1567660915
##
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##
@@ -217,6 +291,34 @@ public enum FormatElementEnum implements FormatElement {
mihaibudiu commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1566470361
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -979,7 +939,7 @@ EXPR$0
select cast(date'2019-01-07' as varchar
FORMAT 'WW');
EXPR$0
-01
+02
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1566469451
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -979,7 +939,7 @@ EXPR$0
select cast(date'2019-01-07' as varchar
FORMAT 'WW');
EXPR$0
-01
+02
Review
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1566466811
##
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##
@@ -253,12 +373,27 @@ public enum FormatElementEnum implements FormatElement {
mihaibudiu commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1566455854
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -32,8 +32,15 @@ EXPR$0
2017-05-01 01:23:45
!ok
+# Input that contains shuffled date without time
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1566452703
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -32,8 +32,15 @@ EXPR$0
2017-05-01 01:23:45
!ok
+# Input that contains shuffled date without time
+select
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1566447732
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -361,7 +351,7 @@ EXPR$0
select cast('2017-05-31' as
timestamp FORMAT '-MM-DD');
EXPR$0
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1566422922
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -1155,7 +1108,7 @@ EXPR$0
!ok
!if (false) {
-### disabled until Bug.CALCITE_6269_FIXED ###
+###
mihaibudiu commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1566225540
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -1155,7 +1108,7 @@ EXPR$0
!ok
!if (false) {
-### disabled until Bug.CALCITE_6269_FIXED ###
+###
17 matches
Mail list logo
