[GitHub] [calcite] hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance

hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#issuecomment-593073365 Here is one example: 

[GitHub] [calcite] hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance

hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#issuecomment-593072264 All the plan diffs in this patch are either with same or less cost. This is

[GitHub] [calcite] hsyuan commented on issue #1839: [CALCITE-3836] The hash codes of RelNodes are unreliable

hsyuan commented on issue #1839: [CALCITE-3836] The hash codes of RelNodes are unreliable URL: https://github.com/apache/calcite/pull/1839#issuecomment-593175950 If the rel node has the same id, that means it is the same object, since each rel has distinct id. So the default hashcode()

[GitHub] [calcite] liyafan82 commented on issue #1839: [CALCITE-3836] The hash codes of RelNodes are unreliable

liyafan82 commented on issue #1839: [CALCITE-3836] The hash codes of RelNodes are unreliable URL: https://github.com/apache/calcite/pull/1839#issuecomment-593187160 > If the rel node has the same id, that means it is the same object, since each rel has distinct id. So the default

[GitHub] [calcite] danny0405 commented on issue #1840: [CALCITE-3753] Remove rule queue importance

danny0405 commented on issue #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#issuecomment-593199798 > Here is one example: > 

[GitHub] [calcite] liyafan82 commented on issue #1839: [CALCITE-3836] The hash codes of RelNodes are unreliable

liyafan82 commented on issue #1839: [CALCITE-3836] The hash codes of RelNodes are unreliable URL: https://github.com/apache/calcite/pull/1839#issuecomment-593186192 > TL;DR: it looks like currently there's no justification for the change :-/ > > I'm sorry to disappoint you, but >

[GitHub] [calcite] chunweilei commented on a change in pull request #1840: [CALCITE-3753] Remove rule queue importance

chunweilei commented on a change in pull request #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#discussion_r386182933 ## File path: core/src/test/resources/sql/misc.iq ## @@ -473,7 +473,7 @@

[GitHub] [calcite] hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance

hsyuan commented on issue #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#issuecomment-593202058 > Plan diffs are more than what i expected, BTW, what is the diff tool, it looks pretty good ~ It is diffchecker.

[GitHub] [calcite] hsyuan commented on a change in pull request #1840: [CALCITE-3753] Remove rule queue importance

hsyuan commented on a change in pull request #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#discussion_r386183382 ## File path: core/src/test/resources/sql/misc.iq ## @@ -473,7 +473,7 @@

[GitHub] [calcite] hsyuan commented on a change in pull request #1840: [CALCITE-3753] Remove rule queue importance

hsyuan commented on a change in pull request #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#discussion_r386187345 ## File path: core/src/test/resources/sql/misc.iq ## @@ -473,7 +473,7 @@

[GitHub] [calcite] liyafan82 edited a comment on issue #1839: [CALCITE-3836] The hash codes of RelNodes are unreliable

liyafan82 edited a comment on issue #1839: [CALCITE-3836] The hash codes of RelNodes are unreliable URL: https://github.com/apache/calcite/pull/1839#issuecomment-593186192 > TL;DR: it looks like currently there's no justification for the change :-/ > > I'm sorry to disappoint you,

[GitHub] [calcite] chunweilei commented on a change in pull request #1840: [CALCITE-3753] Remove rule queue importance

chunweilei commented on a change in pull request #1840: [CALCITE-3753] Remove rule queue importance URL: https://github.com/apache/calcite/pull/1840#discussion_r386185952 ## File path: core/src/test/resources/sql/misc.iq ## @@ -473,7 +473,7 @@

[GitHub] [calcite] danny0405 opened a new pull request #1841: Following CALCITE-3769: Add BindableTableScanRule into the default ru…

danny0405 opened a new pull request #1841: Following CALCITE-3769: Add BindableTableScanRule into the default ru… URL: https://github.com/apache/calcite/pull/1841 …leset * Add BindableTableScanRule into the default ruleset, so there are 2 table implementations, the planner would

[GitHub] [calcite] vlsi commented on a change in pull request #1841: Following CALCITE-3769: Add BindableTableScanRule into the default ru…

vlsi commented on a change in pull request #1841: Following CALCITE-3769: Add BindableTableScanRule into the default ru… URL: https://github.com/apache/calcite/pull/1841#discussion_r386226010 ## File path: core/src/test/java/org/apache/calcite/test/StreamTest.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1841: Following CALCITE-3769: Add BindableTableScanRule into the default ru…

danny0405 commented on a change in pull request #1841: Following CALCITE-3769: Add BindableTableScanRule into the default ru… URL: https://github.com/apache/calcite/pull/1841#discussion_r386229661 ## File path: core/src/test/java/org/apache/calcite/test/StreamTest.java ##