[GitHub] [calcite] hsyuan commented on pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

hsyuan commented on pull request #2006: URL: https://github.com/apache/calcite/pull/2006#issuecomment-643773213 So, To answer your question, yes. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] hsyuan commented on a change in pull request #2026: [CALCITE-4027] Add -Doverwrite option to DiffRepository

hsyuan commented on a change in pull request #2026: URL: https://github.com/apache/calcite/pull/2026#discussion_r439835612 ## File path: core/src/test/java/org/apache/calcite/test/DiffRepository.java ## @@ -762,6 +764,20 @@ public static DiffRepository lookup(Class clazz,

[GitHub] [calcite] chunweilei commented on a change in pull request #1987: [CALCITE-4020] Support Calc operator in RelFieldTrimmer

chunweilei commented on a change in pull request #1987: URL: https://github.com/apache/calcite/pull/1987#discussion_r439907127 ## File path: core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java ## @@ -350,6 +354,92 @@ public TrimResult trimFields(

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439928463 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -222,6 +277,30 @@ public static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

amaliujia commented on a change in pull request #2006: URL: https://github.com/apache/calcite/pull/2006#discussion_r439928527 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableMergeJoin.java ## @@ -134,31 +137,83 @@ public static boolean

[GitHub] [calcite] amaliujia commented on pull request #2025: [CALCITE-4033] Does not produce parenthesized table expressions for U…

amaliujia commented on pull request #2025: URL: https://github.com/apache/calcite/pull/2025#issuecomment-643904684 @boo I am using similar idea now in this PR (not hardcode UNNEST check anymore). This is an automated

[GitHub] [calcite] chunweilei commented on a change in pull request #1987: [CALCITE-4020] Support Calc operator in RelFieldTrimmer

chunweilei commented on a change in pull request #1987: URL: https://github.com/apache/calcite/pull/1987#discussion_r439908697 ## File path: core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java ## @@ -350,6 +354,92 @@ public TrimResult trimFields(

[GitHub] [calcite] amaliujia commented on pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

amaliujia commented on pull request #2006: URL: https://github.com/apache/calcite/pull/2006#issuecomment-643900365 Updated this PR (but assume that CALCITE-4010 will be addressed) This is an automated message from the

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439909893 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] amaliujia commented on a change in pull request #2025: [CALCITE-4033] Does not produce parenthesized table expressions for U…

amaliujia commented on a change in pull request #2025: URL: https://github.com/apache/calcite/pull/2025#discussion_r439931545 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCall.java ## @@ -97,7 +97,13 @@ public void unparse( if (leftPrec >

[GitHub] [calcite] danny0405 commented on a change in pull request #2025: [CALCITE-4033] Does not produce parenthesized table expressions for U…

danny0405 commented on a change in pull request #2025: URL: https://github.com/apache/calcite/pull/2025#discussion_r439913573 ## File path: core/src/main/java/org/apache/calcite/sql/SqlCall.java ## @@ -97,7 +97,13 @@ public void unparse( if (leftPrec >

[GitHub] [calcite] Aaaaaaron commented on pull request #2020: [CALCITE-4060] TypeCoercionImpl#inOperationCoercion consider "NOT_IN".

Aaron commented on pull request #2020: URL: https://github.com/apache/calcite/pull/2020#issuecomment-643903627 > Thanks for the contribution, can we change the title to "Supports implicit type coercion for NOT IN" which is more readable. Thanks for your advice!

[GitHub] [calcite] vlsi commented on pull request #2026: [CALCITE-4027] Add -Doverwrite option to DiffRepository

vlsi commented on pull request #2026: URL: https://github.com/apache/calcite/pull/2026#issuecomment-643723354 `overwrite` is a too broad option name. Please ensure the option works from the command line, and it is documented as well.

[GitHub] [calcite] XuQianJin-Stars commented on a change in pull request #1955: [CALCITE-3941] Add the default strict mode to the path in the Json functions

XuQianJin-Stars commented on a change in pull request #1955: URL: https://github.com/apache/calcite/pull/1955#discussion_r439800394 ## File path: core/src/main/java/org/apache/calcite/runtime/JsonFunctions.java ## @@ -112,18 +113,22 @@ public static JsonPathContext

[GitHub] [calcite] rkondakov commented on a change in pull request #2024: [CALCITE-3923] Refactor how planner rules are parameterized

rkondakov commented on a change in pull request #2024: URL: https://github.com/apache/calcite/pull/2024#discussion_r439816424 ## File path: core/src/main/java/org/apache/calcite/plan/RelOptRules.java ## @@ -179,11 +179,9 @@ private RelOptRules() {

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439897847 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] amaliujia commented on pull request #2006: [CALCITE-4015] Pass through parent collation request on subset or sup…

amaliujia commented on pull request #2006: URL: https://github.com/apache/calcite/pull/2006#issuecomment-643822485 O nice. Didn't realize there is already a JIRA to refine the code generation implementation of MergeJoin. Ok then in this PR I will make the assumption that physical

[GitHub] [calcite] bozzzzo commented on pull request #2025: [CALCITE-4033] Does not produce parenthesized table expressions for U…

boo commented on pull request #2025: URL: https://github.com/apache/calcite/pull/2025#issuecomment-643825132 Thank you for having a look at this! [Here](https://github.com/boo/calcite/commit/cd966361f23c41d5f987a2b7ab85b60a1731df10) is a patch for the `unparse` tests that

[GitHub] [calcite] danny0405 commented on a change in pull request #2016: [CALCITE-3786] Add Digest interface to enable efficient hashCode(equa…

danny0405 commented on a change in pull request #2016: URL: https://github.com/apache/calcite/pull/2016#discussion_r439897636 ## File path: core/src/main/java/org/apache/calcite/plan/Digest.java ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF)