[GitHub] [calcite] sonarcloud[bot] commented on pull request #3404: [CALCITE-5968] Provide an interface for RexExecutable to decouple janino runtime binding

2023-09-01 Thread via GitHub
sonarcloud[bot] commented on PR #3404: URL: https://github.com/apache/calcite/pull/3404#issuecomment-1702386795 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3404: [CALCITE-5968] Provide an interface for RexExecutable to decouple janino runtime binding

2023-09-01 Thread via GitHub
sonarcloud[bot] commented on PR #3404: URL: https://github.com/apache/calcite/pull/3404#issuecomment-1702365799 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

2023-09-01 Thread via GitHub
sonarcloud[bot] commented on PR #3393: URL: https://github.com/apache/calcite/pull/3393#issuecomment-1702574064 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-09-01 Thread via GitHub
asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1312811782 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3395: [CALCITE-5948] Explicit casting should be made if the type of an element in ARRAY/MAP not equals with the derived component typ

2023-09-01 Thread via GitHub
chucheng92 commented on code in PR #3395: URL: https://github.com/apache/calcite/pull/3395#discussion_r1313055052 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1309,6 +1311,64 @@ public static boolean isMeasure(SqlNode selectItem) {

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3395: [CALCITE-5948] Explicit casting should be made if the type of an element in ARRAY/MAP not equals with the derived component typ

2023-09-01 Thread via GitHub
chucheng92 commented on code in PR #3395: URL: https://github.com/apache/calcite/pull/3395#discussion_r1313055744 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1309,6 +1311,64 @@ public static boolean isMeasure(SqlNode selectItem) {

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3395: [CALCITE-5948] Explicit casting should be made if the type of an element in ARRAY/MAP not equals with the derived component typ

2023-09-01 Thread via GitHub
chucheng92 commented on code in PR #3395: URL: https://github.com/apache/calcite/pull/3395#discussion_r1313055744 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1309,6 +1311,64 @@ public static boolean isMeasure(SqlNode selectItem) {

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3395: [CALCITE-5948] Explicit casting should be made if the type of an element in ARRAY/MAP not equals with the derived component typ

2023-09-01 Thread via GitHub
chucheng92 commented on code in PR #3395: URL: https://github.com/apache/calcite/pull/3395#discussion_r1313055744 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1309,6 +1311,64 @@ public static boolean isMeasure(SqlNode selectItem) {

[GitHub] [calcite] LakeShen commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-09-01 Thread via GitHub
LakeShen commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1313182251 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -2699,6 +2699,33 @@ private void

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3395: [CALCITE-5948] Explicit casting should be made if the type of an element in ARRAY/MAP not equals with the derived component type

2023-09-01 Thread via GitHub
sonarcloud[bot] commented on PR #3395: URL: https://github.com/apache/calcite/pull/3395#issuecomment-1702808542 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] LakeShen commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-09-01 Thread via GitHub
LakeShen commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1313169040 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando merged pull request #3328: [CALCITE-5861] Optimization rules do not constant-fold expressions in window bounds

2023-09-01 Thread via GitHub
asolimando merged PR #3328: URL: https://github.com/apache/calcite/pull/3328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch main updated: [CALCITE-5861] ReduceExpressionsRule rules should constant-fold expressions in window bounds

2023-09-01 Thread asolimando
This is an automated email from the ASF dual-hosted git repository. asolimando pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new cbf857e319 [CALCITE-5861]

[GitHub] [calcite] mihaibudiu commented on pull request #3359: [CALCITE-5905] Documentation for CREATE TYPE is incorrect

2023-09-01 Thread via GitHub
mihaibudiu commented on PR #3359: URL: https://github.com/apache/calcite/pull/3359#issuecomment-1703110043 I would appreciate if someone could review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] mihaibudiu commented on pull request #3328: [CALCITE-5861] Optimization rules do not constant-fold expressions in window bounds

2023-09-01 Thread via GitHub
mihaibudiu commented on PR #3328: URL: https://github.com/apache/calcite/pull/3328#issuecomment-1703106646 Maybe someone can merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] mihaibudiu commented on pull request #3346: [CALCITE-5884] Type Inference rule for ARRAY_TO_STRING is incorrect

2023-09-01 Thread via GitHub
mihaibudiu commented on PR #3346: URL: https://github.com/apache/calcite/pull/3346#issuecomment-1703109525 I would appreciate if someone could review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] zoov-w opened a new pull request, #3406: fix bug when es index mapping set dynamic_templates without properties

2023-09-01 Thread via GitHub
zoov-w opened a new pull request, #3406: URL: https://github.com/apache/calcite/pull/3406 when use es-adapter, A index set dynamic_templates bug no mappings causing exceptions: java.lang.ClassCastException: com.fasterxml.jackson.databind.node.ArrayNode cannot be cast to

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

2023-09-01 Thread via GitHub
sonarcloud[bot] commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1703700059 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite-avatica] herunkang2018 commented on a diff in pull request #225: [CALCITE-5957] Date representation string without precede 0 is acceptable

2023-09-01 Thread via GitHub
herunkang2018 commented on code in PR #225: URL: https://github.com/apache/calcite-avatica/pull/225#discussion_r1313684206 ## core/src/test/java/org/apache/calcite/avatica/util/TimestampFromNumberAccessorTest.java: ## @@ -101,6 +101,9 @@ public class

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-09-01 Thread via GitHub
herunkang2018 commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1313685502 ## site/_docs/reference.md: ## @@ -2685,6 +2685,7 @@ BigQuery's type system uses confusingly different names for types and functions: | b | CEIL(value)

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

2023-09-01 Thread via GitHub
herunkang2018 commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1313685502 ## site/_docs/reference.md: ## @@ -2685,6 +2685,7 @@ BigQuery's type system uses confusingly different names for types and functions: | b | CEIL(value)