kramerul commented on PR #3658:
URL: https://github.com/apache/calcite/pull/3658#issuecomment-1921384505
Closing this PR in favor of a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rubenada commented on PR #3632:
URL: https://github.com/apache/calcite/pull/3632#issuecomment-1921499432
LGTM.
@jduo , Just to avoid confusion, would it be possible to align commit
message with PR title and Jira title?
--
This is an automated message from the Apache Git Service.
To
rubenada commented on PR #3659:
URL: https://github.com/apache/calcite/pull/3659#issuecomment-1921625030
Thanks for the clarification @caicancai about the related PR
I'm a bit confused, because the Jira title & description (and the PR title
and commit message) talk about
caicancai commented on code in PR #3648:
URL: https://github.com/apache/calcite/pull/3648#discussion_r1474711660
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6188,6 +6188,65 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias
kramerul closed pull request #3658: [CALCITE-6221] JDBC adapter generates
invalid query when the same table is joined multiple times
URL: https://github.com/apache/calcite/pull/3658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sonarcloud[bot] commented on PR #3664:
URL: https://github.com/apache/calcite/pull/3664#issuecomment-1921528712
## [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
caicancai commented on PR #3659:
URL: https://github.com/apache/calcite/pull/3659#issuecomment-1921560147
At that time I forgot to add tests in sqloperatortest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
caicancai commented on PR #3659:
URL: https://github.com/apache/calcite/pull/3659#issuecomment-1921558777
> > I have to admit that this is a problem left by my previous PR, and I'm
sorry for that.
>
> What previous PR? Is
tanclary commented on code in PR #3648:
URL: https://github.com/apache/calcite/pull/3648#discussion_r1474685867
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6188,6 +6188,65 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias
caicancai commented on code in PR #3648:
URL: https://github.com/apache/calcite/pull/3648#discussion_r1474701648
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6188,6 +6188,65 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias
rubenada commented on PR #3659:
URL: https://github.com/apache/calcite/pull/3659#issuecomment-1921402124
> I have to admit that this is a problem left by my previous PR, and I'm
sorry for that.
What previous PR? Is
[CALCITE-6234](https://issues.apache.org/jira/browse/CALCITE-6234)
zabetak commented on code in PR #3661:
URL: https://github.com/apache/calcite/pull/3661#discussion_r1474526470
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableBatchNestedLoopJoin.java:
##
@@ -55,6 +55,7 @@
public class EnumerableBatchNestedLoopJoin
caicancai commented on PR #3659:
URL: https://github.com/apache/calcite/pull/3659#issuecomment-1921654956
> Thanks for the clarification @caicancai about the related PR
>
> I'm a bit confused, because the Jira title & description (and the PR title
and commit message) talk about
caicancai commented on code in PR #3648:
URL: https://github.com/apache/calcite/pull/3648#discussion_r1472236067
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -6188,6 +6188,65 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias
caicancai commented on PR #3648:
URL: https://github.com/apache/calcite/pull/3648#issuecomment-1921316637
@mihaibudiu Maybe I need your opinion if you have time, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
JiajunBernoulli commented on code in PR #3661:
URL: https://github.com/apache/calcite/pull/3661#discussion_r1474422218
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableBatchNestedLoopJoin.java:
##
@@ -63,9 +64,11 @@ protected EnumerableBatchNestedLoopJoin(
sonarcloud[bot] commented on PR #3663:
URL: https://github.com/apache/calcite/pull/3663#issuecomment-1921959086
## [ {
final Result x =
sonarcloud[bot] commented on PR #3632:
URL: https://github.com/apache/calcite/pull/3632#issuecomment-1922050930
## [ {
YiwenWu commented on code in PR #3661:
URL: https://github.com/apache/calcite/pull/3661#discussion_r1474392304
##
core/src/main/java/org/apache/calcite/rel/metadata/RelMdRowCount.java:
##
@@ -181,6 +182,11 @@ public Double getRowCount(Calc rel, RelMetadataQuery mq) {
YiwenWu commented on code in PR #3664:
URL: https://github.com/apache/calcite/pull/3664#discussion_r1475566245
##
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##
@@ -437,11 +437,43 @@ public Result visit(Filter e) {
final Result x =
mihaibudiu commented on code in PR #3663:
URL: https://github.com/apache/calcite/pull/3663#discussion_r1475414494
##
core/src/main/java/org/apache/calcite/rex/RexLiteral.java:
##
@@ -325,19 +324,18 @@ public static boolean valueMatchesType(
}
// fall through
mihaibudiu commented on code in PR #3663:
URL: https://github.com/apache/calcite/pull/3663#discussion_r1475414363
##
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##
@@ -1110,6 +1110,14 @@ public RexLiteral makeApproxLiteral(BigDecimal bd) {
return
kramerul commented on code in PR #3664:
URL: https://github.com/apache/calcite/pull/3664#discussion_r147280
##
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##
@@ -437,11 +437,43 @@ public Result visit(Filter e) {
final Result x =
YiwenWu commented on code in PR #3664:
URL: https://github.com/apache/calcite/pull/3664#discussion_r1475566245
##
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##
@@ -437,11 +437,43 @@ public Result visit(Filter e) {
final Result x =
kramerul commented on PR #3664:
URL: https://github.com/apache/calcite/pull/3664#issuecomment-1922916619
I'm not so deep into Calcite that I would be able to say if there are other
cases. As far as I know, this is the only case because
* columns are only renamed in the `Join` class
*
kramerul commented on code in PR #3664:
URL: https://github.com/apache/calcite/pull/3664#discussion_r1475583359
##
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##
@@ -437,11 +437,43 @@ public Result visit(Filter e) {
final Result x =
kramerul commented on code in PR #3664:
URL: https://github.com/apache/calcite/pull/3664#discussion_r1475585120
##
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##
@@ -437,11 +437,43 @@ public Result visit(Filter e) {
final Result x =
sonarcloud[bot] commented on PR #3664:
URL: https://github.com/apache/calcite/pull/3664#issuecomment-1923021602
## [ {
final Result x =
40 matches
Mail list logo
