Re: [PR] Making code example more compilable [calcite-site]

2024-02-18 Thread via GitHub
libenchao commented on PR #6: URL: https://github.com/apache/calcite-site/pull/6#issuecomment-1951618957 Please note calcite-site's content is generated automatically via Github Actions, instead of committing manually. That said, calsite-site repository should not receive PRs. -- This

Re: [PR] [CALCITE-6273] Add sqrt negative test in SqlOperatorTest [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3695: URL: https://github.com/apache/calcite/pull/3695#discussion_r1493900158 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6110,6 +6110,18 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-6257] StarRocks dialect implementation [calcite]

2024-02-18 Thread via GitHub
sonarcloud[bot] commented on PR #3682: URL: https://github.com/apache/calcite/pull/3682#issuecomment-1951638921 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-3437] ElasticSearch adapter. Support MatchQuery in elasticse… [calcite]

2024-02-18 Thread via GitHub
houbb commented on PR #1530: URL: https://github.com/apache/calcite/pull/1530#issuecomment-1951858039 @asereda-gs @shlok7296 In calcite-elasticsearch v1.36.0,I wanna to CONTAINS to search ES,but got error。 It seems CONTAINS not support varchar type by default. How to fix it?

Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-18 Thread via GitHub
sonarcloud[bot] commented on PR #3684: URL: https://github.com/apache/calcite/pull/3684#issuecomment-1951145412 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3684: URL: https://github.com/apache/calcite/pull/3684#discussion_r1493743738 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1074,6 +1080,26 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding

Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3684: URL: https://github.com/apache/calcite/pull/3684#discussion_r1493743706 ## site/_docs/reference.md: ## @@ -2700,12 +2700,14 @@ In the following: | s | BIT_GET(value, position) | Returns the bit (0 or 1) value at the

Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3684: URL: https://github.com/apache/calcite/pull/3684#discussion_r1493743574 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -2259,6 +2272,27 @@ private static void

Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-18 Thread via GitHub
sonarcloud[bot] commented on PR #3684: URL: https://github.com/apache/calcite/pull/3684#issuecomment-1951215496 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6258] Map value constructor is unparsed incorrectly for PrestoSqlDialect [calcite]

2024-02-18 Thread via GitHub
sonarcloud[bot] commented on PR #3683: URL: https://github.com/apache/calcite/pull/3683#issuecomment-1951262843 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6257] StarRocks dialect implementation [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3682: URL: https://github.com/apache/calcite/pull/3682#discussion_r1493764295 ## core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3684: URL: https://github.com/apache/calcite/pull/3684#discussion_r1493740036 ## site/_docs/reference.md: ## @@ -2700,12 +2700,14 @@ In the following: | s | BIT_GET(value, position) | Returns the bit (0 or 1) value at the

Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3684: URL: https://github.com/apache/calcite/pull/3684#discussion_r1493743503 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -2259,6 +2272,27 @@ private static void

Re: [PR] [CALCITE-6258] Map value constructor is unparsed incorrectly for PrestoSqlDialect [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3683: URL: https://github.com/apache/calcite/pull/3683#discussion_r1493747751 ## core/src/main/java/org/apache/calcite/sql/dialect/PrestoSqlDialect.java: ## @@ -131,8 +136,30 @@ private static void unparseUsingLimit(SqlWriter writer, @Nullable

Re: [PR] [CALCITE-6260] Add already implemented functions in Spark library [calcite]

2024-02-18 Thread via GitHub
sonarcloud[bot] commented on PR #3684: URL: https://github.com/apache/calcite/pull/3684#issuecomment-1951227759 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6257] StarRocks dialect implementation [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3682: URL: https://github.com/apache/calcite/pull/3682#discussion_r1493753164 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -4506,13 +4600,16 @@ private void checkLiteral2(String expression, String

Re: [PR] [CALCITE-6257] StarRocks dialect implementation [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3682: URL: https://github.com/apache/calcite/pull/3682#discussion_r1493753164 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -4506,13 +4600,16 @@ private void checkLiteral2(String expression, String

Re: [PR] [CALCITE-6257] StarRocks dialect implementation [calcite]

2024-02-18 Thread via GitHub
YiwenWu commented on code in PR #3682: URL: https://github.com/apache/calcite/pull/3682#discussion_r1493766997 ## core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java: ## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [CALCITE-6257] StarRocks dialect implementation [calcite]

2024-02-18 Thread via GitHub
sonarcloud[bot] commented on PR #3682: URL: https://github.com/apache/calcite/pull/3682#issuecomment-1951329274 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6273] Add sqrt negative test in SqlOperatorTest [calcite]

2024-02-18 Thread via GitHub
sonarcloud[bot] commented on PR #3695: URL: https://github.com/apache/calcite/pull/3695#issuecomment-1951367265 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6257] StarRocks dialect implementation [calcite]

2024-02-18 Thread via GitHub
sonarcloud[bot] commented on PR #3682: URL: https://github.com/apache/calcite/pull/3682#issuecomment-1951328158 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] [CALCITE-6273] Add sqrt negative test in SqlOperatorTest [calcite]

2024-02-18 Thread via GitHub
caicancai opened a new pull request, #3695: URL: https://github.com/apache/calcite/pull/3695 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [CALCITE-6273] Add sqrt negative test in SqlOperatorTest [calcite]

2024-02-18 Thread via GitHub
sonarcloud[bot] commented on PR #3695: URL: https://github.com/apache/calcite/pull/3695#issuecomment-1951367525 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6273] Add sqrt negative test in SqlOperatorTest [calcite]

2024-02-18 Thread via GitHub
sonarcloud[bot] commented on PR #3695: URL: https://github.com/apache/calcite/pull/3695#issuecomment-1951372019 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate