Re: [PR] [CALCITE-6226] Wrong ISOWEEK and no ISOYEAR on BigQuery FORMAT_DATE [calcite]

2024-03-09 Thread via GitHub
rorueda commented on code in PR #3653: URL: https://github.com/apache/calcite/pull/3653#discussion_r1518608296 ## core/src/test/java/org/apache/calcite/util/format/FormatElementEnumTest.java: ## @@ -77,8 +77,32 @@ class FormatElementEnumTest {

Re: [PR] [CALCITE-6278] Add REGEXP, REGEXP_LIKE function (enabled in Spark library) [calcite]

2024-03-09 Thread via GitHub
jduo commented on PR #3712: URL: https://github.com/apache/calcite/pull/3712#issuecomment-1987007339 Would it be possible to merge these changes? I'm looking to implement CALCITE-6308 on top of this. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [CALCITE-6226] Wrong ISOWEEK and no ISOYEAR on BigQuery FORMAT_DATE [calcite]

2024-03-09 Thread via GitHub
sonarcloud[bot] commented on PR #3653: URL: https://github.com/apache/calcite/pull/3653#issuecomment-1986901137 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when inserted element type not equals map component type [calcite]

2024-03-09 Thread via GitHub
sonarcloud[bot] commented on PR #3721: URL: https://github.com/apache/calcite/pull/3721#issuecomment-1986884281 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when mapVauleType and mapKeyType not equals map Biggest mapKeytype or mapValueType [calcite]

2024-03-09 Thread via GitHub
sonarcloud[bot] commented on PR #3721: URL: https://github.com/apache/calcite/pull/3721#issuecomment-1986894580 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6015] AssertionError during optimization of EXTRACT expression [calcite]

2024-03-09 Thread via GitHub
mihaibudiu commented on code in PR #3435: URL: https://github.com/apache/calcite/pull/3435#discussion_r1518646046 ## site/_docs/history.md: ## @@ -57,6 +57,9 @@ other software versions as specified in gradle.properties. Bug-fixes, API changes and minor enhancements {:

Re: [PR] [CALCITE-6015] AssertionError during optimization of EXTRACT expression [calcite]

2024-03-09 Thread via GitHub
mihaibudiu commented on PR #3435: URL: https://github.com/apache/calcite/pull/3435#issuecomment-1986961743 Squashed the commits in preparation for merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [CALCITE-5740] support aggregate semi-join rule [calcite]

2024-03-09 Thread via GitHub
walterddr closed pull request #3288: [CALCITE-5740] support aggregate semi-join rule URL: https://github.com/apache/calcite/pull/3288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [CALCITE-6015] AssertionError during optimization of EXTRACT expression [calcite]

2024-03-09 Thread via GitHub
sonarcloud[bot] commented on PR #3435: URL: https://github.com/apache/calcite/pull/3435#issuecomment-1986956048 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6226] Wrong ISOWEEK and no ISOYEAR on BigQuery FORMAT_DATE [calcite]

2024-03-09 Thread via GitHub
sonarcloud[bot] commented on PR #3653: URL: https://github.com/apache/calcite/pull/3653#issuecomment-1986961154 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6015] AssertionError during optimization of EXTRACT expression [calcite]

2024-03-09 Thread via GitHub
sonarcloud[bot] commented on PR #3435: URL: https://github.com/apache/calcite/pull/3435#issuecomment-1986965751 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6226] Wrong ISOWEEK and no ISOYEAR on BigQuery FORMAT_DATE [calcite]

2024-03-09 Thread via GitHub
rorueda commented on code in PR #3653: URL: https://github.com/apache/calcite/pull/3653#discussion_r1518608626 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -12472,6 +12472,21 @@ void testTimestampDiff(boolean coercionEnabled) {

Re: [PR] [CALCITE-6226] Wrong ISOWEEK and no ISOYEAR on BigQuery FORMAT_DATE [calcite]

2024-03-09 Thread via GitHub
rorueda commented on PR #3653: URL: https://github.com/apache/calcite/pull/3653#issuecomment-1986898121 Since I had to rebase it onto master to address the last change request, I squashed the commits. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [CALCITE-6226] Wrong ISOWEEK and no ISOYEAR on BigQuery FORMAT_DATE [calcite]

2024-03-09 Thread via GitHub
julianhyde commented on PR #3653: URL: https://github.com/apache/calcite/pull/3653#issuecomment-1986932598 It always struck me as strange that this change is using Calendar. Day of the week is simple if you convert to Julian date. JulianOn Mar 9, 2024, at 07:59, rorueda ***@***.***>

Re: [PR] [CALCITE-6015] AssertionError during optimization of EXTRACT expression [calcite]

2024-03-09 Thread via GitHub
rubenada commented on PR #3435: URL: https://github.com/apache/calcite/pull/3435#issuecomment-1986958025 Thanks @mihaibudiu , no further comment from my side. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [CALCITE-5976] Function ARRAY_PREPEND/ARRAY_APPEND/ARRAY_INSERT gives exception when inserted element type not equals array component type [calcite]

2024-03-09 Thread via GitHub
caicancai commented on PR #3705: URL: https://github.com/apache/calcite/pull/3705#issuecomment-1987040158 @chucheng92 I fixed a similar problem. If you have time, can you help me take a look at this PR? Thank you. https://github.com/apache/calcite/pull/3721 -- This is an automated

Re: [PR] [CALCITE-6278] Add REGEXP, REGEXP_LIKE function (enabled in Spark library) [calcite]

2024-03-09 Thread via GitHub
JiajunBernoulli commented on code in PR #3712: URL: https://github.com/apache/calcite/pull/3712#discussion_r1518707371 ## site/_docs/reference.md: ## @@ -2821,8 +2821,10 @@ In the following: | b m p s | REPEAT(string, integer) | Returns a string consisting of

Re: [PR] Link to calcite notes about runnable examples and concise documents [calcite]

2024-03-09 Thread via GitHub
JiajunBernoulli merged PR #3722: URL: https://github.com/apache/calcite/pull/3722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(calcite) branch main updated: Link to calcite notes about runnable examples and concise documents

2024-03-09 Thread jiajunxie
This is an automated email from the ASF dual-hosted git repository. jiajunxie pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new ad08ce5fbd Link to calcite notes about runnable

(calcite) branch site updated: Link to calcite notes about runnable examples and concise documents

2024-03-09 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new fdd201f7c4 Link to calcite notes about

(calcite-site) branch main updated: Website deployed from calcite@ad08ce5fbdf3ea92162c853f2dbcfeb9d09694e6

2024-03-09 Thread asf-ci-deploy
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new af602a693 Website deployed from

Re: [PR] [CALCITE-6278] Add REGEXP, REGEXP_LIKE function (enabled in Spark library) [calcite]

2024-03-09 Thread via GitHub
YiwenWu commented on PR #3712: URL: https://github.com/apache/calcite/pull/3712#issuecomment-1987103098 > Would it be possible to merge these changes? I'm looking to implement [CALCITE-6309](https://issues.apache.org/jira/browse/CALCITE-6309) on top of this. @jduo I think this mr

Re: [PR] [CALCITE-6278] Add REGEXP, REGEXP_LIKE function (enabled in Spark library) [calcite]

2024-03-09 Thread via GitHub
sonarcloud[bot] commented on PR #3712: URL: https://github.com/apache/calcite/pull/3712#issuecomment-1987104572 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6278] Add REGEXP, REGEXP_LIKE function (enabled in Spark library) [calcite]

2024-03-09 Thread via GitHub
sonarcloud[bot] commented on PR #3712: URL: https://github.com/apache/calcite/pull/3712#issuecomment-1987107027 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6278] Add REGEXP, REGEXP_LIKE function (enabled in Spark library) [calcite]

2024-03-09 Thread via GitHub
YiwenWu commented on code in PR #3712: URL: https://github.com/apache/calcite/pull/3712#discussion_r1518728534 ## site/_docs/reference.md: ## @@ -2821,8 +2821,10 @@ In the following: | b m p s | REPEAT(string, integer) | Returns a string consisting of

Re: [PR] [CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when inserted element type not equals map component type [calcite]

2024-03-09 Thread via GitHub
caicancai commented on code in PR #3721: URL: https://github.com/apache/calcite/pull/3721#discussion_r1518535007 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1149,6 +1149,56 @@ private static RelDataType mapReturnType(SqlOperatorBinding

Re: [PR] [CALCITE-6259] The implementation of the Log library operator does not match the actual dialect behavior [calcite]

2024-03-09 Thread via GitHub
sonarcloud[bot] commented on PR #3711: URL: https://github.com/apache/calcite/pull/3711#issuecomment-1986800959 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6015] AssertionError during optimization of EXTRACT expression [calcite]

2024-03-09 Thread via GitHub
rubenada commented on code in PR #3435: URL: https://github.com/apache/calcite/pull/3435#discussion_r1518540130 ## site/_docs/history.md: ## @@ -57,6 +57,9 @@ other software versions as specified in gradle.properties. Bug-fixes, API changes and minor enhancements {:

Re: [PR] [CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when inserted element type not equals map component type [calcite]

2024-03-09 Thread via GitHub
caicancai commented on code in PR #3721: URL: https://github.com/apache/calcite/pull/3721#discussion_r1518534931 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1458,14 +1508,14 @@ private static RelDataType

Re: [PR] [CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when inserted element type not equals map component type [calcite]

2024-03-09 Thread via GitHub
sonarcloud[bot] commented on PR #3721: URL: https://github.com/apache/calcite/pull/3721#issuecomment-1986794800 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate