julianhyde commented on PR #3653: URL: https://github.com/apache/calcite/pull/3653#issuecomment-1986932598
It always struck me as strange that this change is using Calendar. Day of the week is simple if you convert to Julian date. JulianOn Mar 9, 2024, at 07:59, rorueda ***@***.***> wrote: @rorueda commented on this pull request. In core/src/test/java/org/apache/calcite/util/format/FormatElementEnumTest.java: > assertFormatElement(FormatElementEnum.IW, "2014-09-30T10:00:00Z", "40"); + // edge case where ISO WEEK != WEEK I added additional test cases, all manually validated against BigQuery. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
