[GitHub] [calcite] xndai commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

xndai commented on a change in pull request #1884: URL: https://github.com/apache/calcite/pull/1884#discussion_r417057932 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java ## @@ -230,6 +230,18 @@ public RelDataTypeFactory getTypeFactory() { return c

[GitHub] [calcite] FatLittle removed a comment on pull request #1950: Implement top-down rule applying and upper bound space pruning

FatLittle removed a comment on pull request #1950: URL: https://github.com/apache/calcite/pull/1950#issuecomment-620975889 > hi, @FatLittle Thank you very much for the PR you submitted. Can you include the issue link in the description of this PR? -

[GitHub] [calcite] FatLittle commented on pull request #1950: Implement top-down rule applying and upper bound space pruning

FatLittle commented on pull request #1950: URL: https://github.com/apache/calcite/pull/1950#issuecomment-620975889 > hi, @FatLittle Thank you very much for the PR you submitted. Can you include the issue link in the description of this PR? -

[GitHub] [calcite] XuQianJin-Stars commented on pull request #1950: Implement top-down rule applying and upper bound space pruning

XuQianJin-Stars commented on pull request #1950: URL: https://github.com/apache/calcite/pull/1950#issuecomment-620972850 hi, @FatLittle Thank you very much for the PR you submitted. Can you include the issue link in the description of this PR? -

[GitHub] [calcite] FatLittle commented on a change in pull request #1950: Implement top-down rule applying and upper bound space pruning

FatLittle commented on a change in pull request #1950: URL: https://github.com/apache/calcite/pull/1950#discussion_r417048028 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/CascadeRelSubset.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [calcite] FatLittle commented on a change in pull request #1950: Implement top-down rule applying and upper bound space pruning

FatLittle commented on a change in pull request #1950: URL: https://github.com/apache/calcite/pull/1950#discussion_r417047548 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/CascadePlanner.java ## @@ -0,0 +1,855 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [calcite] chunweilei commented on a change in pull request #1950: Implement top-down rule applying and upper bound space pruning

chunweilei commented on a change in pull request #1950: URL: https://github.com/apache/calcite/pull/1950#discussion_r417040034 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/CascadeRelSubset.java ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] [calcite] chunweilei commented on a change in pull request #1950: Implement top-down rule applying and upper bound space pruning

chunweilei commented on a change in pull request #1950: URL: https://github.com/apache/calcite/pull/1950#discussion_r417039685 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/CascadePlanner.java ## @@ -0,0 +1,855 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [calcite] XuQianJin-Stars commented on pull request #1951: [CALCITE-3962] Make JSON_VALUE operands varadic

XuQianJin-Stars commented on pull request #1951: URL: https://github.com/apache/calcite/pull/1951#issuecomment-620962287 +1 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[calcite] branch master updated: [CALCITE-3938] Support LogicalCalc in RelShuttle (dz)

This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 9adf4a4 [CALCITE-3938] Support LogicalCalc in

[GitHub] [calcite] chunweilei commented on a change in pull request #1941: [CALCITE-3952] Improve SortRemoveRule to remove Sort based on rowcount (Vineet Garg)

chunweilei commented on a change in pull request #1941: URL: https://github.com/apache/calcite/pull/1941#discussion_r417037019 ## File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java ## @@ -143,6 +143,14 @@ public abstract Sort copy(RelTraitSet traitSet, RelNode

[GitHub] [calcite] chunweilei commented on a change in pull request #1737: [CALCITE-3718] Support Intersect and Minus in Bindables

chunweilei commented on a change in pull request #1737: URL: https://github.com/apache/calcite/pull/1737#discussion_r417036205 ## File path: core/src/main/java/org/apache/calcite/interpreter/Bindables.java ## @@ -518,28 +522,36 @@ public Node implement(InterpreterImplementor im

[GitHub] [calcite] chunweilei commented on a change in pull request #1946: [CALCITE-3539] Implement INSTR function

chunweilei commented on a change in pull request #1946: URL: https://github.com/apache/calcite/pull/1946#discussion_r417033766 ## File path: core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java ## @@ -4508,6 +4508,15 @@ private void checkNullOperand(SqlTeste

[GitHub] [calcite] chunweilei commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

chunweilei commented on a change in pull request #1884: URL: https://github.com/apache/calcite/pull/1884#discussion_r417032712 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java ## @@ -230,6 +230,18 @@ public RelDataTypeFactory getTypeFactory() { ret

[GitHub] [calcite] julianhyde commented on pull request #1832: [CALCITE-3827] Reduce the time complexity of finding in-edges of a vertex in the graph

julianhyde commented on pull request #1832: URL: https://github.com/apache/calcite/pull/1832#issuecomment-620892041 Merged to master as 0e00d6553. This is an automated message from the Apache Git Service. To respond to the me

[calcite] branch master updated: [CALCITE-3827] Reduce the time complexity of finding in-edges of a vertex in the graph (Liya Fan)

This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 0e00d65 [CALCITE-3827] Reduce the time complexi

[GitHub] [calcite] xndai commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

xndai commented on a change in pull request #1884: URL: https://github.com/apache/calcite/pull/1884#discussion_r416956785 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSort.java ## @@ -50,7 +50,8 @@ public static EnumerableSort create(RelNode

[GitHub] [calcite] xndai commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

xndai commented on a change in pull request #1884: URL: https://github.com/apache/calcite/pull/1884#discussion_r416952583 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSort.java ## @@ -50,7 +50,8 @@ public static EnumerableSort create(RelNode

[GitHub] [calcite] xndai commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

xndai commented on a change in pull request #1884: URL: https://github.com/apache/calcite/pull/1884#discussion_r416952331 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java ## @@ -2497,6 +2509,17 @@ public RelBuilder sortLimit(int offset, int fetch, RexN

[calcite] branch master updated: [CALCITE-3878] Create ArrayList with initial capacity when size is known (Xu Zhang)

This is an automated email from the ASF dual-hosted git repository. hyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 650ce46 [CALCITE-3878] Create ArrayList with in

[calcite] branch master updated: [CALCITE-3949] RelDistributions.of() and RelCollations.of() should canonize trait instance

This is an automated email from the ASF dual-hosted git repository. hyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 11c8868 [CALCITE-3949] RelDistributions.of() an

[calcite] branch master updated: Revert "[CALCITE-3937] Fire rule for RelSubset only when it is derived"

This is an automated email from the ASF dual-hosted git repository. hyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 914b6c5 Revert "[CALCITE-3937] Fire rule for Re

[GitHub] [calcite] hsyuan opened a new pull request #1952: [CALCITE-3949] RelDistributions.of() and RelCollations.of() should canonize trait instance

hsyuan opened a new pull request #1952: URL: https://github.com/apache/calcite/pull/1952 JIRA: CALCITE-3949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] hsyuan commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

hsyuan commented on a change in pull request #1884: URL: https://github.com/apache/calcite/pull/1884#discussion_r416806191 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSort.java ## @@ -50,7 +50,8 @@ public static EnumerableSort create(RelNod

[GitHub] [calcite] hsyuan commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

hsyuan commented on a change in pull request #1884: URL: https://github.com/apache/calcite/pull/1884#discussion_r416798274 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java ## @@ -2497,6 +2509,17 @@ public RelBuilder sortLimit(int offset, int fetch, Rex

[GitHub] [calcite] hsyuan commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

hsyuan commented on a change in pull request #1884: URL: https://github.com/apache/calcite/pull/1884#discussion_r416793614 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java ## @@ -2497,6 +2509,17 @@ public RelBuilder sortLimit(int offset, int fetch, Rex

[GitHub] [calcite] xndai commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

xndai commented on a change in pull request #1884: URL: https://github.com/apache/calcite/pull/1884#discussion_r416772897 ## File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java ## @@ -2497,6 +2509,17 @@ public RelBuilder sortLimit(int offset, int fetch, RexN

[GitHub] [calcite] xndai commented on a change in pull request #1884: [CALCITE-2970] Performance issue when enabling abstract converter for EnumerableConvention

xndai commented on a change in pull request #1884: URL: https://github.com/apache/calcite/pull/1884#discussion_r416771885 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSort.java ## @@ -50,7 +50,8 @@ public static EnumerableSort create(RelNode

[GitHub] [calcite] ritesh-kapoor edited a comment on pull request #1733: [CALCITE-3679] Allow lambda expressions in SQL queries

ritesh-kapoor edited a comment on pull request #1733: URL: https://github.com/apache/calcite/pull/1733#issuecomment-620616182 I will resolve conflicts after PR tagged LGTM. Let me know if there are concerns :) This is an aut

[GitHub] [calcite] ritesh-kapoor commented on pull request #1733: [CALCITE-3679] Allow lambda expressions in SQL queries

ritesh-kapoor commented on pull request #1733: URL: https://github.com/apache/calcite/pull/1733#issuecomment-620616182 I will resolve conflicts after PR tagged LGTM This is an automated message from the Apache Git Service. To

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1733: [CALCITE-3679] Allow lambda expressions in SQL queries

ritesh-kapoor commented on a change in pull request #1733: URL: https://github.com/apache/calcite/pull/1733#discussion_r416622232 ## File path: core/src/main/java/org/apache/calcite/sql/SqlLambda.java ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1733: [CALCITE-3679] Allow lambda expressions in SQL queries

ritesh-kapoor commented on a change in pull request #1733: URL: https://github.com/apache/calcite/pull/1733#discussion_r416619985 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLambdaOperator.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1733: [CALCITE-3679] Allow lambda expressions in SQL queries

ritesh-kapoor commented on a change in pull request #1733: URL: https://github.com/apache/calcite/pull/1733#discussion_r416618793 ## File path: core/src/main/java/org/apache/calcite/sql/type/LambdaOperandTypeChecker.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Soft

[GitHub] [calcite] rubenada commented on pull request #1918: [CALCITE-3926] CannotPlanException when an empty LogicalValues requires a certain collation

rubenada commented on pull request #1918: URL: https://github.com/apache/calcite/pull/1918#issuecomment-620584893 @danny0405 @xndai @hsyuan Do you think we could consider merging the proposed fix? It solves this specific problem by just propagating the Sort's collation into the empty value

[GitHub] [calcite] danny0405 opened a new pull request #1951: [CALCITE-3962] Make JSON_VALUE operands varadic

danny0405 opened a new pull request #1951: URL: https://github.com/apache/calcite/pull/1951 Current JSON_VALUE always has 7 operands after parsing, the operands are patched with defaults when creating the call. This has some drawbacks: - With a hard code operator there, it i

[GitHub] [calcite] FatLittle opened a new pull request #1950: Implement top-down rule applying and upper bound space pruning

FatLittle opened a new pull request #1950: URL: https://github.com/apache/calcite/pull/1950 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t