hsyuan commented on a change in pull request #1884:
URL: https://github.com/apache/calcite/pull/1884#discussion_r416806191
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableSort.java
##########
@@ -50,7 +50,8 @@ public static EnumerableSort create(RelNode child,
RelCollation collation,
final RelTraitSet traitSet =
cluster.traitSetOf(EnumerableConvention.INSTANCE)
.replace(collation);
- return new EnumerableSort(cluster, traitSet, child, collation, offset,
+ return new EnumerableSort(cluster, traitSet, child,
+ (RelCollation) traitSet.getTrait(collation.getTraitDef()), offset,
Review comment:
We still don't need it. Because there is another bug causing it:
https://issues.apache.org/jira/browse/CALCITE-3949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
