[GitHub] [calcite] danny0405 commented on a change in pull request #2089: [CALCITE-4081] Round-tripping a DECIMAL literal throws validation error

2020-07-30 Thread GitBox
danny0405 commented on a change in pull request #2089: URL: https://github.com/apache/calcite/pull/2089#discussion_r463436765 ## File path: core/src/test/resources/sql/misc.iq ## @@ -1689,7 +1689,7 @@ EnumerableCalc(expr#0=[{inputs}], expr#1=[123:BIGINT], EXPR$0=[$t1]) !plan

[GitHub] [calcite] danny0405 commented on a change in pull request #2089: [CALCITE-4081] Round-tripping a DECIMAL literal throws validation error

2020-07-30 Thread GitBox
danny0405 commented on a change in pull request #2089: URL: https://github.com/apache/calcite/pull/2089#discussion_r463435842 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1751,4 +1752,18 @@ public static RelDataType extractLastNFields(Re

[calcite] branch master updated: [CALCITE-4118] RexSimplify might remove CAST from RexNode incorrectly

2020-07-30 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 2088488 [CALCITE-4118] RexSimplify might remo

[GitHub] [calcite] chunweilei merged pull request #2072: [CALCITE-4118] RexSimplify might remove CAST from RexNode incorrectly

2020-07-30 Thread GitBox
chunweilei merged pull request #2072: URL: https://github.com/apache/calcite/pull/2072 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei commented on a change in pull request #2089: [CALCITE-4081] Round-tripping a DECIMAL literal throws validation error

2020-07-30 Thread GitBox
chunweilei commented on a change in pull request #2089: URL: https://github.com/apache/calcite/pull/2089#discussion_r463390656 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1751,4 +1752,18 @@ public static RelDataType extractLastNFields(R

[GitHub] [calcite] chunweilei commented on a change in pull request #2089: [CALCITE-4081] Round-tripping a DECIMAL literal throws validation error

2020-07-30 Thread GitBox
chunweilei commented on a change in pull request #2089: URL: https://github.com/apache/calcite/pull/2089#discussion_r463390656 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1751,4 +1752,18 @@ public static RelDataType extractLastNFields(R

[GitHub] [calcite] chunweilei commented on a change in pull request #2089: [CALCITE-4081] Round-tripping a DECIMAL literal throws validation error

2020-07-30 Thread GitBox
chunweilei commented on a change in pull request #2089: URL: https://github.com/apache/calcite/pull/2089#discussion_r463390290 ## File path: core/src/test/resources/sql/misc.iq ## @@ -1689,7 +1689,7 @@ EnumerableCalc(expr#0=[{inputs}], expr#1=[123:BIGINT], EXPR$0=[$t1]) !plan

[GitHub] [calcite] danny0405 commented on a change in pull request #2089: [CALCITE-4081] Round-tripping a DECIMAL literal throws validation error

2020-07-30 Thread GitBox
danny0405 commented on a change in pull request #2089: URL: https://github.com/apache/calcite/pull/2089#discussion_r463387249 ## File path: core/src/test/resources/sql/misc.iq ## @@ -1689,7 +1689,7 @@ EnumerableCalc(expr#0=[{inputs}], expr#1=[123:BIGINT], EXPR$0=[$t1]) !plan

[GitHub] [calcite] danny0405 commented on a change in pull request #2089: [CALCITE-4081] Round-tripping a DECIMAL literal throws validation error

2020-07-30 Thread GitBox
danny0405 commented on a change in pull request #2089: URL: https://github.com/apache/calcite/pull/2089#discussion_r463386673 ## File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java ## @@ -1751,4 +1752,18 @@ public static RelDataType extractLastNFields(Re

[GitHub] [calcite] chavangaurav1 closed pull request #2091: Support for date function

2020-07-30 Thread GitBox
chavangaurav1 closed pull request #2091: URL: https://github.com/apache/calcite/pull/2091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] chavangaurav1 opened a new pull request #2091: Support for date function

2020-07-30 Thread GitBox
chavangaurav1 opened a new pull request #2091: URL: https://github.com/apache/calcite/pull/2091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [calcite] yuqi1129 closed pull request #2075: [CALCITE-4130] Aggregation function in order by clause will throw Exception

2020-07-30 Thread GitBox
yuqi1129 closed pull request #2075: URL: https://github.com/apache/calcite/pull/2075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite-avatica-go] F21 commented on a change in pull request #53: [CALCITE-4147] Rename "master" branch to "main"

2020-07-30 Thread GitBox
F21 commented on a change in pull request #53: URL: https://github.com/apache/calcite-avatica-go/pull/53#discussion_r462647404 ## File path: docker.sh ## @@ -205,10 +205,10 @@ check_if_tag_exists(){ check_local_remote_are_even(){ REMOTE_COMMIT=$(git ls-remote $GITBOX_UR

[GitHub] [calcite] chunweilei commented on pull request #1138: [CALCITE-1581] UDTF like in hive

2020-07-30 Thread GitBox
chunweilei commented on pull request #1138: URL: https://github.com/apache/calcite/pull/1138#issuecomment-666095440 @pengzhiwei2018 , could you please resolve conflicts? I think it needs a final review and I would like to do that. --

[GitHub] [calcite-avatica] michaelmior opened a new pull request #124: [CALCITE-4147] Rename "master" branch to "main"

2020-07-30 Thread GitBox
michaelmior opened a new pull request #124: URL: https://github.com/apache/calcite-avatica/pull/124 This would need to happen in concert with changes to the Calcite repo. Although I think perhaps the first (and lowest impact) change will be to the site repo. ---

[GitHub] [calcite-avatica-go] michaelmior opened a new pull request #53: [CALCITE-4147] Rename "master" branch to "main"

2020-07-30 Thread GitBox
michaelmior opened a new pull request #53: URL: https://github.com/apache/calcite-avatica-go/pull/53 See the associated JIRA case for full details as this will be coordinated across multiple Calcite subprojects. This is an a

[GitHub] [calcite-avatica-go] michaelmior commented on a change in pull request #53: [CALCITE-4147] Rename "master" branch to "main"

2020-07-30 Thread GitBox
michaelmior commented on a change in pull request #53: URL: https://github.com/apache/calcite-avatica-go/pull/53#discussion_r462670972 ## File path: docker.sh ## @@ -205,10 +205,10 @@ check_if_tag_exists(){ check_local_remote_are_even(){ REMOTE_COMMIT=$(git ls-remote $G

[GitHub] [calcite] chunweilei commented on pull request #1405: [CALCITE-2772] Support varargs UDF for scalar function

2020-07-30 Thread GitBox
chunweilei commented on pull request #1405: URL: https://github.com/apache/calcite/pull/1405#issuecomment-666069016 @gr4ve, do you still want to work on this? If no, I would like to take over if you don't mind. This is an a

[GitHub] [calcite] michaelmior opened a new pull request #2090: [CALCITE-4147] Rename master branch to main

2020-07-30 Thread GitBox
michaelmior opened a new pull request #2090: URL: https://github.com/apache/calcite/pull/2090 See the associated JIRA for more on the full migration plan. This is an automated message from the Apache Git Service. To respond t