[GitHub] [calcite] liyafan82 commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

2020-09-13 Thread GitBox
liyafan82 commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r487628337 ## File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java ## @@ -918,6 +918,28 @@ private void checkRelSelectivity( @Test void

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

2020-09-13 Thread GitBox
Aaron commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487622205 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -222,6 +223,22 @@ */ void explain(RelWriter pw); + /** + * Return

[GitHub] [calcite] chunweilei commented on pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

2020-09-13 Thread GitBox
chunweilei commented on pull request #2148: URL: https://github.com/apache/calcite/pull/2148#issuecomment-691773724 Seems duplicate with https://github.com/apache/calcite/pull/2121. This is an automated message from the Apach

[GitHub] [calcite] chunweilei merged pull request #2145: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-13 Thread GitBox
chunweilei merged pull request #2145: URL: https://github.com/apache/calcite/pull/2145 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[calcite] branch master updated: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-13 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 1ae20f3 [CALCITE-4239] RelMdUniqueKeys return

[GitHub] [calcite] chunweilei commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

2020-09-13 Thread GitBox
chunweilei commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487616657 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +108,25 @@ final String relOptimized

[GitHub] [calcite] chunweilei commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

2020-09-13 Thread GitBox
chunweilei commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r487615286 ## File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java ## @@ -918,6 +918,28 @@ private void checkRelSelectivity( @Test void

[calcite] branch master updated: [CALCITE-4197] Provide utility to visualize RelNode plans

2020-09-13 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 99c0fef [CALCITE-4197] Provide utility to vis

[GitHub] [calcite] chunweilei merged pull request #2128: [CALCITE-4197] Provide utility to visualize RelNode plans

2020-09-13 Thread GitBox
chunweilei merged pull request #2128: URL: https://github.com/apache/calcite/pull/2128 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go