[GitHub] [calcite] libenchao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-24 Thread via GitHub
libenchao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1204993079 ## core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java: ## @@ -866,6 +866,8 @@ private static void matchFilter(SubQueryRemoveRule rule,

[GitHub] [calcite] libenchao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-24 Thread via GitHub
libenchao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1204991292 ## core/src/main/java/org/apache/calcite/rel/rules/SubQueryRemoveRule.java: ## @@ -866,6 +866,8 @@ private static void matchFilter(SubQueryRemoveRule rule,

[GitHub] [calcite] zoudan commented on a diff in pull request #3154: CALCITE-5649 Produce row count statistics from ReflectiveSchema for array based tables

2023-05-24 Thread via GitHub
zoudan commented on code in PR #3154: URL: https://github.com/apache/calcite/pull/3154#discussion_r1204946465 ## core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java: ## @@ -63,9 +65,7 @@ import static org.hamcrest.CoreMatchers.equalTo; import static

[GitHub] [calcite] ian-bertolacci commented on pull request #3224: [CALCITE-5722] Fix RangeSets.isPoint to use Comparable equality

2023-05-24 Thread via GitHub
ian-bertolacci commented on PR #3224: URL: https://github.com/apache/calcite/pull/3224#issuecomment-1562082102 Pertinent line from the [`Comparable`

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3224: [CALCITE-5722] Fix RangeSets.isPoint to use Comparable equality

2023-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #3224: URL: https://github.com/apache/calcite/pull/3224#issuecomment-1561876196 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zstan commented on pull request #3203: [CALCITE-5703] Reduce amount of generated runtime code

2023-05-24 Thread via GitHub
zstan commented on PR #3203: URL: https://github.com/apache/calcite/pull/3203#issuecomment-1561573151 > Sorry for the late reply. I make some tests in my local environment. The optimization for `BinaryExpression` seems to be incorrect. The code after optimization throws compilation error.

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3223: [CALCITE-5721] Capture build scans on ge.apache.org to benefit from deep build insights

2023-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #3223: URL: https://github.com/apache/calcite/pull/3223#issuecomment-1561470805 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] clayburn commented on a diff in pull request #3223: [CALCITE-5721] Capture build scans on ge.apache.org to benefit from deep build insights

2023-05-24 Thread via GitHub
clayburn commented on code in PR #3223: URL: https://github.com/apache/calcite/pull/3223#discussion_r1204428360 ## settings.gradle.kts: ## @@ -100,12 +104,18 @@ fun property(name: String) = val isCiServer = System.getenv().containsKey("CI") -if (isCiServer) { -

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3179: [CALCITE-5676] Set `DATA_TYPE` and `TYPE_NAME` metadata values for `MEASURE` types

2023-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #3179: URL: https://github.com/apache/calcite/pull/3179#issuecomment-1561367674 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3179: [CALCITE-5676] Set `DATA_TYPE` and `TYPE_NAME` metadata values for `MEASURE` types

2023-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #3179: URL: https://github.com/apache/calcite/pull/3179#issuecomment-1561359091 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] asolimando commented on a diff in pull request #3223: [CALCITE-5721] Capture build scans on ge.apache.org to benefit from deep build insights

2023-05-24 Thread via GitHub
asolimando commented on code in PR #3223: URL: https://github.com/apache/calcite/pull/3223#discussion_r1204360319 ## settings.gradle.kts: ## @@ -100,12 +104,18 @@ fun property(name: String) = val isCiServer = System.getenv().containsKey("CI") -if (isCiServer) { -

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3179: [CALCITE-5676] Set `DATA_TYPE` and `TYPE_NAME` metadata values for `MEASURE` types

2023-05-24 Thread via GitHub
tjbanghart commented on code in PR #3179: URL: https://github.com/apache/calcite/pull/3179#discussion_r1204348145 ## core/src/test/java/org/apache/calcite/test/JdbcFrontLinqBackTest.java: ## @@ -343,12 +356,13 @@ private CalciteAssert.AssertThat mutable(

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3223: [CALCITE-5721] Capture build scans on ge.apache.org to benefit from deep build insights

2023-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #3223: URL: https://github.com/apache/calcite/pull/3223#issuecomment-1561318078 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] clayburn opened a new pull request, #3223: [CALCITE-5721] Capture build scans on ge.apache.org to benefit from deep build insights

2023-05-24 Thread via GitHub
clayburn opened a new pull request, #3223: URL: https://github.com/apache/calcite/pull/3223 This PR publishes a build scan for every CI build on Jenkins and GitHub Actions and for every local build from an authenticated Apache committer. The build will not fail if publishing fails.

[calcite] branch main updated: [CALCITE-5674] CAST expr to target type should respect nullable when it is complex type (follow-up)

2023-05-24 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 3843ede3d2 [CALCITE-5674] CAST expr to target

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3222: [CALCITE-5674] CAST expr to target type should respect nullable when it is complex type (follow-up)

2023-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #3222: URL: https://github.com/apache/calcite/pull/3222#issuecomment-1561159415 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] liuyongvs commented on pull request #3202: [CALCITE-5704] Add ARRAY_EXCEPT, ARRAY_INTERSECT, ARRAY_UNION function (enabled in Spark library)

2023-05-24 Thread via GitHub
liuyongvs commented on PR #3202: URL: https://github.com/apache/calcite/pull/3202#issuecomment-1560944711 hi @JiajunBernoulli @herunkang2018 what's next? will it be merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3202: [CALCITE-5704] Add ARRAY_EXCEPT, ARRAY_INTERSECT, ARRAY_UNION function (enabled in Spark library)

2023-05-24 Thread via GitHub
herunkang2018 commented on code in PR #3202: URL: https://github.com/apache/calcite/pull/3202#discussion_r1203928691 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3797,6 +3797,29 @@ public static List distinct(List list) { return new

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3211: [CALCITE-5708] Change SUBSTRING result if either of parameters is NULL

2023-05-24 Thread via GitHub
herunkang2018 commented on code in PR #3211: URL: https://github.com/apache/calcite/pull/3211#discussion_r1203925301 ## core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java: ## @@ -1042,6 +1042,10 @@ void testDyadicCollateOperator() {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3214: [CALCITE-5608] Implement ASINH, ACOSH, ATANH functions

2023-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #3214: URL: https://github.com/apache/calcite/pull/3214#issuecomment-1560778843 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada commented on a diff in pull request #3214: [CALCITE-5608] Implement ASINH, ACOSH, ATANH functions

2023-05-24 Thread via GitHub
rubenada commented on code in PR #3214: URL: https://github.com/apache/calcite/pull/3214#discussion_r1203727760 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5539,6 +5539,72 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] zoudan commented on a diff in pull request #3214: [CALCITE-5608] Implement ASINH, ACOSH, ATANH functions

2023-05-24 Thread via GitHub
zoudan commented on code in PR #3214: URL: https://github.com/apache/calcite/pull/3214#discussion_r1203720887 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5539,6 +5539,72 @@ private static void checkIf(SqlOperatorFixture f) {

[calcite] branch main updated: [CALCITE-5705] Generalize RemoveEmptySingleRule to work with arbitrary relations and pruning configurations

2023-05-24 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new f32289870b [CALCITE-5705] Generalize

[GitHub] [calcite] zabetak closed pull request #3205: [CALCITE-5705] Generalize RemoveEmptySingleRule to work with arbitrary relations and pruning configurations

2023-05-24 Thread via GitHub
zabetak closed pull request #3205: [CALCITE-5705] Generalize RemoveEmptySingleRule to work with arbitrary relations and pruning configurations URL: https://github.com/apache/calcite/pull/3205 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] rubenada commented on a diff in pull request #3214: [CALCITE-5608] Implement ASINH, ACOSH, ATANH functions

2023-05-24 Thread via GitHub
rubenada commented on code in PR #3214: URL: https://github.com/apache/calcite/pull/3214#discussion_r1203672908 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5539,6 +5539,72 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] rubenada commented on a diff in pull request #3214: [CALCITE-5608] Implement ASINH, ACOSH, ATANH functions

2023-05-24 Thread via GitHub
rubenada commented on code in PR #3214: URL: https://github.com/apache/calcite/pull/3214#discussion_r1203671206 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5539,6 +5539,72 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] rubenada commented on a diff in pull request #3214: [CALCITE-5608] Implement ASINH, ACOSH, ATANH functions

2023-05-24 Thread via GitHub
rubenada commented on code in PR #3214: URL: https://github.com/apache/calcite/pull/3214#discussion_r1203665979 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -1897,6 +1930,29 @@ public static double atan2(double b0, double b1) { return

[GitHub] [calcite] rubenada commented on a diff in pull request #3214: [CALCITE-5608] Implement ASINH, ACOSH, ATANH functions

2023-05-24 Thread via GitHub
rubenada commented on code in PR #3214: URL: https://github.com/apache/calcite/pull/3214#discussion_r1203661166 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -1854,6 +1854,20 @@ public static double acos(double b0) { return Math.acos(b0); }

[calcite] branch main updated: [CALCITE-5668] When parsing SQL in PostgreSQL dialect, allow unquoted table names to contain dollar sign, letters with diacritical marks and non-Latin letters

2023-05-24 Thread dmsysolyatin
This is an automated email from the ASF dual-hosted git repository. dmsysolyatin pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 0d3cf2cbad [CALCITE-5668] When parsing SQL

[GitHub] [calcite] dssysolyatin closed pull request #2737: [CALCITE-5029] Babel parser support identifier starting with number

2023-05-24 Thread via GitHub
dssysolyatin closed pull request #2737: [CALCITE-5029] Babel parser support identifier starting with number URL: https://github.com/apache/calcite/pull/2737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] dssysolyatin closed pull request #3215: [CALCITE-5668] When parsing SQL in PostgreSQL dialect, allow unquoted table names to contain dollar sign, letters with diacritical marks and

2023-05-24 Thread via GitHub
dssysolyatin closed pull request #3215: [CALCITE-5668] When parsing SQL in PostgreSQL dialect, allow unquoted table names to contain dollar sign, letters with diacritical marks and non-Latin letters URL: https://github.com/apache/calcite/pull/3215 -- This is an automated message from the

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3221: [CALCITE-5709] Add TO_BASE32 and FROM_BASE32 functions (enabled in BigQuery library)

2023-05-24 Thread via GitHub
sonarcloud[bot] commented on PR #3221: URL: https://github.com/apache/calcite/pull/3221#issuecomment-1560602118 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zoudan opened a new pull request, #3221: [CALCITE-5709] Add TO_BASE32 and FROM_BASE32 functions (enabled in BigQuery library)

2023-05-24 Thread via GitHub
zoudan opened a new pull request, #3221: URL: https://github.com/apache/calcite/pull/3221 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,