[GitHub] [calcite] sonarcloud[bot] commented on pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

sonarcloud[bot] commented on PR #3237: URL: https://github.com/apache/calcite/pull/3237#issuecomment-1585473812 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zoudan commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

zoudan commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1225066147 ## core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java: ## @@ -427,6 +427,13 @@ public static SqlCall stripSeparator(SqlCall call) { public static final

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3257: [CALCITE-5759] SEARCH operator with special sarg is not fully simplified

sonarcloud[bot] commented on PR #3257: URL: https://github.com/apache/calcite/pull/3257#issuecomment-1585462150 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zoudan commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

zoudan commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1225056926 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4102,6 +4102,45 @@ public static List reverse(List list) { return list; } + /**

[GitHub] [calcite] JiajunBernoulli commented on pull request #3221: [CALCITE-5709] Add TO_BASE32 and FROM_BASE32 functions (enabled in BigQuery library)

JiajunBernoulli commented on PR #3221: URL: https://github.com/apache/calcite/pull/3221#issuecomment-1585443798 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

JiajunBernoulli commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1225037630 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -4102,6 +4102,45 @@ public static List reverse(List list) { return list; }

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

JiajunBernoulli commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1225024684 ## core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java: ## @@ -427,6 +427,13 @@ public static SqlCall stripSeparator(SqlCall call) { public

[GitHub] [calcite] JiajunBernoulli commented on pull request #3188: [CALCITE-5688] Support TRUNCATE TABLE DDL statement in Babel parser

JiajunBernoulli commented on PR #3188: URL: https://github.com/apache/calcite/pull/3188#issuecomment-1585431392 @sumeetgajjar Do you still have time to move it to Babel? If not, I will move it. And save your name in the commit. -- This is an automated message from the Apache Git

[GitHub] [calcite] liuyongvs commented on pull request #3238: [CALCITE-5744] Add MAP_FROM_ARRAYS, STR_TO_MAP function (enabled in Spark library)

liuyongvs commented on PR #3238: URL: https://github.com/apache/calcite/pull/3238#issuecomment-1585317402 Hi @tanclary @MasseGuillaume @JiajunBernoulli @julianhjulidoes anyone make it further. My other pr depends on it. Thanks for all reviews very much -- This is an automated message

[GitHub] [calcite] liuyongvs commented on pull request #3207: [CALCITE-5707] Add ARRAY_CONTAINS function (enabled in Spark library)

liuyongvs commented on PR #3207: URL: https://github.com/apache/calcite/pull/3207#issuecomment-1585316002 @julianhyde thanks so much. I will submit others quickly when it is merged because others in my local commit -- This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] julianhyde commented on a diff in pull request #3253: [CALCITE-5761] Handle DECADE, CENTURY, and MILLENNIUM for DATE_TRUNC

julianhyde commented on code in PR #3253: URL: https://github.com/apache/calcite/pull/3253#discussion_r1224903801 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -2385,16 +2385,24 @@ private static class FloorImplementor extends

[GitHub] [calcite] mihaibudiu commented on a diff in pull request #3253: [CALCITE-5761] Handle DECADE, CENTURY, and MILLENNIUM for DATE_TRUNC

mihaibudiu commented on code in PR #3253: URL: https://github.com/apache/calcite/pull/3253#discussion_r1224902085 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -2385,16 +2385,24 @@ private static class FloorImplementor extends

[GitHub] [calcite] julianhyde commented on a diff in pull request #3253: [CALCITE-5761] Handle DECADE, CENTURY, and MILLENNIUM for DATE_TRUNC

julianhyde commented on code in PR #3253: URL: https://github.com/apache/calcite/pull/3253#discussion_r1224902007 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -9641,6 +9641,12 @@ void testTimestampDiff(boolean coercionEnabled) {

[GitHub] [calcite] julianhyde commented on a diff in pull request #3253: [CALCITE-5761] Handle DECADE, CENTURY, and MILLENNIUM for DATE_TRUNC

julianhyde commented on code in PR #3253: URL: https://github.com/apache/calcite/pull/3253#discussion_r1224901567 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -2385,16 +2385,24 @@ private static class FloorImplementor extends

[GitHub] [calcite] julianhyde commented on a diff in pull request #3234: [CALCITE-5735] Add SAFE_MULTIPLY function (enabled in BigQuery)

julianhyde commented on code in PR #3234: URL: https://github.com/apache/calcite/pull/3234#discussion_r1217257420 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -1524,6 +1524,19 @@ public static int multiply(int b0, int b1) { throw

[GitHub] [calcite] julianhyde commented on a diff in pull request #3245: [CALCITE-5747] Conflicting FLOOR return type between Calcite and BigQ…

julianhyde commented on code in PR #3245: URL: https://github.com/apache/calcite/pull/3245#discussion_r1224881785 ## core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java: ## @@ -1853,12 +1853,14 @@ public class SqlStdOperatorTable extends

[GitHub] [calcite] julianhyde commented on a diff in pull request #3245: [CALCITE-5747] Conflicting FLOOR return type between Calcite and BigQ…

julianhyde commented on code in PR #3245: URL: https://github.com/apache/calcite/pull/3245#discussion_r1224877404 ## core/src/main/java/org/apache/calcite/sql/fun/SqlFloorFunction.java: ## @@ -41,22 +45,23 @@ public class SqlFloorFunction extends SqlMonotonicUnaryFunction {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

sonarcloud[bot] commented on PR #3237: URL: https://github.com/apache/calcite/pull/3237#issuecomment-1584850249 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

rubenada commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1224504358 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5474,6 +5474,29 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] zoudan commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

zoudan commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1224499961 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,30 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

sonarcloud[bot] commented on PR #3237: URL: https://github.com/apache/calcite/pull/3237#issuecomment-1584807131 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

rubenada commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1224478220 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,30 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] zoudan commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

zoudan commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1224462179 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,57 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] rubenada commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

rubenada commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1224342705 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,57 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] rubenada commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

rubenada commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1224342705 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,57 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] rubenada commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

rubenada commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1224342705 ## core/src/main/java/org/apache/calcite/sql/type/OperandTypes.java: ## @@ -471,6 +471,57 @@ public static SqlOperandTypeChecker variadic(

[GitHub] [calcite] pawellozinski closed pull request #2676: [CALCITE-4753] Extend FunctionContext with a DataContext getter

pawellozinski closed pull request #2676: [CALCITE-4753] Extend FunctionContext with a DataContext getter URL: https://github.com/apache/calcite/pull/2676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[calcite] branch main updated: [CALCITE-5401] Rule fired by HepPlanner can return Volcano's RelSubset

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 2e3e4ae220 [CALCITE-5401] Rule fired by

[GitHub] [calcite] rubenada merged pull request #3243: [CALCITE-5401] Rule fired by HepPlanner can return Volcano's RelSubset

rubenada merged PR #3243: URL: https://github.com/apache/calcite/pull/3243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

sonarcloud[bot] commented on PR #3237: URL: https://github.com/apache/calcite/pull/3237#issuecomment-1584342623 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] rubenada closed pull request #3185: [CALCITE-5401] Rule fired by HepPlanner can return Volcano's RelSubset

rubenada closed pull request #3185: [CALCITE-5401] Rule fired by HepPlanner can return Volcano's RelSubset URL: https://github.com/apache/calcite/pull/3185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] rubenada commented on pull request #3185: [CALCITE-5401] Rule fired by HepPlanner can return Volcano's RelSubset

rubenada commented on PR #3185: URL: https://github.com/apache/calcite/pull/3185#issuecomment-1584338954 Closing this in favor of https://github.com/apache/calcite/pull/3243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[calcite] branch main updated: [CALCITE-5721] Capture build scans on ge.apache.org to benefit from deep build insights

This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 9f41a123b7 [CALCITE-5721] Capture build scans on

[GitHub] [calcite] zabetak closed pull request #3223: [CALCITE-5721] Capture build scans on ge.apache.org to benefit from deep build insights

zabetak closed pull request #3223: [CALCITE-5721] Capture build scans on ge.apache.org to benefit from deep build insights URL: https://github.com/apache/calcite/pull/3223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] zoudan commented on pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

zoudan commented on PR #3237: URL: https://github.com/apache/calcite/pull/3237#issuecomment-1584322389 @liuyongvs Thanks for you comments, I have updated my code, please take a look. cc @rubenada -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] zabetak commented on a diff in pull request #3243: [CALCITE-5401] Rule fired by HepPlanner can return Volcano's RelSubset

zabetak commented on code in PR #3243: URL: https://github.com/apache/calcite/pull/3243#discussion_r1224080318 ## core/src/main/java/org/apache/calcite/plan/RelOptRule.java: ## @@ -614,7 +616,10 @@ public static RelNode convert(RelNode rel, RelTraitSet toTraits) { *

[GitHub] [calcite] zoudan commented on a diff in pull request #3237: [CALCITE-5728] Add ARRAY_TO_STRING function (enabled in BigQuery library)

zoudan commented on code in PR #3237: URL: https://github.com/apache/calcite/pull/3237#discussion_r1224031080 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5474,6 +5474,29 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] ILuffZhe commented on pull request #3247: [CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

ILuffZhe commented on PR #3247: URL: https://github.com/apache/calcite/pull/3247#issuecomment-1584126536 > > > Can you also please add a unit test here? It helps reviewers to understand better. > > > > > > I'll have a try to add a test. > > BTW, I seem to not find pom.xml

[GitHub] [calcite] YasuoStudyJava commented on pull request #3247: [CALCITE-5733] Simplify "a = ARRAY[1,2] AND a = ARRAY[2,3]" to "false"

YasuoStudyJava commented on PR #3247: URL: https://github.com/apache/calcite/pull/3247#issuecomment-1584116139 > > Can you also please add a unit test here? It helps reviewers to understand better. > > I'll have a try to add a test. BTW, I seem to not find pom.xml in source