ViggoC commented on code in PR #3311:
URL: https://github.com/apache/calcite/pull/3311#discussion_r1262012604
##
core/src/test/java/org/apache/calcite/test/enumerable/EnumerableHashJoinTest.java:
##
@@ -74,6 +74,25 @@ class EnumerableHashJoinTest {
"empid=110;
chucheng92 commented on code in PR #3313:
URL: https://github.com/apache/calcite/pull/3313#discussion_r1261981582
##
plus/src/main/java/org/apache/calcite/chinook/ChinookAvaticaServer.java:
##
@@ -62,16 +62,18 @@ public static class CalciteChinookMetaFactory implements
libenchao commented on code in PR #3313:
URL: https://github.com/apache/calcite/pull/3313#discussion_r1261916888
##
plus/src/main/java/org/apache/calcite/chinook/ChinookAvaticaServer.java:
##
@@ -62,16 +62,18 @@ public static class CalciteChinookMetaFactory implements
sonarcloud[bot] commented on PR #3308:
URL: https://github.com/apache/calcite/pull/3308#issuecomment-1633460279
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
ForestLH commented on PR #3308:
URL: https://github.com/apache/calcite/pull/3308#issuecomment-1633439794
> I think you're right. So I am +1 for this change. But the commit message
should be more clear.
Thank you reply :)
--
This is an automated message from the Apache Git
sonarcloud[bot] commented on PR #3314:
URL: https://github.com/apache/calcite/pull/3314#issuecomment-1633432135
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3314:
URL: https://github.com/apache/calcite/pull/3314#issuecomment-1633421760
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
mihaibudiu opened a new pull request, #3314:
URL: https://github.com/apache/calcite/pull/3314
I wasn't entirely sure how to handle conversions to other types than the
numeric ones, so I left the previous behavior unchanged, but there may be other
problems lurking.
--
This is an
sonarcloud[bot] commented on PR #3302:
URL: https://github.com/apache/calcite/pull/3302#issuecomment-1633390122
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3302:
URL: https://github.com/apache/calcite/pull/3302#issuecomment-1633384319
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
herunkang2018 commented on PR #3302:
URL: https://github.com/apache/calcite/pull/3302#issuecomment-1633374976
@tanclary Thanks very kindly for you reviewing. I have rebased and squashed
to one final commit.
--
This is an automated message from the Apache Git Service.
To respond to the
sonarcloud[bot] commented on PR #3313:
URL: https://github.com/apache/calcite/pull/3313#issuecomment-1632982138
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3310:
URL: https://github.com/apache/calcite/pull/3310#issuecomment-1632923024
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
This is an automated email from the ASF dual-hosted git repository.
rubenql pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 55f714cc37 [CALCITE-5839]
rubenada merged PR #3312:
URL: https://github.com/apache/calcite/pull/3312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3307:
URL: https://github.com/apache/calcite/pull/3307#issuecomment-1632761239
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3312:
URL: https://github.com/apache/calcite/pull/3312#issuecomment-1632729833
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3302:
URL: https://github.com/apache/calcite/pull/3302#issuecomment-1632722673
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
thomasrebele commented on PR #3312:
URL: https://github.com/apache/calcite/pull/3312#issuecomment-1632696681
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rubenada opened a new pull request, #3312:
URL: https://github.com/apache/calcite/pull/3312
See details in CALCITE-5839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on PR #3311:
URL: https://github.com/apache/calcite/pull/3311#issuecomment-1632622637
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
herunkang2018 commented on code in PR #3302:
URL: https://github.com/apache/calcite/pull/3302#discussion_r1261200248
##
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##
@@ -417,6 +417,7 @@ public enum BuiltInMethod {
INITCAP(SqlFunctions.class, "initcap",
herunkang2018 commented on code in PR #3302:
URL: https://github.com/apache/calcite/pull/3302#discussion_r1261200248
##
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##
@@ -417,6 +417,7 @@ public enum BuiltInMethod {
INITCAP(SqlFunctions.class, "initcap",
snuyanzin commented on PR #220:
URL: https://github.com/apache/calcite-avatica/pull/220#issuecomment-1632255826
the PR was created when only 32.0.0 was present, that's the reason
i will update it
--
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git
The following commit(s) were added to refs/heads/main by this push:
new c14bcdda6 [CALCITE-5804] Upgrade jackson
zabetak closed pull request #223: [CALCITE-5804] Bump jackson versions to 2.15.2
URL: https://github.com/apache/calcite-avatica/pull/223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chucheng92 commented on PR #3307:
URL: https://github.com/apache/calcite/pull/3307#issuecomment-1632101552
@tanclary @olivrlee hi, I have addressed the problems and rebased
calcite-main, PTAL. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
sonarcloud[bot] commented on PR #3307:
URL: https://github.com/apache/calcite/pull/3307#issuecomment-1631946148
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
28 matches
Mail list logo