[GitHub] [calcite] sonarcloud[bot] commented on pull request #3323: [CALCITE-5859] Calcite crashes at compilation time when evaluating LEFT(NULL, n) expression

2023-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #3323: URL: https://github.com/apache/calcite/pull/3323#issuecomment-1641391579 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zoudan commented on pull request #3234: [CALCITE-5735] Add SAFE_MULTIPLY function (enabled in BigQuery)

2023-07-18 Thread via GitHub
zoudan commented on PR #3234: URL: https://github.com/apache/calcite/pull/3234#issuecomment-1641283240 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3316: [CALCITE-5837] Make RexUtil#pullFactors method RexNode condition ordered when input RexNode's kind is OR

2023-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #3316: URL: https://github.com/apache/calcite/pull/3316#issuecomment-1640930433 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3316: [CALCITE-5837] Make RexUtil#pullFactors method RexNode condition ordered when input RexNode's kind is OR

2023-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #3316: URL: https://github.com/apache/calcite/pull/3316#issuecomment-1640918132 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

2023-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #3303: URL: https://github.com/apache/calcite/pull/3303#issuecomment-1640633656 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3147: [CALCITE-5644] Implement BigQuery CONTAINS_SUBSTR

2023-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #3147: URL: https://github.com/apache/calcite/pull/3147#issuecomment-1640488189 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] LakeShen commented on a diff in pull request #3316: [CALCITE-5837] Make RexUtil#pullFactors method RexNode condition ordered when input RexNode's kind is OR

2023-07-18 Thread via GitHub
LakeShen commented on code in PR #3316: URL: https://github.com/apache/calcite/pull/3316#discussion_r1266972865 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -801,6 +804,17 @@ private void checkExponentialCnf(int n) { and(eRef,

[GitHub] [calcite] tanclary commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

2023-07-18 Thread via GitHub
tanclary commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1266940303 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6618,6 +6618,60 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] herunkang2018 commented on a diff in pull request #3303: [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in BigQuery l…

2023-07-18 Thread via GitHub
herunkang2018 commented on code in PR #3303: URL: https://github.com/apache/calcite/pull/3303#discussion_r1266747875 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6618,6 +6618,60 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3322: Remove mentions of binary distribution from README

2023-07-18 Thread via GitHub
sonarcloud[bot] commented on PR #3322: URL: https://github.com/apache/calcite/pull/3322#issuecomment-1640052096 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zabetak opened a new pull request, #3322: Remove mentions of binary distribution from README

2023-07-18 Thread via GitHub
zabetak opened a new pull request, #3322: URL: https://github.com/apache/calcite/pull/3322 The project does not make binary releases at the moment so mentioning binary distribution in the README is misleading. -- This is an automated message from the Apache Git Service. To respond to the