LakeShen commented on PR #3354:
URL: https://github.com/apache/calcite/pull/3354#issuecomment-1670714582
I will reopen this pr later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
zoudan commented on code in PR #3319:
URL: https://github.com/apache/calcite/pull/3319#discussion_r1287871695
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -815,6 +815,39 @@ public static int bitLength(ByteString s) {
return s.length() * 8;
}
chucheng92 commented on PR #3348:
URL: https://github.com/apache/calcite/pull/3348#issuecomment-1670558746
hi @tanclary could you also help review? it's same like a previous
`soundex_spark` function.
--
This is an automated message from the Apache Git Service.
To respond to the
LakeShen closed pull request #3354: [CALCITE-5904] The result should be empty
when table sample rate is 0
URL: https://github.com/apache/calcite/pull/3354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
JiajunBernoulli commented on code in PR #3289:
URL: https://github.com/apache/calcite/pull/3289#discussion_r1287839577
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -224,6 +224,62 @@ private static boolean skipItem(RexNode expr) {
&&
This is an automated email from the ASF dual-hosted git repository.
tanner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit fde98e3504a26e727b21e99eaeb1a45a132e5b0a
Author: Tanner Clary
AuthorDate: Tue Jul 25 14:04:25 2023 -0700
[MINOR]
tanclary merged PR #3336:
URL: https://github.com/apache/calcite/pull/3336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
tanner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
commit 95c4acc3cccdc66a3fd39a41250cb0d7f86c56ee
Author: Tanner Clary
AuthorDate: Sun Jul 23 19:37:29 2023 -0700
This is an automated email from the ASF dual-hosted git repository.
tanner pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
from 25f326cf0a [CALCITE-5827] Add IS_INF and IS_NAN functions (enabled in
BigQuery library)
new 95c4acc3cc
sonarcloud[bot] commented on PR #3336:
URL: https://github.com/apache/calcite/pull/3336#issuecomment-1670369096
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
julianhyde commented on code in PR #3147:
URL: https://github.com/apache/calcite/pull/3147#discussion_r1287715037
##
core/src/main/java/org/apache/calcite/sql/fun/SqlContainsSubstrFunction.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
sonarcloud[bot] commented on PR #3359:
URL: https://github.com/apache/calcite/pull/3359#issuecomment-1670247326
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3358:
URL: https://github.com/apache/calcite/pull/3358#issuecomment-1669897370
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3357:
URL: https://github.com/apache/calcite/pull/3357#issuecomment-1669815758
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
LakeShen opened a new pull request, #3357:
URL: https://github.com/apache/calcite/pull/3357
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
This is an automated email from the ASF dual-hosted git repository.
tanner pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 25f326cf0a [CALCITE-5827] Add IS_INF and IS_NAN
tanclary merged PR #3303:
URL: https://github.com/apache/calcite/pull/3303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3303:
URL: https://github.com/apache/calcite/pull/3303#issuecomment-1669698581
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
This is an automated email from the ASF dual-hosted git repository.
rubenql pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 0cea91b842 [CALCITE-5903] RelMdCollation does not
rubenada merged PR #3353:
URL: https://github.com/apache/calcite/pull/3353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
JiajunBernoulli commented on PR #3353:
URL: https://github.com/apache/calcite/pull/3353#issuecomment-1669596949
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ronitmagar2000 closed pull request #3356: Ronit.magar/raven etl/adding
abbreviated uppercase month format in sql date time format
URL: https://github.com/apache/calcite/pull/3356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ronitmagar2000 opened a new pull request, #3356:
URL: https://github.com/apache/calcite/pull/3356
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
JingDas commented on code in PR #3345:
URL: https://github.com/apache/calcite/pull/3345#discussion_r1287047481
##
core/src/main/java/org/apache/calcite/plan/RelOptForeignKey.java:
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
JingDas commented on code in PR #3345:
URL: https://github.com/apache/calcite/pull/3345#discussion_r1287040271
##
core/src/main/java/org/apache/calcite/rel/metadata/BuiltInMetadata.java:
##
@@ -105,6 +106,43 @@ interface Handler extends MetadataHandler {
}
}
+ /**
+
JingDas commented on code in PR #3345:
URL: https://github.com/apache/calcite/pull/3345#discussion_r1287036866
##
core/src/main/java/org/apache/calcite/plan/RelOptForeignKey.java:
##
@@ -0,0 +1,411 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
sonarcloud[bot] commented on PR #:
URL: https://github.com/apache/calcite/pull/#issuecomment-1669215507
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #:
URL: https://github.com/apache/calcite/pull/#issuecomment-1669197204
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
rubenada commented on PR #3314:
URL: https://github.com/apache/calcite/pull/3314#issuecomment-1669195183
Thanks @mihaibudiu , IMO the PR looks in a good shape.
I'll merge it in the next days if no other remarks appear.
BTW, as a general note, it's not a big deal but usually we
sonarcloud[bot] commented on PR #:
URL: https://github.com/apache/calcite/pull/#issuecomment-1669171032
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
herunkang2018 commented on PR #3303:
URL: https://github.com/apache/calcite/pull/3303#issuecomment-1668981170
@tanclary LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
herunkang2018 commented on PR #3303:
URL: https://github.com/apache/calcite/pull/3303#issuecomment-1668980787
@tanclary I checked that decimal type does not support NaN and Infinite, so
the comment will be resolved and we can continue.
--
This is an automated message from the Apache Git
32 matches
Mail list logo