[GitHub] [calcite] sonarcloud[bot] commented on pull request #3405: [CALCITE-5961] Type inference of ARRAY_COMPACT is incorrect

sonarcloud[bot] commented on PR #3405: URL: https://github.com/apache/calcite/pull/3405#issuecomment-1702183325 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3405: [CALCITE-5961] Type inference of ARRAY_COMPACT is incorrect

chucheng92 commented on code in PR #3405: URL: https://github.com/apache/calcite/pull/3405#discussion_r1312463704 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5885,7 +5885,9 @@ private static void checkIf(SqlOperatorFixture f) { final

[GitHub] [calcite] olivrlee commented on a diff in pull request #3391: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

olivrlee commented on code in PR #3391: URL: https://github.com/apache/calcite/pull/3391#discussion_r1312548850 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -7385,8 +7385,8 @@ private static void checkIf(SqlOperatorFixture f) { @Test void

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3399: [CALCITE-5962] Support parse Spark-style syntax LEFT ANTI JOIN in Babel parser

sonarcloud[bot] commented on PR #3399: URL: https://github.com/apache/calcite/pull/3399#issuecomment-1702136712 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3405: [CALCITE-5961] Type inference of ARRAY_COMPACT is incorrect

chucheng92 commented on code in PR #3405: URL: https://github.com/apache/calcite/pull/3405#discussion_r1312463704 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5885,7 +5885,9 @@ private static void checkIf(SqlOperatorFixture f) { final

[GitHub] [calcite] JiajunBernoulli commented on pull request #3382: [CALCITE-5944] RelMdRowCount can return more accurate rowCount for Sample

JiajunBernoulli commented on PR #3382: URL: https://github.com/apache/calcite/pull/3382#issuecomment-1702021370 @rubenada , would you please review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] JiajunBernoulli closed pull request #3283: [CALCITE-5805] SqlValidatorImpl throws AssertionError while validatin…

JiajunBernoulli closed pull request #3283: [CALCITE-5805] SqlValidatorImpl throws AssertionError while validatin… URL: https://github.com/apache/calcite/pull/3283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] chucheng92 commented on a diff in pull request #3405: [CALCITE-5961] Type inference of ARRAY_COMPACT is incorrect

chucheng92 commented on code in PR #3405: URL: https://github.com/apache/calcite/pull/3405#discussion_r1312463704 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5885,7 +5885,9 @@ private static void checkIf(SqlOperatorFixture f) { final

[GitHub] [calcite] NobiGo commented on a diff in pull request #3405: [CALCITE-5961] Type inference of ARRAY_COMPACT is incorrect

NobiGo commented on code in PR #3405: URL: https://github.com/apache/calcite/pull/3405#discussion_r1312440471 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5885,7 +5885,9 @@ private static void checkIf(SqlOperatorFixture f) { final

[GitHub] [calcite] NobiGo commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

NobiGo commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1312426914 ## core/src/test/java/org/apache/calcite/test/JdbcTest.java: ## @@ -3773,6 +3774,35 @@ public void checkOrderBy(final boolean desc, "empid=110;

[calcite] branch main updated: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new ada4fe2715 [CALCITE-5911] Add REGEXP_EXTRACT_ALL

[GitHub] [calcite] tanclary merged pull request #3387: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

tanclary merged PR #3387: URL: https://github.com/apache/calcite/pull/3387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3387: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

sonarcloud[bot] commented on PR #3387: URL: https://github.com/apache/calcite/pull/3387#issuecomment-1701561915 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] Anthrino commented on a diff in pull request #3387: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

Anthrino commented on code in PR #3387: URL: https://github.com/apache/calcite/pull/3387#discussion_r1312041006 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4675,6 +4675,29 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311961669 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -2699,6 +2699,33 @@ private void

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311953152 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -2699,6 +2699,33 @@ private void

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311953152 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -2699,6 +2699,33 @@ private void

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311949697 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -2699,6 +2699,35 @@ private void

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311942668 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311937062 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311934566 ## core/src/test/java/org/apache/calcite/test/JdbcTest.java: ## @@ -3773,6 +3774,35 @@ public void checkOrderBy(final boolean desc, "empid=110;

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311933809 ## core/src/test/java/org/apache/calcite/test/JdbcTest.java: ## @@ -3773,6 +3774,35 @@ public void checkOrderBy(final boolean desc, "empid=110;

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311931518 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311890061 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311895577 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311891801 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311891801 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311890731 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311890061 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311885728 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311847209 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3391: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

sonarcloud[bot] commented on PR #3391: URL: https://github.com/apache/calcite/pull/3391#issuecomment-1701327621 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] asolimando commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

asolimando commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311847209 ## core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

sonarcloud[bot] commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1701296826 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] tanclary commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

tanclary commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1701291551 > Hi @tanclary @NobiGo ,I have already added the e2e test for my rule,if you have time, please help me to review again, thank you very much:) I think this looks good but I am less

[GitHub] [calcite] LakeShen commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

LakeShen commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1701286622 Hi @tanclary @NobiGo ,I have already added the e2e test for my rule,if you have time, please help me to review again, thank you very much:) -- This is an automated message from the

[GitHub] [calcite] LakeShen commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

LakeShen commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311832848 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -2699,6 +2699,35 @@ private void

[GitHub] [calcite] tanclary commented on a diff in pull request #3395: [CALCITE-5948] Explicit casting should be made if the type of an element in ARRAY/MAP not equals with the derived component type

tanclary commented on code in PR #3395: URL: https://github.com/apache/calcite/pull/3395#discussion_r1311824276 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java: ## @@ -1309,6 +1311,64 @@ public static boolean isMeasure(SqlNode selectItem) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3405: [CALCITE-5961] Type inference of ARRAY_COMPACT is incorrect

sonarcloud[bot] commented on PR #3405: URL: https://github.com/apache/calcite/pull/3405#issuecomment-1701176858 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3381: [CALCITE-5939] Support for rewriting different join types in UnifyRule

sonarcloud[bot] commented on PR #3381: URL: https://github.com/apache/calcite/pull/3381#issuecomment-1701001311 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

sonarcloud[bot] commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1700976207 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3405: [CALCITE-5961] Type inference of ARRAY_COMPACT is incorrect

sonarcloud[bot] commented on PR #3405: URL: https://github.com/apache/calcite/pull/3405#issuecomment-1700971750 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] LakeShen commented on a diff in pull request #3396: [CALCITE-5940] Add the Rules to optimize Limit

LakeShen commented on code in PR #3396: URL: https://github.com/apache/calcite/pull/3396#discussion_r1311555648 ## core/src/main/java/org/apache/calcite/rel/rules/SortMergeRule.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [calcite] ILuffZhe commented on a diff in pull request #3387: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

ILuffZhe commented on code in PR #3387: URL: https://github.com/apache/calcite/pull/3387#discussion_r1311531357 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4675,6 +4675,29 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] LakeShen commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

LakeShen commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1311499852 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -2699,6 +2699,35 @@ private void

[GitHub] [calcite] jiefei30 commented on pull request #3399: [CALCITE-5962] Support parse Spark-style syntax LEFT ANTI JOIN in Babel parser

jiefei30 commented on PR #3399: URL: https://github.com/apache/calcite/pull/3399#issuecomment-1700836979 > Hi @jiefei30, I think you should consider this PR[#3291], LEFT ANTI JOIN should not refer right-hand table. @macroguo-ghy ok, thanks for your suggestion, I'll check it --

[GitHub] [calcite] macroguo-ghy commented on pull request #3399: [CALCITE-5962] Support parse Spark-style syntax LEFT ANTI JOIN in Babel parser

macroguo-ghy commented on PR #3399: URL: https://github.com/apache/calcite/pull/3399#issuecomment-1700738206 Hi @jiefei30, I think you should consider this PR[https://github.com/apache/calcite/pull/3291], LEFT ANTI JOIN should not refer right-hand table. -- This is an automated message

[calcite] branch main updated: [CALCITE-5965] Avoid unnecessary String concatenations in the RexFieldAccess constructor to improve the performance

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 267d633165 [CALCITE-5965] Avoid unnecessary

[GitHub] [calcite] rubenada merged pull request #3401: [CALCITE-5965] Avoid unnecessary String concatenations in the RexFieldAccess constructor to improve the performance

rubenada merged PR #3401: URL: https://github.com/apache/calcite/pull/3401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3401: [CALCITE-5965] Avoid unnecessary String concatenations in the RexFieldAccess constructor to improve the performance

sonarcloud[bot] commented on PR #3401: URL: https://github.com/apache/calcite/pull/3401#issuecomment-1700683135 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zstan commented on pull request #3393: [CALCITE-5950] Default column constraint is erroneously processed

zstan commented on PR #3393: URL: https://github.com/apache/calcite/pull/3393#issuecomment-1700642138 @julianhyde thanks for review, all done, i don`t know the reason of 1 erroneous check here. -- This is an automated message from the Apache Git Service. To respond to the message, please