Re: [PR] [CALCITE-5387] Type-mismatch on nullability in JoinPushTransitivePredicatesRule RelRule [calcite]

ian-bertolacci commented on code in PR #3452: URL: https://github.com/apache/calcite/pull/3452#discussion_r1350768855 ## core/src/main/java/org/apache/calcite/rel/metadata/RelMdPredicates.java: ## @@ -666,6 +666,29 @@ static class JoinConditionBasedPredicateInference {

Re: [PR] [CALCITE-6037] The function category of ARRAY/EXTRACT_VALUE/XML_TRANSFORM/EXTRACT_XML/EXISTSNODE is incorrect (Spark/MySQL/Oracle Library) [calcite]

chucheng92 commented on code in PR #3458: URL: https://github.com/apache/calcite/pull/3458#discussion_r1350418693 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -532,26 +532,30 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding

Re: [PR] [CALCITE-5948] Use explicit casting if element type in ARRAY/MAP does not equal derived component type [calcite]

chucheng92 commented on code in PR #3395: URL: https://github.com/apache/calcite/pull/3395#discussion_r1350517693 ## core/src/test/java/org/apache/calcite/test/JdbcTest.java: ## @@ -8144,10 +8144,9 @@ private void checkGetTimestamp(Connection con) throws SQLException { *

Re: [PR] [CALCITE-6037] The function category of ARRAY/EXTRACT_VALUE/XML_TRANSFORM/EXTRACT_XML/EXISTSNODE is incorrect (Spark/MySQL/Oracle Library) [calcite]

LakeShen commented on code in PR #3458: URL: https://github.com/apache/calcite/pull/3458#discussion_r1350493820 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1075,7 +1079,8 @@ private static RelDataType arrayReturnType(SqlOperatorBinding

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

LakeShen commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1350491085 ## core/src/main/java/org/apache/calcite/rel/rules/FilterWindowTransposeRule.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

zabetak commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1350460404 ## core/src/main/java/org/apache/calcite/rel/rules/FilterWindowTransposeRule.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[calcite] branch main updated: [CALCITE-5948] Use explicit casting if element type in ARRAY/MAP does not equal derived component type

This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 342cf606ac [CALCITE-5948] Use explicit casting if

Re: [PR] [CALCITE-5948] Use explicit casting if element type in ARRAY/MAP does not equal derived component type [calcite]

tanclary merged PR #3395: URL: https://github.com/apache/calcite/pull/3395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

zabetak commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1350459092 ## core/src/main/java/org/apache/calcite/rel/rules/FilterWindowTransposeRule.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [CALCITE-6031] Add the planner rule that pushes the Filter past a Sample [calcite]

sonarcloud[bot] commented on PR #3453: URL: https://github.com/apache/calcite/pull/3453#issuecomment-1753204046 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

LakeShen commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1350441530 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -920,6 +920,67 @@ private void checkJoinToMultiJoinDoesNotMatchSemiOrAntiJoin(JoinRelType

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

LakeShen commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1350440243 ## core/src/test/java/org/apache/calcite/test/JdbcTest.java: ## @@ -4798,6 +4798,28 @@ private void startOfGroupStep3(String startOfGroup) { "deptno=20;

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

LakeShen commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1350438826 ## core/src/main/java/org/apache/calcite/rel/rules/FilterWindowTransposeRule.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [CALCITE-6037] The function category of ARRAY/EXTRACT_VALUE/XML_TRANSFORM/EXTRACT_XML/EXISTSNODE is incorrect (Spark/MySQL/Oracle Library) [calcite]

chucheng92 commented on code in PR #3458: URL: https://github.com/apache/calcite/pull/3458#discussion_r1350418693 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -532,26 +532,30 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding

Re: [PR] [CALCITE-6037] The function category of ARRAY/EXTRACT_VALUE/XML_TRANSFORM/EXTRACT_XML/EXISTSNODE is incorrect (Spark/MySQL/Oracle Library) [calcite]

chucheng92 commented on code in PR #3458: URL: https://github.com/apache/calcite/pull/3458#discussion_r1350418693 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -532,26 +532,30 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding

Re: [PR] [CALCITE-6037] The function category of ARRAY/EXTRACT_VALUE/XML_TRANSFORM/EXTRACT_XML/EXISTSNODE is incorrect (Spark/MySQL/Oracle Library) [calcite]

chucheng92 commented on code in PR #3458: URL: https://github.com/apache/calcite/pull/3458#discussion_r1350418693 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -532,26 +532,30 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding

Re: [PR] [CALCITE-6037] The function category of ARRAY/EXTRACT_VALUE/XML_TRANSFORM/EXTRACT_XML/EXISTSNODE is incorrect (Spark/MySQL/Oracle Library) [calcite]

chucheng92 commented on code in PR #3458: URL: https://github.com/apache/calcite/pull/3458#discussion_r1350418693 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -532,26 +532,30 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding

Re: [PR] [CALCITE-6037] The function category of ARRAY/EXTRACT_VALUE/XML_TRANSFORM/EXTRACT_XML/EXISTSNODE is incorrect (Spark/MySQL/Oracle Library) [calcite]

chucheng92 commented on code in PR #3458: URL: https://github.com/apache/calcite/pull/3458#discussion_r1350418693 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -532,26 +532,30 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

LakeShen commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1350412897 ## core/src/main/java/org/apache/calcite/rel/rules/FilterWindowTransposeRule.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [CALCITE-6031] Add the planner rule that pushes the Filter past a Sample [calcite]

LakeShen commented on PR #3453: URL: https://github.com/apache/calcite/pull/3453#issuecomment-1753148998 Hi @libenchao ,Thank you for your review suggestions. I have modified according to the suggestions. If you have time, please help me review it again. -- This is an automated message

Re: [PR] [CALCITE-6031] Add the planner rule that pushes the Filter past a Sample [calcite]

LakeShen commented on code in PR #3453: URL: https://github.com/apache/calcite/pull/3453#discussion_r1350391764 ## core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java: ## @@ -279,6 +279,10 @@ private CoreRules() {} public static final FilterProjectTransposeRule

Re: [PR] [CALCITE-6037] The function category of ARRAY/EXTRACT_VALUE/XML_TRANSFORM/EXTRACT_XML/EXISTSNODE is incorrect (Spark/MySQL/Oracle Library) [calcite]

mihaibudiu commented on code in PR #3458: URL: https://github.com/apache/calcite/pull/3458#discussion_r1350375131 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -532,26 +532,30 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding

Re: [PR] [CALCITE-6031] Add the planner rule that pushes the Filter past a Sample [calcite]

libenchao commented on code in PR #3453: URL: https://github.com/apache/calcite/pull/3453#discussion_r1350183091 ## core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java: ## @@ -279,6 +279,10 @@ private CoreRules() {} public static final FilterProjectTransposeRule

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

zabetak commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1350180602 ## core/src/test/java/org/apache/calcite/test/JdbcTest.java: ## @@ -4798,6 +4798,28 @@ private void startOfGroupStep3(String startOfGroup) { "deptno=20;

[calcite-site] branch main updated: Website deployed from calcite@597b53dbb075ab72700d40f66db81d2ac9c182b8

This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new 846bf5463 Website deployed from

[calcite] branch site updated: Site: Add Apache Wayang (incubating) to powered-by page

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new d0156c2050 Site: Add Apache Wayang

Re: [PR] Update powered_by.md [calcite]

libenchao closed pull request #3450: Update powered_by.md URL: https://github.com/apache/calcite/pull/3450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[calcite] branch main updated: Site: Add Apache Wayang (incubating) to powered-by page

This is an automated email from the ASF dual-hosted git repository. libenchao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 597b53dbb0 Site: Add Apache Wayang (incubating)

Re: [PR] [CALCITE-6022] Support "CREATE TABLE LIKE" DDL [calcite]

macroguo-ghy commented on code in PR #3442: URL: https://github.com/apache/calcite/pull/3442#discussion_r1350142769 ## core/src/main/codegen/templates/Parser.jj: ## @@ -4318,8 +4318,13 @@ SqlCreate SqlCreate() : ( <#-- additional literal parser methods are included here

Re: [PR] [CALCITE-6022] Support "CREATE TABLE LIKE" DDL [calcite]

macroguo-ghy commented on code in PR #3442: URL: https://github.com/apache/calcite/pull/3442#discussion_r1350142769 ## core/src/main/codegen/templates/Parser.jj: ## @@ -4318,8 +4318,13 @@ SqlCreate SqlCreate() : ( <#-- additional literal parser methods are included here

Re: [PR] [CALCITE-6022] Support "CREATE TABLE LIKE" DDL [calcite]

macroguo-ghy commented on code in PR #3442: URL: https://github.com/apache/calcite/pull/3442#discussion_r1350142769 ## core/src/main/codegen/templates/Parser.jj: ## @@ -4318,8 +4318,13 @@ SqlCreate SqlCreate() : ( <#-- additional literal parser methods are included here

Re: [PR] [CALCITE-6006] RelToSqlConverter loses charset information [calcite]

JiajunBernoulli commented on code in PR #3429: URL: https://github.com/apache/calcite/pull/3429#discussion_r1350124985 ## core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java: ## @@ -1409,8 +1411,20 @@ public static SqlNode toSql(RexLiteral literal) {

Re: [PR] [CALCITE-6022] Support "CREATE TABLE LIKE" DDL [calcite]

JiajunBernoulli commented on code in PR #3442: URL: https://github.com/apache/calcite/pull/3442#discussion_r1350090364 ## core/src/main/codegen/templates/Parser.jj: ## @@ -4318,8 +4318,13 @@ SqlCreate SqlCreate() : ( <#-- additional literal parser methods are included

Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]

rubenada commented on code in PR #3390: URL: https://github.com/apache/calcite/pull/3390#discussion_r1349920250 ## core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java: ## @@ -378,4 +378,28 @@ public void run() { interface Action { void check(RexBuilder

[calcite-site] branch main updated: Website deployed from calcite@0291e1eeb4c5e01dccbac14e1a6eeeb79d87282b

This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new 7a6f87dce Website deployed from

[calcite] branch site updated: [CALCITE-6033] Correct broken links on adapter page

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new e3e71d77ce [CALCITE-6033] Correct broken links

[calcite] branch main updated: [CALCITE-6033] Correct broken links on adapter page

This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 0291e1eeb4 [CALCITE-6033] Correct broken links on

Re: [PR] [CALCITE-6033] Correct broken links on adapter page [calcite]

rubenada merged PR #3456: URL: https://github.com/apache/calcite/pull/3456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6031] Add the planner rule that pushes the Filter past a Sample [calcite]

chucheng92 commented on PR #3453: URL: https://github.com/apache/calcite/pull/3453#issuecomment-1752419781 hi, @LakeShen thanks for the PR. LGTM. See if others have other opinions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CALCITE-6037] The function category of ARRAY/EXTRACT_VALUE/XML_TRANSFORM/EXTRACT_XML/EXISTSNODE is incorrect (Spark/MySQL/Oracle Library) [calcite]

chucheng92 commented on code in PR #3458: URL: https://github.com/apache/calcite/pull/3458#discussion_r1349538846 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -532,26 +532,30 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding