Re: [PR] [CALCITE-6077] Add FACTORIAL function (enabled in Hive and Spark libraries) [calcite]

2023-10-27 Thread via GitHub
sonarcloud[bot] commented on PR #3490: URL: https://github.com/apache/calcite/pull/3490#issuecomment-1783694245 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[PR] [CALCITE-6077] Add FACTORIAL function (enabled in Hive and Spark libraries) [calcite]

2023-10-27 Thread via GitHub
herunkang2018 opened a new pull request, #3490: URL: https://github.com/apache/calcite/pull/3490 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CALCITE-6066] Add HYPOT function (enabled in Spark library) [calcite]

2023-10-27 Thread via GitHub
sonarcloud[bot] commented on PR #3489: URL: https://github.com/apache/calcite/pull/3489#issuecomment-1783674169 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-6066] Add HYPOT function (enabled in Spark library) [calcite]

2023-10-27 Thread via GitHub
sonarcloud[bot] commented on PR #3489: URL: https://github.com/apache/calcite/pull/3489#issuecomment-1783672363 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
julianhyde commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1375148442 ## core/src/main/java/org/apache/calcite/plan/RelOptUtil.java: ## @@ -3304,6 +3304,29 @@ public static RelNode createProject(RelNode child, Mappings.TargetMapping

[PR] [CALCITE-6066] Add HYPOT function (enabled in Spark library) [calcite]

2023-10-27 Thread via GitHub
herunkang2018 opened a new pull request, #3489: URL: https://github.com/apache/calcite/pull/3489 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
julianhyde commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1375145871 ## core/src/main/java/org/apache/calcite/sql/SqlWithItem.java: ## @@ -30,13 +30,26 @@ public class SqlWithItem extends SqlCall { public SqlIdentifier name;

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
julianhyde commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1375147643 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -2759,6 +2769,13 @@ protected void convertUnpivot(Blackboard bb, SqlUnpivot unpivot)

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
julianhyde commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1375146709 ## core/src/main/java/org/apache/calcite/sql/validate/SqlWithItemTableRef.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
julianhyde commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1375146021 ## core/src/main/java/org/apache/calcite/sql/validate/WithItemRecursiveNameSpace.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
julianhyde commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1375145871 ## core/src/main/java/org/apache/calcite/sql/SqlWithItem.java: ## @@ -30,13 +30,26 @@ public class SqlWithItem extends SqlCall { public SqlIdentifier name;

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
sonarcloud[bot] commented on PR #3480: URL: https://github.com/apache/calcite/pull/3480#issuecomment-1783629738 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-6024] ListSqlOperatorTable is inefficient [calcite]

2023-10-27 Thread via GitHub
asfgit closed pull request #3483: [CALCITE-6024] ListSqlOperatorTable is inefficient URL: https://github.com/apache/calcite/pull/3483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(calcite) branch main updated: [CALCITE-6024] A more efficient implementation of SqlOperatorTable, backed by an immutable multi-map keyed by upper-case operator name

2023-10-27 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 7b9660f150 [CALCITE-6024] A more efficient

Re: [PR] [CALCITE-6024] ListSqlOperatorTable is inefficient [calcite]

2023-10-27 Thread via GitHub
sonarcloud[bot] commented on PR #3483: URL: https://github.com/apache/calcite/pull/3483#issuecomment-1783463297 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-6024] ListSqlOperatorTable is inefficient [calcite]

2023-10-27 Thread via GitHub
julianhyde commented on code in PR #3483: URL: https://github.com/apache/calcite/pull/3483#discussion_r1374979580 ## core/src/main/java/org/apache/calcite/sql/fun/OracleSqlOperatorTable.java: ## @@ -65,15 +69,6 @@ public class OracleSqlOperatorTable extends

Re: [PR] [CALCITE-6024] ListSqlOperatorTable is inefficient [calcite]

2023-10-27 Thread via GitHub
julianhyde commented on code in PR #3483: URL: https://github.com/apache/calcite/pull/3483#discussion_r1374979115 ## core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java: ## @@ -1364,6 +1368,7 @@ public class SqlStdOperatorTable extends

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-27 Thread via GitHub
sonarcloud[bot] commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1783347368 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
mihaibudiu commented on PR #3480: URL: https://github.com/apache/calcite/pull/3480#issuecomment-1783319871 I will need more time to review this, but if you want to get it merged for 1.36 you can go ahead. I will file issues later if I find problems. -- This is an automated message from

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-27 Thread via GitHub
mihaibudiu commented on code in PR #3481: URL: https://github.com/apache/calcite/pull/3481#discussion_r1374903605 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -624,7 +624,7 @@ void testCastExactNumericLimits(CastType castType, SqlOperatorFixture

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-27 Thread via GitHub
mihaibudiu commented on code in PR #3481: URL: https://github.com/apache/calcite/pull/3481#discussion_r1374867823 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -624,7 +624,7 @@ void testCastExactNumericLimits(CastType castType, SqlOperatorFixture

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
HanumathRao commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1374840761 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -3099,9 +3100,23 @@ private void registerSetop( // A setop is in the same

Re: [PR] [CALCITE-5918] Add MAP function (enabled in Spark library) [calcite]

2023-10-27 Thread via GitHub
tanclary merged PR #3459: URL: https://github.com/apache/calcite/pull/3459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(calcite) branch main updated: [CALCITE-5918] Add MAP function (enabled in Spark library)

2023-10-27 Thread tanner
This is an automated email from the ASF dual-hosted git repository. tanner pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new b11f179cba [CALCITE-5918] Add MAP function

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
rubenada commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1374746714 ## core/src/main/resources/org/apache/calcite/runtime/CalciteResource.properties: ## @@ -63,6 +63,8 @@ IncompatibleValueType=Values passed to {0} operator must have

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
macroguo-ghy commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1374651769 ## core/src/main/java/org/apache/calcite/sql/SqlWith.java: ## @@ -96,6 +96,10 @@ private SqlWithOperator() { final SqlWith with = (SqlWith) call;

Re: [PR] [CALCITE-6024] ListSqlOperatorTable is inefficient [calcite]

2023-10-27 Thread via GitHub
libenchao commented on code in PR #3483: URL: https://github.com/apache/calcite/pull/3483#discussion_r1374639698 ## core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java: ## @@ -1364,6 +1368,7 @@ public class SqlStdOperatorTable extends

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
sonarcloud[bot] commented on PR #3480: URL: https://github.com/apache/calcite/pull/3480#issuecomment-1782793672 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
HanumathRao commented on PR #3480: URL: https://github.com/apache/calcite/pull/3480#issuecomment-1782758993 Thanks @zabetak and @rubenada for the review, I addressed the review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [CALCITE-129] Support recursive WITH queries [calcite]

2023-10-27 Thread via GitHub
HanumathRao commented on code in PR #3480: URL: https://github.com/apache/calcite/pull/3480#discussion_r1374440499 ## core/src/main/resources/org/apache/calcite/runtime/CalciteResource.properties: ## @@ -63,6 +63,8 @@ IncompatibleValueType=Values passed to {0} operator must

(calcite) branch main updated: [CALCITE-5825] Add URL_ENCODE and URL_DECODE function (enabled in Spark library)

2023-10-27 Thread jiajunxie
This is an automated email from the ASF dual-hosted git repository. jiajunxie pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new ad2e843c5d [CALCITE-5825] Add URL_ENCODE and

Re: [PR] [CALCITE-5825] Add URL_ENCODE and URL_DECODE function (enabled in Spark library) [calcite]

2023-10-27 Thread via GitHub
JiajunBernoulli merged PR #3318: URL: https://github.com/apache/calcite/pull/3318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

2023-10-27 Thread via GitHub
zabetak commented on code in PR #3439: URL: https://github.com/apache/calcite/pull/3439#discussion_r1374361924 ## core/src/main/java/org/apache/calcite/plan/RelOptUtil.java: ## @@ -3817,6 +3817,29 @@ public static RelNode pushDownJoinConditions(Join originalJoin,

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

2023-10-27 Thread via GitHub
zabetak closed pull request #3439: [CALCITE-6011] Add the planner rule that pushes the Filter past a Window URL: https://github.com/apache/calcite/pull/3439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(calcite) branch main updated: [CALCITE-6011] Add FilterWindowTransposeRule to push a Filter past a Window

2023-10-27 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new bdafeec27c [CALCITE-6011] Add

Re: [PR] [CALCITE-6011] Add the planner rule that pushes the Filter past a Window [calcite]

2023-10-27 Thread via GitHub
sonarcloud[bot] commented on PR #3439: URL: https://github.com/apache/calcite/pull/3439#issuecomment-1782642412 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

(calcite-site) branch main updated: Website deployed from calcite@ef82a6cc6bc565f6dc596c1d2aca7221fd6cdc49

2023-10-27 Thread asf-ci-deploy
This is an automated email from the ASF dual-hosted git repository. asf-ci-deploy pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-site.git The following commit(s) were added to refs/heads/main by this push: new 5e78ccbfc Website deployed from

(calcite) branch site updated: [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails

2023-10-27 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch site in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/site by this push: new c78b690b97 [CALCITE-6075] Site: Cloning source

Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]

2023-10-27 Thread via GitHub
zabetak closed pull request #3488: [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails URL: https://github.com/apache/calcite/pull/3488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(calcite) branch main updated: [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails

2023-10-27 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new ef82a6cc6b [CALCITE-6075] Site: Cloning source

Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]

2023-10-27 Thread via GitHub
sonarcloud[bot] commented on PR #3488: URL: https://github.com/apache/calcite/pull/3488#issuecomment-1782576054 Please retry analysis of this Pull-Request directly on [SonarCloud](https://sonarcloud.io/project/issues?id=apache_calcite=3488). -- This is an automated message from the

Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]

2023-10-27 Thread via GitHub
sonarcloud[bot] commented on PR #3488: URL: https://github.com/apache/calcite/pull/3488#issuecomment-1782567307 Please retry analysis of this Pull-Request directly on [SonarCloud](https://sonarcloud.io/project/issues?id=apache_calcite=3488). -- This is an automated message from the

Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]

2023-10-27 Thread via GitHub
caicancai commented on PR #3488: URL: https://github.com/apache/calcite/pull/3488#issuecomment-1782527886 > maybe use `git clone https://github.com/apache/calcite.git` is better. I have checked some other apache projects such as apache flink, they use `https` such as > > ``` >

Re: [PR] [CALCITE-6075] Site: Cloning source code from GitHub using git protocol fails [calcite]

2023-10-27 Thread via GitHub
chucheng92 commented on PR #3488: URL: https://github.com/apache/calcite/pull/3488#issuecomment-1782458231 maybe use `git clone https://github.com/apache/calcite.git` is better. I have checked some other apache projects such as apache flink, they use `https` such as ``` git

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-27 Thread via GitHub
rubenada commented on PR #3481: URL: https://github.com/apache/calcite/pull/3481#issuecomment-1782443890 Thanks for the effort improving the tests and going beyond the original scope @mihaibudiu . I have just left one minor comment; other than that lgtm -- This is an automated message

Re: [PR] [CALCITE-5990] Explicit cast to numeric type doesn't check overflow [calcite]

2023-10-27 Thread via GitHub
rubenada commented on code in PR #3481: URL: https://github.com/apache/calcite/pull/3481#discussion_r1374179953 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -624,7 +624,7 @@ void testCastExactNumericLimits(CastType castType, SqlOperatorFixture

Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]

2023-10-27 Thread via GitHub
rubenada commented on PR #3390: URL: https://github.com/apache/calcite/pull/3390#issuecomment-1782417660 Closing this in favor of https://github.com/apache/calcite/pull/3486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]

2023-10-27 Thread via GitHub
rubenada closed pull request #3390: [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails URL: https://github.com/apache/calcite/pull/3390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[calcite] branch main updated: [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails

2023-10-27 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 417a1b53ec [CALCITE-5949] RexExecutable should

Re: [PR] [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails [calcite]

2023-10-27 Thread via GitHub
rubenada merged PR #3486: URL: https://github.com/apache/calcite/pull/3486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-5825] Add URL_ENCODE and URL_DECODE function (enabled in Spark library) [calcite]

2023-10-27 Thread via GitHub
herunkang2018 commented on PR #3318: URL: https://github.com/apache/calcite/pull/3318#issuecomment-1782383132 @JiajunBernoulli Sure, the commit is squashed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL