Re: [PR] [CALCITE-6239] Add a postgis dialect that supports ST functions [calcite]

2024-02-02 Thread via GitHub
YiwenWu commented on code in PR #3668: URL: https://github.com/apache/calcite/pull/3668#discussion_r1476931157 ## core/src/main/java/org/apache/calcite/sql/dialect/PostgisSqlDialect.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] CALCITE-6219 - Always Filter validation [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3662: URL: https://github.com/apache/calcite/pull/3662#issuecomment-1924914603 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] CALCITE-6219 - Always Filter validation [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3662: URL: https://github.com/apache/calcite/pull/3662#issuecomment-1924905900 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6224] Add LOG2 function (enabled in Mysql, Spark library) [calcite]

2024-02-02 Thread via GitHub
caicancai commented on PR #3648: URL: https://github.com/apache/calcite/pull/3648#issuecomment-1924901070 I will fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] CALCITE-6219 - Always Filter validation [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3662: URL: https://github.com/apache/calcite/pull/3662#issuecomment-1924887816 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] CALCITE-6219 - Always Filter validation [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3662: URL: https://github.com/apache/calcite/pull/3662#issuecomment-1924877784 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] [CALCITE-6239] Add a postgis dialect that supports ST functions [calcite]

2024-02-02 Thread via GitHub
bchapuis opened a new pull request, #3668: URL: https://github.com/apache/calcite/pull/3668 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Add a postgis dialect that supports ST functions [calcite]

2024-02-02 Thread via GitHub
bchapuis closed pull request #3667: Add a postgis dialect that supports ST functions URL: https://github.com/apache/calcite/pull/3667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Add a postgis dialect that supports ST functions [calcite]

2024-02-02 Thread via GitHub
bchapuis opened a new pull request, #3667: URL: https://github.com/apache/calcite/pull/3667 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [CALCITE-5647] RelMdPopulationSize should use mq.getRowCount(rel) instead of rel.estimateRowCount(mq) [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3632: URL: https://github.com/apache/calcite/pull/3632#issuecomment-1924835521 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-5647] RelMdPopulationSize should use mq.getRowCount(rel) instead of rel.estimateRowCount(mq) [calcite]

2024-02-02 Thread via GitHub
jduo commented on PR #3632: URL: https://github.com/apache/calcite/pull/3632#issuecomment-1924809312 > @jduo, usually the commit message is the same as Jira subject (more info here: https://calcite.apache.org/develop/#contributing). > > What if we use (for both Jira and commit)

Re: [PR] [CALCITE-2067] RexLiteral cannot represent accurately floating point values, including NaN, Infinity [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3663: URL: https://github.com/apache/calcite/pull/3663#issuecomment-1924646186 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-2067] RexLiteral cannot represent accurately floating point values, including NaN, Infinity [calcite]

2024-02-02 Thread via GitHub
mihaibudiu commented on PR #3663: URL: https://github.com/apache/calcite/pull/3663#issuecomment-1924584002 @rubenada I have added a commented-out breaking change for the next release. Thank you for the reminder. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [CALCITE-6032] Multilevel correlated query is failing in RelDecorrela… [calcite]

2024-02-02 Thread via GitHub
HanumathRao commented on PR #3640: URL: https://github.com/apache/calcite/pull/3640#issuecomment-1924399074 > @HanumathRao I'll try to take a look as soon as I have a bit of time. In the meanwhile, could you please check if your patch also fixes the cases mentioned in

Re: [PR] [CALCITE-6032] Multilevel correlated query is failing in RelDecorrela… [calcite]

2024-02-02 Thread via GitHub
rubenada commented on PR #3640: URL: https://github.com/apache/calcite/pull/3640#issuecomment-1924192157 @HanumathRao I'll try to take a look as soon as I have a bit of time. In the meanwhile, could you please check if your patch also fixes the cases mentioned in CALCITE-5390 ? (also

(calcite) branch main updated: [CALCITE-6234] Add tests on SqlOperatorTest for to_char function

2024-02-02 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 2aabf210dc [CALCITE-6234] Add tests on

Re: [PR] [CALCITE-6234] Add tests on SqlOperatorTest for to_char function [calcite]

2024-02-02 Thread via GitHub
rubenada merged PR #3659: URL: https://github.com/apache/calcite/pull/3659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6032] Multilevel correlated query is failing in RelDecorrela… [calcite]

2024-02-02 Thread via GitHub
HanumathRao commented on PR #3640: URL: https://github.com/apache/calcite/pull/3640#issuecomment-1924164888 @mihaibudiu, Please let me know if you have any further questions or clarifications on these changes. @libenchao and @rubenada, a friendly reminder to review the PR changes.

Re: [PR] [CALCITE-6214] Remove DISTINCT in aggregate function if field is unique [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3641: URL: https://github.com/apache/calcite/pull/3641#issuecomment-1923833598 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6236] EnumerableBatchNestedLoopJoin::estimateRowCount returns wrong value [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3665: URL: https://github.com/apache/calcite/pull/3665#issuecomment-1923710826 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6236] EnumerableBatchNestedLoopJoin::estimateRowCount returns wrong value [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3665: URL: https://github.com/apache/calcite/pull/3665#issuecomment-1923647839 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6236] EnumerableBatchNestedLoopJoin::estimateRowCount returns wrong value [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3665: URL: https://github.com/apache/calcite/pull/3665#issuecomment-1923627869 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] [CALCITE-2040] Create adapter for Apache Arrow [calcite]

2024-02-02 Thread via GitHub
macroguo-ghy opened a new pull request, #3666: URL: https://github.com/apache/calcite/pull/3666 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [CALCITE-2067] RexLiteral cannot represent accurately floating point values, including NaN, Infinity [calcite]

2024-02-02 Thread via GitHub
rubenada commented on PR #3663: URL: https://github.com/apache/calcite/pull/3663#issuecomment-1923545735 bq. This is a breaking change in some respect [...] Just a minor reminder: before the final merge, @mihaibudiu , I think it'd be necessary to include the corresponding comment about

Re: [PR] [CALCITE-6236] EnumerableBatchNestedLoopJoin uses wrong row count for cost calculation [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3661: URL: https://github.com/apache/calcite/pull/3661#issuecomment-1923460518 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6224] Add LOG2 function (enabled in Mysql, Spark library) [calcite]

2024-02-02 Thread via GitHub
caicancai commented on PR #3648: URL: https://github.com/apache/calcite/pull/3648#issuecomment-1923453271 @mihaibudiu @tanclary https://issues.apache.org/jira/browse/CALCITE-6237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CALCITE-6236] EnumerableBatchNestedLoopJoin::estimateRowCount returns wrong value [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3665: URL: https://github.com/apache/calcite/pull/3665#issuecomment-1923450389 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6224] Add LOG2 function (enabled in Mysql, Spark library) [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3648: URL: https://github.com/apache/calcite/pull/3648#issuecomment-1923439078 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6224] Add LOG2 function (enabled in Mysql, Spark library) [calcite]

2024-02-02 Thread via GitHub
caicancai commented on code in PR #3648: URL: https://github.com/apache/calcite/pull/3648#discussion_r1475796619 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6188,6 +6188,67 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-6234] Add tests on SqlOperatorTest for to_char function [calcite]

2024-02-02 Thread via GitHub
sonarcloud[bot] commented on PR #3659: URL: https://github.com/apache/calcite/pull/3659#issuecomment-1923432146 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6224] Add LOG2 function (enabled in Mysql, Spark library) [calcite]

2024-02-02 Thread via GitHub
caicancai commented on code in PR #3648: URL: https://github.com/apache/calcite/pull/3648#discussion_r1475796414 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6188,6 +6188,65 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

[PR] [CALCITE-6236] EnumerableBatchNestedLoopJoin::estimateRowCount returns wrong value [calcite]

2024-02-02 Thread via GitHub
kramerul opened a new pull request, #3665: URL: https://github.com/apache/calcite/pull/3665 This is another approach to fix [CALCITE-6236] using the selectivity of the filter which is inserted on the right side. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [CALCITE-6234] Add tests on SqlOperatorTest for to_char function [calcite]

2024-02-02 Thread via GitHub
caicancai commented on PR #3659: URL: https://github.com/apache/calcite/pull/3659#issuecomment-1923388488 > @caicancai could you please also amend the commit message to have the same? done. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [CALCITE-6234] Add tests on SqlOperatorTest for to_char function [calcite]

2024-02-02 Thread via GitHub
rubenada commented on PR #3659: URL: https://github.com/apache/calcite/pull/3659#issuecomment-1923372029 @caicancai could you please also amend the commit message to have the same? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [CALCITE-5647] Use mq.getRowCount(rel) instead of rel.estimateRowCount(mq) [calcite]

2024-02-02 Thread via GitHub
rubenada commented on PR #3632: URL: https://github.com/apache/calcite/pull/3632#issuecomment-1923356817 @jduo, usually the commit message is the same as Jira subject (more info here: https://calcite.apache.org/develop/#contributing). What if we use (for both Jira and commit)

Re: [PR] [CALCITE-6221] JDBC adapter generates invalid query when the same table is joined multiple times [calcite]

2024-02-02 Thread via GitHub
kramerul commented on code in PR #3664: URL: https://github.com/apache/calcite/pull/3664#discussion_r1475710267 ## core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java: ## @@ -437,11 +437,43 @@ public Result visit(Filter e) { final Result x =