Re: [PR] [CALCITE-6325] Add LOG function (enabled in Mysql library) [calcite]

2024-03-25 Thread via GitHub
caicancai commented on code in PR #3732: URL: https://github.com/apache/calcite/pull/3732#discussion_r1538420221 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6332,6 +6338,53 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-6325] Add LOG function (enabled in Mysql library) [calcite]

2024-03-25 Thread via GitHub
caicancai commented on code in PR #3732: URL: https://github.com/apache/calcite/pull/3732#discussion_r1538388201 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6332,6 +6338,53 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-6325] Add LOG function (enabled in Mysql library) [calcite]

2024-03-25 Thread via GitHub
caicancai commented on code in PR #3732: URL: https://github.com/apache/calcite/pull/3732#discussion_r1538391118 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4127,14 +4130,14 @@ private static class LogicalNotImplementor extends

Re: [PR] [CALCITE-6325] Add LOG function (enabled in Mysql library) [calcite]

2024-03-25 Thread via GitHub
caicancai commented on code in PR #3732: URL: https://github.com/apache/calcite/pull/3732#discussion_r1538391118 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4127,14 +4130,14 @@ private static class LogicalNotImplementor extends

Re: [PR] [CALCITE-6325] Add LOG function (enabled in Mysql library) [calcite]

2024-03-25 Thread via GitHub
caicancai commented on code in PR #3732: URL: https://github.com/apache/calcite/pull/3732#discussion_r1538388201 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6332,6 +6338,53 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-6325] Add LOG function (enabled in Mysql library) [calcite]

2024-03-25 Thread via GitHub
tanclary commented on code in PR #3732: URL: https://github.com/apache/calcite/pull/3732#discussion_r1537851006 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6332,6 +6338,53 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-6325] Add LOG function (enabled in Mysql library) [calcite]

2024-03-25 Thread via GitHub
tanclary commented on code in PR #3732: URL: https://github.com/apache/calcite/pull/3732#discussion_r1537849935 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -4127,14 +4130,14 @@ private static class LogicalNotImplementor extends

Re: [PR] [CALCITE-5869] LEAST_RESTRICTIVE does not use inner type of MEASURE f… [calcite]

2024-03-25 Thread via GitHub
tanclary commented on code in PR #3336: URL: https://github.com/apache/calcite/pull/3336#discussion_r1537841464 ## core/src/main/java/org/apache/calcite/sql/SqlOperator.java: ## @@ -537,6 +538,11 @@ public RelDataType inferReturnType( +

Re: [PR] [CALCITE-6325] Add LOG function (enabled in Mysql library) [calcite]

2024-03-25 Thread via GitHub
sonarcloud[bot] commented on PR #3732: URL: https://github.com/apache/calcite/pull/3732#issuecomment-2017916618 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6300] Function MAP_VALUES/MAP_KEYS gives exception when mapVauleType and mapKeyType not equals map Biggest mapKeytype or mapValueType [calcite]

2024-03-25 Thread via GitHub
caicancai commented on PR #3721: URL: https://github.com/apache/calcite/pull/3721#issuecomment-2017898601 @mihaibudiu If you have time, can you review it for me? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [CALCITE-6325] Add LOG function (enabled in Mysql library) [calcite]

2024-03-25 Thread via GitHub
caicancai commented on code in PR #3732: URL: https://github.com/apache/calcite/pull/3732#discussion_r1537510286 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -6332,6 +6346,66 @@ void checkRegexpExtract(SqlOperatorFixture f0, FunctionAlias

Re: [PR] [CALCITE-6338] RelMdCollation#project can return an incomplete list of collations in the presence of aliasing [calcite]

2024-03-25 Thread via GitHub
rubenada merged PR #3739: URL: https://github.com/apache/calcite/pull/3739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(calcite) branch main updated: [CALCITE-6338] RelMdCollation#project can return an incomplete list of collations in the presence of aliasing

2024-03-25 Thread rubenql
This is an automated email from the ASF dual-hosted git repository. rubenql pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new d5b6b5c01f [CALCITE-6338] RelMdCollation#project

Re: [PR] [CALCITE-5869] LEAST_RESTRICTIVE does not use inner type of MEASURE f… [calcite]

2024-03-25 Thread via GitHub
barrkel commented on code in PR #3336: URL: https://github.com/apache/calcite/pull/3336#discussion_r1537378040 ## core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java: ## @@ -896,6 +900,12 @@ public static boolean canCastFrom( if (toType.equals(fromType)) {

Re: [PR] [CALCITE-5869] LEAST_RESTRICTIVE does not use inner type of MEASURE f… [calcite]

2024-03-25 Thread via GitHub
barrkel commented on code in PR #3336: URL: https://github.com/apache/calcite/pull/3336#discussion_r1537365076 ## core/src/main/java/org/apache/calcite/sql/SqlOperator.java: ## @@ -537,6 +538,11 @@ public RelDataType inferReturnType( +

Re: [PR] [CALCITE-5869] LEAST_RESTRICTIVE does not use inner type of MEASURE f… [calcite]

2024-03-25 Thread via GitHub
barrkel commented on code in PR #3336: URL: https://github.com/apache/calcite/pull/3336#discussion_r1537365076 ## core/src/main/java/org/apache/calcite/sql/SqlOperator.java: ## @@ -537,6 +538,11 @@ public RelDataType inferReturnType( +

Re: [PR] [CALCITE-6339] Replace hashicorp/go-uuid with google/uuid [calcite-avatica-go]

2024-03-25 Thread via GitHub
F21 merged PR #75: URL: https://github.com/apache/calcite-avatica-go/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(calcite-avatica-go) branch main updated (a4daffd -> 6959af3)

2024-03-25 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite-avatica-go.git from a4daffd Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 add 6959af3 [CALCITE-6339]