[GitHub] [calcite] DonnyZone commented on pull request #3203: [CALCITE-5703] Reduce amount of generated runtime code

2023-05-25 Thread via GitHub
DonnyZone commented on PR #3203: URL: https://github.com/apache/calcite/pull/3203#issuecomment-1563744642 > > Sorry for the late reply. I make some tests in my local environment. The optimization for `BinaryExpression` seems to be incorrect. The code after optimization throws compilation

[GitHub] [calcite] DonnyZone commented on pull request #3203: [CALCITE-5703] Reduce amount of generated runtime code

2023-05-23 Thread via GitHub
DonnyZone commented on PR #3203: URL: https://github.com/apache/calcite/pull/3203#issuecomment-1560421437 > @DonnyZone thanks for review, but i still not hear any contradictions against this PR can be merged. If it so - is it possible to merge it ? Sorry for the late reply. I make