[GitHub] [calcite] amaliujia commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-13 Thread GitBox
amaliujia commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439761102 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableTraitsUtils.java ## @@ -148,4 +149,53 @@ private static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
amaliujia commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439609801 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumTraitsUtils.java ## @@ -148,4 +149,52 @@ private static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
amaliujia commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439579435 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumTraitsUtils.java ## @@ -148,4 +149,52 @@ private static boolean

[GitHub] [calcite] amaliujia commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
amaliujia commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439577517 ## File path: core/src/test/java/org/apache/calcite/test/TopDownOptTest.java ## @@ -693,6 +678,37 @@

[GitHub] [calcite] amaliujia commented on a change in pull request #2023: [CALCITE-4057] Implement trait propagation for EnumerableBatchNestedL…

2020-06-12 Thread GitBox
amaliujia commented on a change in pull request #2023: URL: https://github.com/apache/calcite/pull/2023#discussion_r439577088 ## File path: core/src/test/java/org/apache/calcite/test/TopDownOptTest.java ## @@ -483,7 +476,6 @@ Query.create(sql)