[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366263800 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366263800 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366247257 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366215049 ## File path: core/src/main/java/org/apache/calcite/sql/validate/AggregatingSelectScope.java ## @@ -110,8

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366214662 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@ -4488,6 +4488,37 @@ private

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366212096 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-14 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366212096 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366179020 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@ -4488,6 +4488,37 @@ private

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366178730 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -5335,6 +5443,11

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366178638 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366178014 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366177681 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366176531 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366176295 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113

[GitHub] [calcite] vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result

2020-01-13 Thread GitBox
vlsi commented on a change in pull request #1756: [CALCITE-1824] GROUP_ID returns wrong result URL: https://github.com/apache/calcite/pull/1756#discussion_r366174811 ## File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java ## @@ -3039,6 +3040,113