[GitHub] [calcite] xndai commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-25 Thread GitBox
xndai commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r445712632 ## File path: core/src/main/java/org/apache/calcite/util/graph/Graphs.java ## @@ -102,41 +99,28 @@ public int size() { */ public static class

[GitHub] [calcite] xndai commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-18 Thread GitBox
xndai commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r442023404 ## File path: core/src/test/java/org/apache/calcite/util/graph/DirectedGraphTest.java ## @@ -66,7 +66,7 @@ assertNull(shortestPath(g, "A", "E"),

[GitHub] [calcite] xndai commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-17 Thread GitBox
xndai commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r441681036 ## File path: core/src/main/java/org/apache/calcite/plan/ConventionTraitDef.java ## @@ -234,10 +234,10 @@ private ConversionData

[GitHub] [calcite] xndai commented on a change in pull request #2027: [CALCITE-4049] Improve the implementation of the shortest-path algorithm

2020-06-16 Thread GitBox
xndai commented on a change in pull request #2027: URL: https://github.com/apache/calcite/pull/2027#discussion_r441156674 ## File path: core/src/main/java/org/apache/calcite/plan/ConventionTraitDef.java ## @@ -234,10 +234,10 @@ private ConversionData