xndai commented on a change in pull request #2027:
URL: https://github.com/apache/calcite/pull/2027#discussion_r442023404



##########
File path: 
core/src/test/java/org/apache/calcite/util/graph/DirectedGraphTest.java
##########
@@ -66,7 +66,7 @@
     assertNull(shortestPath(g, "A", "E"), "There is no path from A to E");
     assertEquals("[]", shortestPath(g, "D", "D").toString());
     assertNull(shortestPath(g, "X", "A"), "Node X is not in the graph");
-    assertEquals("[[A, B, C, D], [A, B, D]]", paths(g, "A", "D").toString());
+    assertEquals("[[A, B, D], [A, B, C, D]]", paths(g, "A", "D").toString());

Review comment:
       where are the tests for getShortestDistance()?

##########
File path: core/src/main/java/org/apache/calcite/util/graph/Graphs.java
##########
@@ -134,7 +135,44 @@ public int size() {
       if (from.equals(to)) {

Review comment:
       I think we can just remove this method. Nobody is using it anymore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to