Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-26 Thread via GitHub
squakez merged PR #5281: URL: https://github.com/apache/camel-k/pull/5281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apac

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
lburgazzoli commented on PR #5281: URL: https://github.com/apache/camel-k/pull/5281#issuecomment-2018277563 ok so I think we should probably follow up with some enhancements in case the operator does not retry. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
squakez commented on PR #5281: URL: https://github.com/apache/camel-k/pull/5281#issuecomment-2018229684 > I don't recall exactly what is the exact machinery so I wonder what happens when the resource is not found or what would happen if the [status](url) sub resource and/or related [topicNa

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
lburgazzoli commented on PR #5281: URL: https://github.com/apache/camel-k/pull/5281#issuecomment-2018223817 I don't recall exactly what is the exact machinery so I wonder what happens when the resource is not found or what would happen if the [status](url) sub resource and/or related [topic

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
squakez commented on code in PR #5281: URL: https://github.com/apache/camel-k/pull/5281#discussion_r1537745850 ## addons/strimzi/duck/v1beta2/duck_types.go: ## @@ -40,6 +40,12 @@ const ( type KafkaTopic struct { metav1.TypeMeta `json:",inline"` metav1.ObjectMe

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
squakez commented on code in PR #5281: URL: https://github.com/apache/camel-k/pull/5281#discussion_r1537708901 ## addons/strimzi/duck/v1beta2/duck_types.go: ## @@ -40,6 +40,12 @@ const ( type KafkaTopic struct { metav1.TypeMeta `json:",inline"` metav1.ObjectMe

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
lburgazzoli commented on code in PR #5281: URL: https://github.com/apache/camel-k/pull/5281#discussion_r1537697837 ## addons/strimzi/duck/v1beta2/duck_types.go: ## @@ -40,6 +40,12 @@ const ( type KafkaTopic struct { metav1.TypeMeta `json:",inline"` metav1.Obje

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
squakez commented on code in PR #5281: URL: https://github.com/apache/camel-k/pull/5281#discussion_r1537693558 ## addons/strimzi/duck/v1beta2/duck_types.go: ## @@ -40,6 +40,12 @@ const ( type KafkaTopic struct { metav1.TypeMeta `json:",inline"` metav1.ObjectMe

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
lburgazzoli commented on code in PR #5281: URL: https://github.com/apache/camel-k/pull/5281#discussion_r1537689066 ## addons/strimzi/duck/v1beta2/duck_types.go: ## @@ -40,6 +40,12 @@ const ( type KafkaTopic struct { metav1.TypeMeta `json:",inline"` metav1.Obje

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
lburgazzoli commented on code in PR #5281: URL: https://github.com/apache/camel-k/pull/5281#discussion_r1537687133 ## addons/strimzi/duck/v1beta2/duck_types.go: ## @@ -40,6 +40,12 @@ const ( type KafkaTopic struct { metav1.TypeMeta `json:",inline"` metav1.Obje

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
aboucham commented on code in PR #5281: URL: https://github.com/apache/camel-k/pull/5281#discussion_r1537682629 ## addons/strimzi/duck/v1beta2/duck_types.go: ## @@ -40,6 +40,12 @@ const ( type KafkaTopic struct { metav1.TypeMeta `json:",inline"` metav1.ObjectM

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
squakez commented on code in PR #5281: URL: https://github.com/apache/camel-k/pull/5281#discussion_r1537679273 ## addons/strimzi/duck/v1beta2/duck_types.go: ## @@ -40,6 +40,12 @@ const ( type KafkaTopic struct { metav1.TypeMeta `json:",inline"` metav1.ObjectMe

Re: [PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
lburgazzoli commented on code in PR #5281: URL: https://github.com/apache/camel-k/pull/5281#discussion_r1537675545 ## addons/strimzi/duck/v1beta2/duck_types.go: ## @@ -40,6 +40,12 @@ const ( type KafkaTopic struct { metav1.TypeMeta `json:",inline"` metav1.Obje

[PR] feat(strimzi): bind to either KafkaTopic name or topicName [camel-k]

2024-03-25 Thread via GitHub
squakez opened a new pull request, #5281: URL: https://github.com/apache/camel-k/pull/5281 Closes #4759 **Release Note** ```release-note feat(strimzi): bind to either KafkaTopic name or topicName ``` -- This is an automated message from the A