[camel] branch master updated: Regen

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
 new 83152cc  Regen
83152cc is described below

commit 83152ccf27271944a1deb4b94759605c705463b2
Author: Andrea Cosentino 
AuthorDate: Mon Jan 13 08:47:44 2020 +0100

Regen
---
 docs/components/modules/ROOT/pages/jira-component.adoc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/components/modules/ROOT/pages/jira-component.adoc 
b/docs/components/modules/ROOT/pages/jira-component.adoc
index 0447126..87b54e7 100644
--- a/docs/components/modules/ROOT/pages/jira-component.adoc
+++ b/docs/components/modules/ROOT/pages/jira-component.adoc
@@ -254,14 +254,14 @@ Required:
 * `IssueKey`: The issue key identifier.
 * body of the exchange is the description.
 
-== AttachFile
+== Attach
 
 Only one file should attach per invocation.
 
 Required:
 
 * `IssueKey`: The issue key identifier.
-* body of the exchange should be of type `GenericFile`
+* body of the exchange should be of type `File`
 
 == DeleteIssue
 



[camel] branch master updated: Doc update

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
 new 7f6afa6  Doc update
 new ebde3fc  Merge pull request #3477 from cambromley/patch-1
7f6afa6 is described below

commit 7f6afa66cdeb8e42419a2f8eb526b3f20ac7e32a
Author: Cameron Bromley 
AuthorDate: Mon Jan 13 17:21:57 2020 +1100

Doc update

AttachFile isn't in the list of enums at 
org.apache.camel.component.jira.JiraType and it wants a File, not a GenericFile.
---
 components/camel-jira/src/main/docs/jira-component.adoc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/components/camel-jira/src/main/docs/jira-component.adoc 
b/components/camel-jira/src/main/docs/jira-component.adoc
index 860429b..9cc06ab 100644
--- a/components/camel-jira/src/main/docs/jira-component.adoc
+++ b/components/camel-jira/src/main/docs/jira-component.adoc
@@ -253,14 +253,14 @@ Required:
 * `IssueKey`: The issue key identifier.
 * body of the exchange is the description.
 
-== AttachFile
+== Attach
 
 Only one file should attach per invocation.
 
 Required:
 
 * `IssueKey`: The issue key identifier.
-* body of the exchange should be of type `GenericFile`
+* body of the exchange should be of type `File`
 
 == DeleteIssue
 



[GitHub] [camel-kafka-connector] valdar opened a new pull request #73: Added sourcecheck to github actions, added master push github action …

2020-01-12 Thread GitBox
valdar opened a new pull request #73: Added sourcecheck to github actions, 
added master push github action …
URL: https://github.com/apache/camel-kafka-connector/pull/73
 
 
   …workflow and badge in readme.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[camel] 03/07: Camel-Controbus: Improve TIP section

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 1353e4e8cdfed17df92bfbc1abe658d81c2da031
Author: Andrea Cosentino 
AuthorDate: Sun Jan 12 17:15:24 2020 +0100

Camel-Controbus: Improve TIP section
---
 components/camel-controlbus/src/main/docs/controlbus-component.adoc | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git 
a/components/camel-controlbus/src/main/docs/controlbus-component.adoc 
b/components/camel-controlbus/src/main/docs/controlbus-component.adoc
index 19e2fa7..ca5f2d3 100644
--- a/components/camel-controlbus/src/main/docs/controlbus-component.adoc
+++ b/components/camel-controlbus/src/main/docs/controlbus-component.adoc
@@ -224,4 +224,7 @@ We use `async=true` to stop Camel asynchronously as 
otherwise we
 would be trying to stop Camel while it was in-flight processing the
 message we sent to the control bus component.
 
-TIP: You can also use other languages such as 
xref:groovy-language.adoc[Groovy], etc.
+[TIP]
+
+You can also use other languages such as xref:groovy-language.adoc[Groovy], 
etc.
+



[camel] 05/07: Camel-CXF: Improve TIP section

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 23b34f3e01a23127274937d895f5aa4a595283fe
Author: Andrea Cosentino 
AuthorDate: Sun Jan 12 17:17:45 2020 +0100

Camel-CXF: Improve TIP section
---
 components/camel-cxf/src/main/docs/cxf-component.adoc | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/components/camel-cxf/src/main/docs/cxf-component.adoc 
b/components/camel-cxf/src/main/docs/cxf-component.adoc
index 7d4ad3c..51684fc 100644
--- a/components/camel-cxf/src/main/docs/cxf-component.adoc
+++ b/components/camel-cxf/src/main/docs/cxf-component.adoc
@@ -7,8 +7,11 @@
 *Both producer and consumer is supported*
 // HEADER END
 
-TIP: When using CXF in streaming modes (see DataFormat option), then also
+[TIP]
+
+When using CXF in streaming modes (see DataFormat option), then also
 read about Stream caching.
+
 
 The CXF component provides integration with
 http://cxf.apache.org[Apache CXF] for connecting to 
http://cxf.apache.org/docs/jax-ws.html[JAX-WS] services



[camel] 01/07: Camel-Bean: Improve TIP section

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 077e5e0efca9ea7fa6fcd3b23754325bf5364297
Author: Andrea Cosentino 
AuthorDate: Sun Jan 12 17:13:51 2020 +0100

Camel-Bean: Improve TIP section
---
 components/camel-bean/src/main/docs/class-component.adoc | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/components/camel-bean/src/main/docs/class-component.adoc 
b/components/camel-bean/src/main/docs/class-component.adoc
index 0f3dfb1..36932e9 100644
--- a/components/camel-bean/src/main/docs/class-component.adoc
+++ b/components/camel-bean/src/main/docs/class-component.adoc
@@ -123,6 +123,9 @@ Which will lookup a bean from the Registry with the
 id `foo` and invoke the `setCool` method on the created instance of the
 `MyPrefixBean` class.
 
-TIP:See more details at the xref:bean-component.adoc[Bean] component as the 
*class*
+[TIP]
+
+See more details at the xref:bean-component.adoc[Bean] component as the *class*
 component works in much the same way.
+
 



[camel] 06/07: Camel-Direct: Improve TIP sections

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 861db59db643e9545c20e0c81291dc4c8cc5cf17
Author: Andrea Cosentino 
AuthorDate: Sun Jan 12 17:19:28 2020 +0100

Camel-Direct: Improve TIP sections
---
 components/camel-direct/src/main/docs/direct-component.adoc | 12 ++--
 docs/components/modules/ROOT/pages/cxf-component.adoc   |  5 -
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/components/camel-direct/src/main/docs/direct-component.adoc 
b/components/camel-direct/src/main/docs/direct-component.adoc
index 90b7ed9..da4eb34 100644
--- a/components/camel-direct/src/main/docs/direct-component.adoc
+++ b/components/camel-direct/src/main/docs/direct-component.adoc
@@ -12,13 +12,21 @@ consumers when a producer sends a message exchange. +
  This endpoint can be used to connect existing routes in the *same*
 camel context.
 
-TIP: *Asynchronous*
+[TIP]
+
+*Asynchronous*
+
 The xref:seda-component.adoc[SEDA] component provides asynchronous invocation 
of
 any consumers when a producer sends a message exchange.
+
+
+[TIP]
+
+*Connection to other camel contexts*
 
-TIP: *Connection to other camel contexts*
 The xref:vm-component.adoc[VM] component provides connections between Camel
 contexts as long they run in the same *JVM*.
+
 
 == URI format
 
diff --git a/docs/components/modules/ROOT/pages/cxf-component.adoc 
b/docs/components/modules/ROOT/pages/cxf-component.adoc
index df88485..e99b906 100644
--- a/docs/components/modules/ROOT/pages/cxf-component.adoc
+++ b/docs/components/modules/ROOT/pages/cxf-component.adoc
@@ -8,8 +8,11 @@
 *Both producer and consumer is supported*
 // HEADER END
 
-TIP: When using CXF in streaming modes (see DataFormat option), then also
+[TIP]
+
+When using CXF in streaming modes (see DataFormat option), then also
 read about Stream caching.
+
 
 The CXF component provides integration with
 http://cxf.apache.org[Apache CXF] for connecting to 
http://cxf.apache.org/docs/jax-ws.html[JAX-WS] services



[camel] 02/07: Regen docs

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 472ea6eddd0dfdc5c832157a59e4dfd39bac1a98
Author: Andrea Cosentino 
AuthorDate: Sun Jan 12 17:14:35 2020 +0100

Regen docs
---
 docs/components/modules/ROOT/pages/class-component.adoc | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/docs/components/modules/ROOT/pages/class-component.adoc 
b/docs/components/modules/ROOT/pages/class-component.adoc
index 4132c69..7884c6c 100644
--- a/docs/components/modules/ROOT/pages/class-component.adoc
+++ b/docs/components/modules/ROOT/pages/class-component.adoc
@@ -124,6 +124,9 @@ Which will lookup a bean from the Registry with the
 id `foo` and invoke the `setCool` method on the created instance of the
 `MyPrefixBean` class.
 
-TIP:See more details at the xref:bean-component.adoc[Bean] component as the 
*class*
+[TIP]
+
+See more details at the xref:bean-component.adoc[Bean] component as the *class*
 component works in much the same way.
+
 



[camel] branch master updated (dbd90bd -> 8103156)

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git.


from dbd90bd  Regen docs
 new 077e5e0  Camel-Bean: Improve TIP section
 new 472ea6e  Regen docs
 new 1353e4e  Camel-Controbus: Improve TIP section
 new fb17967  Regen docs
 new 23b34f3  Camel-CXF: Improve TIP section
 new 861db59  Camel-Direct: Improve TIP sections
 new 8103156  Regen docs

The 7 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 components/camel-bean/src/main/docs/class-component.adoc |  5 -
 .../camel-controlbus/src/main/docs/controlbus-component.adoc |  5 -
 components/camel-cxf/src/main/docs/cxf-component.adoc|  5 -
 components/camel-direct/src/main/docs/direct-component.adoc  | 12 ++--
 docs/components/modules/ROOT/pages/class-component.adoc  |  5 -
 docs/components/modules/ROOT/pages/controlbus-component.adoc |  5 -
 docs/components/modules/ROOT/pages/cxf-component.adoc|  5 -
 docs/components/modules/ROOT/pages/direct-component.adoc | 12 ++--
 8 files changed, 44 insertions(+), 10 deletions(-)



[camel] 04/07: Regen docs

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit fb179674042d8b746cf26daccfbe9713a40cc0b2
Author: Andrea Cosentino 
AuthorDate: Sun Jan 12 17:16:37 2020 +0100

Regen docs
---
 docs/components/modules/ROOT/pages/controlbus-component.adoc | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/docs/components/modules/ROOT/pages/controlbus-component.adoc 
b/docs/components/modules/ROOT/pages/controlbus-component.adoc
index ddaa4d4..ae20572 100644
--- a/docs/components/modules/ROOT/pages/controlbus-component.adoc
+++ b/docs/components/modules/ROOT/pages/controlbus-component.adoc
@@ -225,4 +225,7 @@ We use `async=true` to stop Camel asynchronously as 
otherwise we
 would be trying to stop Camel while it was in-flight processing the
 message we sent to the control bus component.
 
-TIP: You can also use other languages such as 
xref:groovy-language.adoc[Groovy], etc.
+[TIP]
+
+You can also use other languages such as xref:groovy-language.adoc[Groovy], 
etc.
+



[camel] 07/07: Regen docs

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit 810315652b8ce3058b059f330d716c1aa4e90412
Author: Andrea Cosentino 
AuthorDate: Sun Jan 12 17:20:35 2020 +0100

Regen docs
---
 docs/components/modules/ROOT/pages/direct-component.adoc | 12 ++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/docs/components/modules/ROOT/pages/direct-component.adoc 
b/docs/components/modules/ROOT/pages/direct-component.adoc
index bd204c7..f1d7235 100644
--- a/docs/components/modules/ROOT/pages/direct-component.adoc
+++ b/docs/components/modules/ROOT/pages/direct-component.adoc
@@ -13,13 +13,21 @@ consumers when a producer sends a message exchange. +
  This endpoint can be used to connect existing routes in the *same*
 camel context.
 
-TIP: *Asynchronous*
+[TIP]
+
+*Asynchronous*
+
 The xref:seda-component.adoc[SEDA] component provides asynchronous invocation 
of
 any consumers when a producer sends a message exchange.
+
+
+[TIP]
+
+*Connection to other camel contexts*
 
-TIP: *Connection to other camel contexts*
 The xref:vm-component.adoc[VM] component provides connections between Camel
 contexts as long they run in the same *JVM*.
+
 
 == URI format
 



[camel-kafka-connector] branch master updated: Updated integration test image to kafka 2.4

2020-01-12 Thread valdar
This is an automated email from the ASF dual-hosted git repository.

valdar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git


The following commit(s) were added to refs/heads/master by this push:
 new 84ea014  Updated integration test image to kafka 2.4
84ea014 is described below

commit 84ea014f193fec1cc0a6b2089dd10e6b58b30faa
Author: Andrea Tarocchi 
AuthorDate: Sun Jan 12 15:51:37 2020 +0100

Updated integration test image to kafka 2.4
---
 parent/pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/parent/pom.xml b/parent/pom.xml
index a4d5590..a9cdf46 100644
--- a/parent/pom.xml
+++ b/parent/pom.xml
@@ -68,8 +68,8 @@
 3.0.0-M4
 3.0
 
-
strimzi/kafka:0.15.0-kafka-2.3.1
-
strimzi/kafka:0.15.0-kafka-2.3.1
+
strimzi/kafka:0.16.0-rc1-kafka-2.4.0
+
strimzi/kafka:0.16.0-rc1-kafka-2.4.0
 
 
 



[GitHub] [camel-kafka-connector] valdar merged pull request #72: Updated integration test image to kafka 2.4

2020-01-12 Thread GitBox
valdar merged pull request #72: Updated integration test image to kafka 2.4
URL: https://github.com/apache/camel-kafka-connector/pull/72
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] valdar opened a new pull request #72: Updated integration test image to kafka 2.4

2020-01-12 Thread GitBox
valdar opened a new pull request #72: Updated integration test image to kafka 
2.4
URL: https://github.com/apache/camel-kafka-connector/pull/72
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] valdar commented on issue #67: Flaky test: CamelSinkCassandraITCase

2020-01-12 Thread GitBox
valdar commented on issue #67: Flaky test: CamelSinkCassandraITCase
URL: 
https://github.com/apache/camel-kafka-connector/issues/67#issuecomment-573420790
 
 
   Sounds reasonable to me!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] valdar closed issue #67: Flaky test: CamelSinkCassandraITCase

2020-01-12 Thread GitBox
valdar closed issue #67: Flaky test: CamelSinkCassandraITCase
URL: https://github.com/apache/camel-kafka-connector/issues/67
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[camel-kafka-connector] branch master updated (d9bade3 -> 7063630)

2020-01-12 Thread valdar
This is an automated email from the ASF dual-hosted git repository.

valdar pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git.


from d9bade3  Merge pull request #71 from orpiske/issue-67-cassandra-it-case
 add 75e8953  Added support for testing the Kafka service using Strimzi
 add bbd3162  Fixed rebase issues.
 add feea539  Made the itest images configurable at test-run time.
 add 699c3b3  itests updatet to use strimzi/kafka:0.15.0-kafka-2.3.1 image.
 new 7063630  Added support for testing the Kafka service using Strimzi 
(#66)

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 parent/pom.xml |  3 +
 tests/pom.xml  |  2 +-
 .../services/kafka/KafkaServiceFactory.java| 10 ++-
 .../services/kafka/StrimziContainer.java   | 71 ++
 ...rLocalKafkaService.java => StrimziService.java} | 32 +++---
 .../services/kafka/ZookeeperContainer.java | 57 +
 6 files changed, 164 insertions(+), 11 deletions(-)
 create mode 100644 
tests/src/test/java/org/apache/camel/kafkaconnector/services/kafka/StrimziContainer.java
 copy 
tests/src/test/java/org/apache/camel/kafkaconnector/services/kafka/{ContainerLocalKafkaService.java
 => StrimziService.java} (54%)
 create mode 100644 
tests/src/test/java/org/apache/camel/kafkaconnector/services/kafka/ZookeeperContainer.java



[GitHub] [camel-kafka-connector] valdar closed issue #43: Replace `confluentinc/cp-kafka` image with an upstream version

2020-01-12 Thread GitBox
valdar closed issue #43: Replace `confluentinc/cp-kafka` image with an upstream 
version
URL: https://github.com/apache/camel-kafka-connector/issues/43
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[camel-kafka-connector] 01/01: Added support for testing the Kafka service using Strimzi (#66)

2020-01-12 Thread valdar
This is an automated email from the ASF dual-hosted git repository.

valdar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git

commit 7063630d23820eefa97e28e37c104ba40fae3fa6
Merge: d9bade3 699c3b3
Author: Andrea Tarocchi 
AuthorDate: Sun Jan 12 15:29:46 2020 +0100

Added support for testing the Kafka service using Strimzi (#66)

Added support for testing the Kafka service using Strimzi

 parent/pom.xml |  3 +
 tests/pom.xml  |  2 +-
 .../services/kafka/KafkaServiceFactory.java| 10 ++-
 .../services/kafka/StrimziContainer.java   | 71 ++
 .../services/kafka/StrimziService.java | 57 +
 .../services/kafka/ZookeeperContainer.java | 57 +
 6 files changed, 196 insertions(+), 4 deletions(-)




[GitHub] [camel-kafka-connector] valdar commented on a change in pull request #66: Added support for testing the Kafka service using Strimzi

2020-01-12 Thread GitBox
valdar commented on a change in pull request #66: Added support for testing the 
Kafka service using Strimzi
URL: 
https://github.com/apache/camel-kafka-connector/pull/66#discussion_r365586777
 
 

 ##
 File path: 
tests/src/test/java/org/apache/camel/kafkaconnector/services/kafka/StrimziContainer.java
 ##
 @@ -0,0 +1,71 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one or more
+ *  contributor license agreements.  See the NOTICE file distributed with
+ *  this work for additional information regarding copyright ownership.
+ *  The ASF licenses this file to You under the Apache License, Version 2.0
+ *  (the "License"); you may not use this file except in compliance with
+ *  the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package org.apache.camel.kafkaconnector.services.kafka;
+
+import java.util.function.Consumer;
+import com.github.dockerjava.api.command.CreateContainerCmd;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.Network;
+import org.testcontainers.containers.wait.strategy.Wait;
+
+public class StrimziContainer extends GenericContainer {
+private static final String STRIMZI_CONTAINER = 
System.getProperty("itest.strimzi.container.image");
+private static final int KAFKA_PORT = 9092;
+
+public StrimziContainer(Network network, String name) {
+super(STRIMZI_CONTAINER);
+
+withEnv("LOG_DIR", "/tmp/logs");
+withExposedPorts(KAFKA_PORT);
 
 Review comment:
   These were my conclusions as well, but it wasn't clear to me looking at the 
2 docker files which difference resulted in the different behavior.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] valdar merged pull request #66: Added support for testing the Kafka service using Strimzi

2020-01-12 Thread GitBox
valdar merged pull request #66: Added support for testing the Kafka service 
using Strimzi
URL: https://github.com/apache/camel-kafka-connector/pull/66
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-k] lreimer commented on issue #1190: Invalid JSON Patch error when running simple Camel-K example with 1.0.0-RC1

2020-01-12 Thread GitBox
lreimer commented on issue #1190: Invalid JSON Patch error when running simple 
Camel-K example with 1.0.0-RC1
URL: https://github.com/apache/camel-k/issues/1190#issuecomment-573408662
 
 
   Here is the output when I describe the build pod: 
   
   `$ kubectl describe pod camel-k-kit-bodfc1v0hp20sgnj6nfg`
   
   ```
   Name:   camel-k-kit-bodfc1v0hp20sgnj6nfg-builder
   Namespace:  default
   Priority:   0
   Node:   docker-desktop/192.168.65.3
   Start Time: Sun, 12 Jan 2020 11:37:01 +0100
   Labels: camel.apache.org/build=kit-bodfc1v0hp20sgnj6nfg
   camel.apache.org/component=builder
   Annotations:
   Status: Failed
   IP: 10.1.4.95
   IPs:
   Controlled By:  Build/kit-bodfc1v0hp20sgnj6nfg
   Init Containers:
 builder:
   Container ID:  
docker://530b629fc6996b812c4f2c449ad776725df95ef14ed58801907b338363a33b05
   Image: docker.io/apache/camel-k:1.0.0-RC1
   Image ID:  
docker-pullable://apache/camel-k@sha256:fc0f9d73e752b84b68808bcb7144de195862db0408f23358e0fb6a77dbda814d
   Port:  
   Host Port: 
   Command:
 kamel
 builder
 --namespace
 default
 --build-name
 kit-bodfc1v0hp20sgnj6nfg
 --task-name
 builder
   State:  Terminated
 Reason:   Error
 Exit Code:1
 Started:  Sun, 12 Jan 2020 11:37:04 +0100
 Finished: Sun, 12 Jan 2020 11:37:27 +0100
   Ready:  False
   Restart Count:  0
   Environment:
   Mounts:
 /builder from camel-k-builder (rw)
 /var/run/secrets/kubernetes.io/serviceaccount from 
camel-k-builder-token-f2h9z (ro)
   Containers:
 kaniko:
   Container ID:
   Image: gcr.io/kaniko-project/executor:v0.14.0
   Image ID:
   Port:  
   Host Port: 
   Args:
 --dockerfile=Dockerfile
 --context=/builder/kit-bodfc1v0hp20sgnj6nfg/package/context
 
--destination=docker.io/lreimer/camel-k-kit-bodfc1v0hp20sgnj6nfg:1108690
 --cache=false
 --cache-dir=/kaniko/cache
   State:  Waiting
 Reason:   PodInitializing
   Ready:  False
   Restart Count:  0
   Environment:
   Mounts:
 /builder from camel-k-builder (rw)
 /kaniko/.docker from kaniko-secret (rw)
 /var/run/secrets/kubernetes.io/serviceaccount from 
camel-k-builder-token-f2h9z (ro)
   Conditions:
 Type  Status
 Initialized   False
 Ready False
 ContainersReady   False
 PodScheduled  True
   Volumes:
 camel-k-builder:
   Type:   EmptyDir (a temporary directory that shares a pod's lifetime)
   Medium:
   SizeLimit:  
 kaniko-secret:
   Type:Secret (a volume populated by a Secret)
   SecretName:  docker-registry-secret
   Optional:false
 camel-k-builder-token-f2h9z:
   Type:Secret (a volume populated by a Secret)
   SecretName:  camel-k-builder-token-f2h9z
   Optional:false
   QoS Class:   BestEffort
   Node-Selectors:  
   Tolerations: node.kubernetes.io/not-ready:NoExecute for 300s
node.kubernetes.io/unreachable:NoExecute for 300s
   Events:
 TypeReason Age   From Message
 --    ---
 Normal  Scheduled  80m   default-schedulerSuccessfully assigned 
default/camel-k-kit-bodfc1v0hp20sgnj6nfg-builder to docker-desktop
 Normal  Pulled 80m   kubelet, docker-desktop  Container image 
"docker.io/apache/camel-k:1.0.0-RC1" already present on machine
 Normal  Created80m   kubelet, docker-desktop  Created container builder
 Normal  Started80m   kubelet, docker-desktop  Started container builder
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-k] lreimer opened a new issue #1190: Invalid JSON Patch error when running simple Camel-K example with 1.0.0-RC1

2020-01-12 Thread GitBox
lreimer opened a new issue #1190: Invalid JSON Patch error when running simple 
Camel-K example with 1.0.0-RC1
URL: https://github.com/apache/camel-k/issues/1190
 
 
   Just wanted to give the latest Camel-K release 1.0.0-RC1 a try. Installation 
went OK. Camel-K itself is running. I then issue the simple command `kamel run 
hello.groovy`.
   
   After some time the started build-kit pod will end up in an _Init:Error_ 
state. Reason seems to be that the *builder* init container stops and exits 
with an error. The last line in the logs of the init container ist the 
following:
   
   ```json
   
{"level":"error","ts":1578825389.8346853,"logger":"camel-k.builder","msg":"","error":"Invalid
 JSON 
Patch","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\tgithub.com/go-logr/zapr@v0.1.1/zapr.go:128\ngithub.com/apache/camel-k/pkg/util/log.Logger.Error\n\tgithub.com/apache/camel-k@/pkg/util/log/log.go:74\ngithub.com/apache/camel-k/pkg/cmd/builder.exitOnError\n\tgithub.com/apache/camel-k@/pkg/cmd/builder/builder.go:105\ngithub.com/apache/camel-k/pkg/cmd/builder.Run\n\tgithub.com/apache/camel-k@/pkg/cmd/builder/builder.go:91\ngithub.com/apache/camel-k/pkg/cmd.(*builderCmdOptions).run\n\tgithub.com/apache/camel-k@/pkg/cmd/builder.go:51\ngithub.com/spf13/cobra.(*Command).execute\n\tgithub.com/spf13/cobra@v0.0.5/command.go:830\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\tgithub.com/spf13/cobra@v0.0.5/command.go:914\ngithub.com/spf13/cobra.(*Command).Execute\n\tgithub.com/spf13/cobra@v0.0.5/command.go:864\nmain.main\n\tgithub.com/apache/camel-k@/cmd/kamel/main.go:46\nruntime.main\n\truntime/proc.go:203"}
   ```
   
   I am running everything locally on a Mac using Docker Desktop with 
Kubernetes enabled:
   - Engine: 19.03.5
   - Kubernetes: v1.14.8


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] orpiske commented on issue #66: Added support for testing the Kafka service using Strimzi

2020-01-12 Thread GitBox
orpiske commented on issue #66: Added support for testing the Kafka service 
using Strimzi
URL: 
https://github.com/apache/camel-kafka-connector/pull/66#issuecomment-573402669
 
 
   > @orpiske I fixed as you suggested and made possible to configure the image 
at test-run time. I also bumped the used image version to 
`strimzi/kafka:0.15.0-kafka-2.3.1`. Can you please review it?
   
   I think everything looks alright. I think we should use this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] orpiske commented on a change in pull request #66: Added support for testing the Kafka service using Strimzi

2020-01-12 Thread GitBox
orpiske commented on a change in pull request #66: Added support for testing 
the Kafka service using Strimzi
URL: 
https://github.com/apache/camel-kafka-connector/pull/66#discussion_r365573713
 
 

 ##
 File path: 
tests/src/test/java/org/apache/camel/kafkaconnector/services/kafka/StrimziContainer.java
 ##
 @@ -0,0 +1,71 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one or more
+ *  contributor license agreements.  See the NOTICE file distributed with
+ *  this work for additional information regarding copyright ownership.
+ *  The ASF licenses this file to You under the Apache License, Version 2.0
+ *  (the "License"); you may not use this file except in compliance with
+ *  the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package org.apache.camel.kafkaconnector.services.kafka;
+
+import java.util.function.Consumer;
+import com.github.dockerjava.api.command.CreateContainerCmd;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.Network;
+import org.testcontainers.containers.wait.strategy.Wait;
+
+public class StrimziContainer extends GenericContainer {
+private static final String STRIMZI_CONTAINER = 
System.getProperty("itest.strimzi.container.image");
+private static final int KAFKA_PORT = 9092;
+
+public StrimziContainer(Network network, String name) {
+super(STRIMZI_CONTAINER);
+
+withEnv("LOG_DIR", "/tmp/logs");
+withExposedPorts(KAFKA_PORT);
 
 Review comment:
   TBH, I think there's more to it than this. 
   
   The tests work fine if we remove the withExposedPorts(KAFKA_PORT) and run 
the tests using ```strimzi/kafka:0.11.4-kafka-2.1.0``` image
   
   ```mvn -Ditest.zookeeper.container.image=strimzi/kafka:0.11.4-kafka-2.1.0 
-Ditest.strimzi.container.image=strimzi/kafka:0.11.4-kafka-2.1.0 
-DskipIntegrationTests=false clean verify package```
   
   However, the same thing using ```strimzi/kafka:0.15.0-kafka-2.3.1``` leads 
to a failure: 
   
   ```Caused by: org.testcontainers.containers.ContainerLaunchException: 
Container startup failed```
   
   Looking at the docker ps output for both, it seems it does not expose the 
port for the newer image:
   
   ```
   48ffc42dfae8strimzi/kafka:0.11.4-kafka-2.1.0"sh -c 
'bin/kafka-se…"   About a minute ago   Up About a minute   
0.0.0.0:9092->9092/tcp, 0.0.0.0:32979->9091/tcp, 0.0.0.0:32978->9404/tcp
  strimzi
   ```
   
   ```
   e30afed7a6bcstrimzi/kafka:0.15.0-kafka-2.3.1"sh -c 
'bin/kafka-se…"   55 seconds ago  Up 54 seconds 
strimzi
   ```
   
   Adding the ```withExposedPorts(KAFKA_PORT);``` makes it work for both the 
older and the newer strimzi images. 
   
   I am guessing that differences on Dockerfiles may also play a part on why it 
worked without that for the older image.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[camel-kafka-connector] branch master updated: Fix issue #67: Flaky test: CamelSinkCassandraITCase

2020-01-12 Thread acosentino
This is an automated email from the ASF dual-hosted git repository.

acosentino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git


The following commit(s) were added to refs/heads/master by this push:
 new f5f1915  Fix issue #67: Flaky test: CamelSinkCassandraITCase
 new d9bade3  Merge pull request #71 from orpiske/issue-67-cassandra-it-case
f5f1915 is described below

commit f5f1915fa1fa2d26e3bdbfbc75edaaf10cc6fe1d
Author: Otavio R. Piske 
AuthorDate: Sun Jan 12 10:40:33 2020 +0100

Fix issue #67: Flaky test: CamelSinkCassandraITCase

Check for the expected amount of data in the destination table instead of 
just whether any data is present
---
 .../camel/kafkaconnector/clients/cassandra/dao/TestDataDao.java   | 8 +---
 .../kafkaconnector/sink/cassandra/CamelSinkCassandraITCase.java   | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git 
a/tests/src/test/java/org/apache/camel/kafkaconnector/clients/cassandra/dao/TestDataDao.java
 
b/tests/src/test/java/org/apache/camel/kafkaconnector/clients/cassandra/dao/TestDataDao.java
index 24dfce8..1059675 100644
--- 
a/tests/src/test/java/org/apache/camel/kafkaconnector/clients/cassandra/dao/TestDataDao.java
+++ 
b/tests/src/test/java/org/apache/camel/kafkaconnector/clients/cassandra/dao/TestDataDao.java
@@ -78,8 +78,8 @@ public class TestDataDao {
 session.execute(statement);
 }
 
-public boolean hasData() {
-ResultSet rs = session.execute("select * from test_data");
+public boolean hasEnoughData(long expected) {
+ResultSet rs = session.execute("select count(*) from test_data");
 
 if (rs == null) {
 return false;
@@ -90,7 +90,9 @@ public class TestDataDao {
 return false;
 }
 
-return true;
+long count = all.get(0).getLong("count");
+
+return count == expected;
 }
 
 public String getInsertStatement() {
diff --git 
a/tests/src/test/java/org/apache/camel/kafkaconnector/sink/cassandra/CamelSinkCassandraITCase.java
 
b/tests/src/test/java/org/apache/camel/kafkaconnector/sink/cassandra/CamelSinkCassandraITCase.java
index be541cc..856016b 100644
--- 
a/tests/src/test/java/org/apache/camel/kafkaconnector/sink/cassandra/CamelSinkCassandraITCase.java
+++ 
b/tests/src/test/java/org/apache/camel/kafkaconnector/sink/cassandra/CamelSinkCassandraITCase.java
@@ -109,7 +109,7 @@ public class CamelSinkCassandraITCase extends 
AbstractKafkaTest {
 fail("Timed out wait for data to be added to the Kafka cluster");
 }
 
-TestCommon.waitFor(testDataDao::hasData);
+TestCommon.waitFor(testDataDao::hasEnoughData, (long) expect);
 testDataDao.getData(this::checkRetrievedData);
 assertTrue(String.format("Did not receive as much data as expected: %d 
< %d", received, expect),
 received >= expect);



[GitHub] [camel-kafka-connector] oscerd merged pull request #71: Fix issue #67: Flaky test: CamelSinkCassandraITCase

2020-01-12 Thread GitBox
oscerd merged pull request #71: Fix issue #67: Flaky test: 
CamelSinkCassandraITCase
URL: https://github.com/apache/camel-kafka-connector/pull/71
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] orpiske commented on a change in pull request #66: Added support for testing the Kafka service using Strimzi

2020-01-12 Thread GitBox
orpiske commented on a change in pull request #66: Added support for testing 
the Kafka service using Strimzi
URL: 
https://github.com/apache/camel-kafka-connector/pull/66#discussion_r365570628
 
 

 ##
 File path: 
tests/src/test/java/org/apache/camel/kafkaconnector/services/kafka/StrimziContainer.java
 ##
 @@ -0,0 +1,71 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one or more
+ *  contributor license agreements.  See the NOTICE file distributed with
+ *  this work for additional information regarding copyright ownership.
+ *  The ASF licenses this file to You under the Apache License, Version 2.0
+ *  (the "License"); you may not use this file except in compliance with
+ *  the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package org.apache.camel.kafkaconnector.services.kafka;
+
+import java.util.function.Consumer;
+import com.github.dockerjava.api.command.CreateContainerCmd;
+import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.containers.Network;
+import org.testcontainers.containers.wait.strategy.Wait;
+
+public class StrimziContainer extends GenericContainer {
+private static final String STRIMZI_CONTAINER = 
System.getProperty("itest.strimzi.container.image");
+private static final int KAFKA_PORT = 9092;
+
+public StrimziContainer(Network network, String name) {
+super(STRIMZI_CONTAINER);
+
+withEnv("LOG_DIR", "/tmp/logs");
+withExposedPorts(KAFKA_PORT);
 
 Review comment:
   It works because of the call to [addFixedExposedPort(KAFKA_PORT, 
KAFKA_PORT)](https://github.com/apache/camel-kafka-connector/pull/66/commits/75e8953c0f3d224d1c1e9309bd3dc7ebd5d24bfc#diff-98b65a9f0c00948336e48a4237b379e5R65)
 on the start() method. 
   
   Maybe we should add a comment here, but the explanation is that this makes 
the port mapping from the localhost to inside the container to use the same 
standard Kafka port (i.e: like running docker -p 9092:9092). The usage of 
withExposedPort will configure it to use a dynamic port which may require 
further configuration on the Kafka client. 
   
   The addFixedExposedPort is the default behaviour for the Kafka container, 
which is why I had originally used it here as well. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] orpiske commented on a change in pull request #66: Added support for testing the Kafka service using Strimzi

2020-01-12 Thread GitBox
orpiske commented on a change in pull request #66: Added support for testing 
the Kafka service using Strimzi
URL: 
https://github.com/apache/camel-kafka-connector/pull/66#discussion_r365569972
 
 

 ##
 File path: tests/pom.xml
 ##
 @@ -178,7 +178,7 @@
 maven-failsafe-plugin
 
 
--Dcom.amazonaws.sdk.disableCbor=true
+-Dcom.amazonaws.sdk.disableCbor=true 
-Ditest.strimzi.container.image=${itest.strimzi.container.image} 
-Ditest.zookeeper.container.image=${itest.zookeeper.container.image}
 
 Review comment:
   Yes, I think this does the trick.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] orpiske edited a comment on issue #67: Flaky test: CamelSinkCassandraITCase

2020-01-12 Thread GitBox
orpiske edited a comment on issue #67: Flaky test: CamelSinkCassandraITCase
URL: 
https://github.com/apache/camel-kafka-connector/issues/67#issuecomment-573396777
 
 
   > @orpiske any idea on this one?
   
   I think so. It looks like I inadvertently added a time-of-check-time-of-use 
kind of bug. I was looking at the 
[hasData](https://github.com/apache/camel-kafka-connector/blob/master/tests/src/test/java/org/apache/camel/kafkaconnector/clients/cassandra/dao/TestDataDao.java#L82)
 and the code is only checking if some amount of data is in the table and not 
if the right amount of data is there. This could cause the wait to release too 
early and the subsequent check for the right amount of messages to fail. 
   
   I'll send a PR to fix this. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] orpiske opened a new pull request #71: Fix issue #67: Flaky test: CamelSinkCassandraITCase

2020-01-12 Thread GitBox
orpiske opened a new pull request #71: Fix issue #67: Flaky test: 
CamelSinkCassandraITCase
URL: https://github.com/apache/camel-kafka-connector/pull/71
 
 
   Check for the expected amount of data in the destination table instead of 
just whether any data is present


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] orpiske commented on issue #67: Flaky test: CamelSinkCassandraITCase

2020-01-12 Thread GitBox
orpiske commented on issue #67: Flaky test: CamelSinkCassandraITCase
URL: 
https://github.com/apache/camel-kafka-connector/issues/67#issuecomment-573396777
 
 
   > @orpiske any idea on this one?
   
   I think so. It looks like I inadvertently added a time-of-check-time-of-use 
kind of bug. I was looking at the 
[hasData](https://github.com/apache/camel-kafka-connector/blob/master/tests/src/test/java/org/apache/camel/kafkaconnector/clients/cassandra/dao/TestDataDao.java#L82)
 and I am only checking if some amount of data is in the table and not if the 
right amount of data is there. This could cause the wait to release too early 
and the subsequent check for the right amount of messages to fail. 
   
   I'll send a PR to fix this. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [camel-kafka-connector] orpiske edited a comment on issue #67: Flaky test: CamelSinkCassandraITCase

2020-01-12 Thread GitBox
orpiske edited a comment on issue #67: Flaky test: CamelSinkCassandraITCase
URL: 
https://github.com/apache/camel-kafka-connector/issues/67#issuecomment-573396777
 
 
   > @orpiske any idea on this one?
   
   I think so. It looks like I inadvertently added a time-of-check-time-of-use 
kind of bug. I was looking at the 
[hasData](https://github.com/apache/camel-kafka-connector/blob/master/tests/src/test/java/org/apache/camel/kafkaconnector/clients/cassandra/dao/TestDataDao.java#L82)
 and I the code is only checking if some amount of data is in the table and not 
if the right amount of data is there. This could cause the wait to release too 
early and the subsequent check for the right amount of messages to fail. 
   
   I'll send a PR to fix this. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services