[jira] [Commented] (CASSANDRA-10750) Minor code improvements

2016-03-06 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182414#comment-15182414 ] Stefania commented on CASSANDRA-10750: -- 3.2. Should we ninja fix CHANGES.txt? > Minor code

[jira] [Commented] (CASSANDRA-10750) Minor code improvements

2016-03-04 Thread Sylvain Lebresne (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179981#comment-15179981 ] Sylvain Lebresne commented on CASSANDRA-10750: -- Can you please dig up in which release

[jira] [Commented] (CASSANDRA-10750) Minor code improvements

2015-12-18 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063942#comment-15063942 ] Stefania commented on CASSANDRA-10750: -- CI looks good now, the failing {{cqlsh_copy_tests}} are

[jira] [Commented] (CASSANDRA-10750) Minor code improvements

2015-12-15 Thread Robert Stupp (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15058265#comment-15058265 ] Robert Stupp commented on CASSANDRA-10750: -- Your changes LGTM and I've cherry-picked them

[jira] [Commented] (CASSANDRA-10750) Minor code improvements

2015-12-15 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15058313#comment-15058313 ] Stefania commented on CASSANDRA-10750: -- bq. Also removed the tail-recursion changes in stress -

[jira] [Commented] (CASSANDRA-10750) Minor code improvements

2015-12-15 Thread Robert Stupp (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057618#comment-15057618 ] Robert Stupp commented on CASSANDRA-10750: -- Yea - {{Stack.java}} produced NPEs because the

[jira] [Commented] (CASSANDRA-10750) Minor code improvements

2015-12-15 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057691#comment-15057691 ] Stefania commented on CASSANDRA-10750: -- Well spotted. I've finished the review, I've put my

[jira] [Commented] (CASSANDRA-10750) Minor code improvements

2015-12-14 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056159#comment-15056159 ] Stefania commented on CASSANDRA-10750: -- [~snazy] : I have just started working on the review and