[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-31 Thread Aleksey Yeschenko (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598501#comment-16598501 ] Aleksey Yeschenko commented on CASSANDRA-14677: --- Thanks, committed as

[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-31 Thread Chris Lohfink (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598299#comment-16598299 ] Chris Lohfink commented on CASSANDRA-14677: --- +1 for patch and Dinesh's idea > Clean up

[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-30 Thread Aleksey Yeschenko (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597357#comment-16597357 ] Aleksey Yeschenko commented on CASSANDRA-14677: --- [~cnlwsu] Pushed a commit to further

[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-30 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597268#comment-16597268 ] Benedict commented on CASSANDRA-14677: -- bq. I think this is a good idea, Dinesh Joshi. +1

[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-30 Thread Aleksey Yeschenko (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597260#comment-16597260 ] Aleksey Yeschenko commented on CASSANDRA-14677: --- bq. From my reading of your patch,

[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-30 Thread Aleksey Yeschenko (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597228#comment-16597228 ] Aleksey Yeschenko commented on CASSANDRA-14677: --- bq. I think it would be helpful for

[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-30 Thread Aleksey Yeschenko (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597222#comment-16597222 ] Aleksey Yeschenko commented on CASSANDRA-14677: --- bq. Also, Request.perform() is an

[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-30 Thread Aleksey Yeschenko (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597219#comment-16597219 ] Aleksey Yeschenko commented on CASSANDRA-14677: --- bq. Previously, we had memoized

[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-30 Thread Dinesh Joshi (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597130#comment-16597130 ] Dinesh Joshi commented on CASSANDRA-14677: -- {quote}I think it would be helpful for

[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-29 Thread Jason Brown (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596951#comment-16596951 ] Jason Brown commented on CASSANDRA-14677: - I took a decent look at the patch provided.

[jira] [Commented] (CASSANDRA-14677) Clean up Message.Request implementations

2018-08-29 Thread Aleksey Yeschenko (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-14677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596885#comment-16596885 ] Aleksey Yeschenko commented on CASSANDRA-14677: --- Code