[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205275#comment-17205275
]
Berenguer Blasi commented on CASSANDRA-15991:
-
[~dcapwell] thanks thanks a million for
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205060#comment-17205060
]
David Capwell commented on CASSANDRA-15991:
---
Thanks [~Bereng] for all the hard work!
>
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204969#comment-17204969
]
David Capwell commented on CASSANDRA-15991:
---
CI results (pending)
Circle:
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204924#comment-17204924
]
David Capwell commented on CASSANDRA-15991:
---
thanks. I need to work on something due
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204423#comment-17204423
]
Berenguer Blasi commented on CASSANDRA-15991:
-
M weird that thing passed for me
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204329#comment-17204329
]
David Capwell commented on CASSANDRA-15991:
---
ok so looks like the read_repair tests and
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204238#comment-17204238
]
David Capwell commented on CASSANDRA-15991:
---
Also see
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204237#comment-17204237
]
David Capwell commented on CASSANDRA-15991:
---
Looks like a new test is failing in Circle CI
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204207#comment-17204207
]
David Capwell commented on CASSANDRA-15991:
---
CI results (still running)
Circle:
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204206#comment-17204206
]
David Capwell commented on CASSANDRA-15991:
---
reviewed latest commit so +1 from me. Ill
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204158#comment-17204158
]
Brandon Williams commented on CASSANDRA-15991:
--
LGTM with latest changes.
> 15583 -
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201827#comment-17201827
]
David Capwell commented on CASSANDRA-15991:
---
Overall LGTM, only very minor comments.
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201788#comment-17201788
]
David Capwell commented on CASSANDRA-15991:
---
starting review now. I am out Friday and
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201054#comment-17201054
]
David Capwell commented on CASSANDRA-15991:
---
Thanks, I have a bit of a hectic week so
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200633#comment-17200633
]
Berenguer Blasi commented on CASSANDRA-15991:
-
[~dcapwell] I rebased and put on top that
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192347#comment-17192347
]
David Capwell commented on CASSANDRA-15991:
---
replied in GH
> 15583 - Add UX tests to
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188324#comment-17188324
]
Berenguer Blasi commented on CASSANDRA-15991:
-
Thanks a lot, really appreciated. I'll
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187984#comment-17187984
]
David Capwell commented on CASSANDRA-15991:
---
[~Bereng] this patch is large so will take a
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187975#comment-17187975
]
David Capwell commented on CASSANDRA-15991:
---
sure, will take a look
> 15583 - Add UX
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186334#comment-17186334
]
Berenguer Blasi commented on CASSANDRA-15991:
-
[~dcapwell] Sam confirmed he's buried atm
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183049#comment-17183049
]
Sam Tunnicliffe commented on CASSANDRA-15991:
-
[~Bereng] yes, it's on my todo list.
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183048#comment-17183048
]
Berenguer Blasi commented on CASSANDRA-15991:
-
[~samt] any chance to get this reviewed?
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174383#comment-17174383
]
Berenguer Blasi commented on CASSANDRA-15991:
-
[~samt] thx for the reply. I'll be out
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17174268#comment-17174268
]
Sam Tunnicliffe commented on CASSANDRA-15991:
-
bq. If you're busy or going to be on
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173047#comment-17173047
]
Berenguer Blasi commented on CASSANDRA-15991:
-
[~samt]I have put this one for review
[
https://issues.apache.org/jira/browse/CASSANDRA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167856#comment-17167856
]
Berenguer Blasi commented on CASSANDRA-15991:
-
This PR seeds most cmd line tools in
26 matches
Mail list logo